From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FFE2CD3440 for ; Wed, 6 May 2026 14:55:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q9IziybJHuk3HSxCnNSfWSRrMnoKvg7/QyPJ8LC6HiM=; b=1HMbIQuMvKp5krVLtjJDr+GqHz R6o0x/hRiqUVn/nBwHQtwnfLLMJSxseIbm8PskWjvorPOi8kzAoX8MP5e0Plxj5XseWikoIxg08LA SlKeXCpvUD0VAppNIreNbSxNPJXb1zOroy8jQIgvL1077cBlmu22cTXxZm7uIiL4SOcINx8PDSKCr slvemWu66P/JxdqpxO5wc2KJ3kFagla6sabDsR5f2jDNOtuIVKaITHrq9ibpc2Dp0RLAxq8lPR35Q yr5lmp4DXfHDbZN9ZFdT312mUTpX8GSep42Ex/xf0PDA5OAEmLbdXJ3RKAr9gNbNKKvJNJ5JYFF2V 8xdgkVhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wKdeR-00000001Bwh-0oKJ; Wed, 06 May 2026 14:55:03 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wKdeP-00000001BuR-0Hno for linux-arm-kernel@lists.infradead.org; Wed, 06 May 2026 14:55:01 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-44a786a9a35so3658081f8f.3 for ; Wed, 06 May 2026 07:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778079299; x=1778684099; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=q9IziybJHuk3HSxCnNSfWSRrMnoKvg7/QyPJ8LC6HiM=; b=do2MoIf3mvu7DVBk9TDfFy9Kr1dalphEbbFfb4hzNPbQP/cdNsSlVQaN7YE8In3sM2 WzLEyrmhqTmfBn5ReI4UGHO3HstSBE5bzzZrVi3mwEWtoU18aTHg48EyS2Nh7Uaqunno dChJ+CGSkEF349sKmtZjyp4TKqH39ZepkcXCTrZO40ztZ7D21JB7NFpC3uSB2dXlqeM/ gWdCjCi2aP5bcW5vidMLinJuHlWk1MdKx5P4wMYQMsB+4lgKyIct9vG0KQicSiGAuNqU dpDu85ry9J0OBVY/WPHmzA3bTxze+IxMhQ6kqN9mTJGOdFioDl2qvEtyTFWJHBtdB3aS 2l+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778079299; x=1778684099; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q9IziybJHuk3HSxCnNSfWSRrMnoKvg7/QyPJ8LC6HiM=; b=I8BkK9L2WiVzCxVveFNggk1XVmYBeced3AOF08jXdbDSikpsHzxPvN8zW3Ems0AkzV JNGPVIFSm1UOgE1T0/PcjjazeWH4c2RJO4B2SfUTpyOzMVRt13njO6tUl1nffoxdWqXh R3HZb4gWkKNU5/QgL8FdOFIlrbBj1adsBUFSnbde1nGYHq/FSC6ySomjoix16sGjhg+H d3i8siYrcoOkNlg5SvUc2fXA8BEwxXv1OSHXiBw4Mc/yrMpwj2cyxuqqlYBzVC01Qbcr Ok8diyrzQnTXQwV/vrxl1oC5pttvCLCwFzJjPmnpiArIdO70JBmyB1uEBUTEkRWCvxU2 EfOA== X-Forwarded-Encrypted: i=1; AFNElJ/OmTw2nJysrRTrkZ8JGxhr81j78jIx3s3DWkbjwhdxVVGfsytdOrx10DVUfbQIrxNpF7rsZOwlmYh34YDSV0TM@lists.infradead.org X-Gm-Message-State: AOJu0Yx8XWIhuHnYKO1xSKCoLBbB9auLFWu5pgYEj3cTSBihrOKwk6WB Aai4YKSv7YTi2zMquVL9VV1GDSsw8yJPStJLr6PaDQ3x1Nos6pYqx3Lwr7QY1O2tkf4= X-Gm-Gg: AeBDieuaIKBURY9Rz9nfdkm5nvStTBTb1DOKPaMSLb2OpE5n2yszFn0oAYroj0XFUbF 3FV4XAdg/7BxsYqNi+SIMXBoEYVOjBYp5CYoDAQ6arOcG2DwtsYBdaZaZi2L5EdY3z7Il1+Cx3R E0k4raXk8vGEFBvHmRgj1KUmMNXKif/sUa8c2+HwcYky5etLDl6HxI///ERkpdnLJW6Hu+Xf1ZD zMF+50kxzV1urtc4eqPK0130Kbc+Zf4bLcKKsAxCC6pNP/KzOX4xwb4zP3NGDXOLT0PlNwG/1+D Wgt5RrL1n9rVgAr1u0dNSf+aya1/SnzZpYdFwcTCTVJ8VJhBVHCRVhtFv8hRyBUZOzSVkG28dLl tMdKv5MghOFbiTZvvxpUvIdyKjbZuTSnlTL7TtaElqde8wW65gxhtz7DUodj4fnxYw69jmk++Hg M7LR5NPTVx5R1/kWtGugx9LwmZybCUhPO6C+0bjUsorzQWDAbVyq6wUzW4V4osfcJJkmb5KAH1V cxqlnZBDbjcnU6iQg== X-Received: by 2002:a5d:64c9:0:b0:44a:3aee:370e with SMTP id ffacd0b85a97d-4515ce1c5aemr6073557f8f.25.1778079298902; Wed, 06 May 2026 07:54:58 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:5798:67fd:c866:b378? ([2a01:e0a:106d:1080:5798:67fd:c866:b378]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45055960902sm14567686f8f.28.2026.05.06.07.54.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 07:54:58 -0700 (PDT) Message-ID: Date: Wed, 6 May 2026 16:54:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH v4 09/16] phy: rockchip: usbdp: Use FIELD_PREP_WM16_CONST To: Sebastian Reichel , Vinod Koul , Heiko Stuebner , Frank Wang , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Yan , Dmitry Baryshkov , Yubing Zhang , Alexey Charkov , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, devicetree@vger.kernel.org References: <20260428-rockchip-usbdp-cleanup-v4-0-7775671ece22@collabora.com> <20260428-rockchip-usbdp-cleanup-v4-9-7775671ece22@collabora.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260428-rockchip-usbdp-cleanup-v4-9-7775671ece22@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260506_075501_123434_25FAC111 X-CRM114-Status: GOOD ( 13.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/28/26 18:13, Sebastian Reichel wrote: > Cleanup code by replacing open-coded version of FIELD_PREP_WM16_CONST > with the existing helper macro. > > Signed-off-by: Sebastian Reichel > --- > drivers/phy/rockchip/phy-rockchip-usbdp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rockchip/phy-rockchip-usbdp.c > index 6d7ca11b308e..1bfc365e2b2c 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -75,7 +76,6 @@ > #define TRSV_LN2_MON_RX_CDR_DONE_OFFSET 0x1b84 /* trsv_reg06E1 */ > #define TRSV_LN2_MON_RX_CDR_LOCK_DONE BIT(0) > > -#define BIT_WRITEABLE_SHIFT 16 > #define PHY_AUX_DP_DATA_POL_NORMAL 0 > #define PHY_AUX_DP_DATA_POL_INVERT 1 > #define PHY_LANE_MUX_USB 0 > @@ -104,8 +104,8 @@ struct rk_udphy_grf_reg { > #define _RK_UDPHY_GEN_GRF_REG(offset, mask, disable, enable) \ > {\ > offset, \ > - FIELD_PREP_CONST(mask, disable) | (mask << BIT_WRITEABLE_SHIFT), \ > - FIELD_PREP_CONST(mask, enable) | (mask << BIT_WRITEABLE_SHIFT), \ > + FIELD_PREP_WM16_CONST(mask, disable), \ > + FIELD_PREP_WM16_CONST(mask, enable), \ > } > > #define RK_UDPHY_GEN_GRF_REG(offset, bitend, bitstart, disable, enable) \ > Reviewed-by: Neil Armstrong Thanks, Neil