From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67120CD13D8 for ; Sat, 31 Aug 2024 15:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N9MjxDrbaua4w9wMZSO5n89c35tDh+VOTCEJqezilSA=; b=eiu15K2MzBcFCNYTnjBXnCLePu EmgNR9IuZN5iS4nf+TgIXUZHpEtlsHN+5397Ask3eJX3iUzEwkD2nJjVbHGU8RS6Y5N4pUVeQ0P2l Ulhvn/Or2dBZBUvZwTVrfNGdUxATvk6X+kEFXX1Q8KAwNvhJvobBvMZf4jtIxz8v/oaWfww92luB6 5jyhKzD1uIVorT/xICEZ15BdcPWEKOTTyXlNBdXAHTXzh4woMue6zrl2ioBuWwzHKsb9qC1CUUje9 6h1R5SNtMW2Mgo73tOQFpNkYaw2dZ9KbAlvtvIvhxX7hLtXCnlqTUlJBWl5unOi5wUa3hRJ/btfWg R8dM6oQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skQ7n-00000009an5-09pG; Sat, 31 Aug 2024 15:34:51 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1skQ6t-00000009ahi-3vpc for linux-arm-kernel@lists.infradead.org; Sat, 31 Aug 2024 15:33:57 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-42c7b5b2d01so3786655e9.3 for ; Sat, 31 Aug 2024 08:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1725118434; x=1725723234; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N9MjxDrbaua4w9wMZSO5n89c35tDh+VOTCEJqezilSA=; b=cmtpJ1+yxexxmqHpakAMBKlmH9+0A2pVU7LpU0e0mMNLB8jUTQH9423bgLMZQfBLAD wBM7zx9NjtDhs1nI5Nc9Q1Eyo3xe8F1zZSlRn4ySPF7EHMPSslRS1LhrukMfSBl+l5zP P9FyPpfoM9/b2Sczbb9nacqmzDyQn2KOgL2CmToHbRvyEgQxcn0pFoditgADL3BI3Gbe AfkcmDyhkNPPBut6c/tavIU9AcYzowGgchn9E+ieC1+tQGDOtyeIOuBNr+YAROFNowLq uJXRxPA05tD85DA7H3HbOGDE1l65xM+Ed6eKKlWPXxqfpYLfVi9WN0GWz5vszG/b0hps x8rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725118434; x=1725723234; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N9MjxDrbaua4w9wMZSO5n89c35tDh+VOTCEJqezilSA=; b=Rsbdv7LMiSsv9iYRdg+h+NRl2CppYuRDOoDRQl690l3vSu9gox0fqrSj2EPgtSOmem KpvOJzntSKJAvp5btW3PBuQr8+M/ebZVQLnKJYOjJvCA9R/5TEoVCesNzjCxwWsqhiux w5nD3NJXWFUMlVXStMggkjqCuFAcbSvkVytJ2CzBqg7hMv5/YXR/AEhWo0Iygm2FWQa4 0+h6EE312n09bmCthALJX3354FAfFOMzhVBtsrtahQxPdScPKfsk69wChkfuP0yt366o 7L1v55yijLU8dEyOfhSR7MekgYCW2pCpFDDI6bLN+rYBBdItlgmmMGDgl/7g5lXlB2XJ iS5A== X-Forwarded-Encrypted: i=1; AJvYcCVZUNY6Iuxkge8MKBEpx+BUMR6xuR8qHNeiQVxoxwuyshr+TQz46/vfkdt8wWxMJVO/qw5MQh7S5UatChtYfrGX@lists.infradead.org X-Gm-Message-State: AOJu0YxTTp2lWP7xJe5LIzvlrFarMTM6CMcOMOXzv24jGjiRB7+aZsGe NRS1I3i/UtOKZcvQrU0ghjd6Yk/iGT8AWXZwVBPe53n2H/kBXeTcNFr25qdiqCM= X-Google-Smtp-Source: AGHT+IGbHkUNqAug0TtbZHZxpqz58AzfONDihCHxG0wzsQG0OM473lIfRYWud/gLeqmeP9GloZ6rAg== X-Received: by 2002:a05:600c:1c83:b0:426:59fe:ac27 with SMTP id 5b1f17b1804b1-42bb01edc2amr81614945e9.26.1725118433566; Sat, 31 Aug 2024 08:33:53 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.144]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6df7c5bsm79364085e9.23.2024.08.31.08.33.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Aug 2024 08:33:53 -0700 (PDT) Message-ID: Date: Sat, 31 Aug 2024 18:33:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 07/12] nvmem: microchip-otpc: Add missing register definitions Content-Language: en-US To: Christian Melki , Srinivas Kandagatla , "moderated list:MICROCHIP OTPC DRIVER" , open list , Nicolas Ferre References: <20240821105943.230281-1-ada@thorsis.com> <20240821105943.230281-8-ada@thorsis.com> <5228af83-b423-4f51-820a-edfc40017ca8@tuxon.dev> <20240828-making-gangrene-786ec368b106@thorsis.com> From: claudiu beznea In-Reply-To: <20240828-making-gangrene-786ec368b106@thorsis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240831_083356_011452_02E6DD06 X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28.08.2024 11:14, Alexander Dahl wrote: > Hello Claudiu, > > Am Sat, Aug 24, 2024 at 06:54:02PM +0300 schrieb claudiu beznea: >> >> >> On 21.08.2024 13:59, Alexander Dahl wrote: >>> According to datasheets DS60001765B for SAMA7G5 and DS60001579G for >>> SAM9X60. >>> >>> Signed-off-by: Alexander Dahl >>> --- >>> drivers/nvmem/microchip-otpc.c | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/drivers/nvmem/microchip-otpc.c b/drivers/nvmem/microchip-otpc.c >>> index b8ed7412dbca..4630e96243ac 100644 >>> --- a/drivers/nvmem/microchip-otpc.c >>> +++ b/drivers/nvmem/microchip-otpc.c >>> @@ -21,9 +21,24 @@ >>> #define MCHP_OTPC_AR (0x8) >>> #define MCHP_OTPC_SR (0xc) >>> #define MCHP_OTPC_SR_READ BIT(6) >>> +#define MCHP_OTPC_IER (0x10) >>> +#define MCHP_OTPC_IDR (0x14) >>> +#define MCHP_OTPC_IMR (0x18) >>> +#define MCHP_OTPC_ISR (0x1C) >>> +#define MCHP_OTPC_ISR_COERR BIT(13) >>> #define MCHP_OTPC_HR (0x20) >>> #define MCHP_OTPC_HR_SIZE GENMASK(15, 8) >>> #define MCHP_OTPC_DR (0x24) >>> +#define MCHP_OTPC_BAR (0x30) >>> +#define MCHP_OTPC_CAR (0x34) >>> +#define MCHP_OTPC_UHC0R (0x50) >>> +#define MCHP_OTPC_UHC1R (0x54) >>> +#define MCHP_OTPC_UID0R (0x60) >>> +#define MCHP_OTPC_UID1R (0x64) >>> +#define MCHP_OTPC_UID2R (0x68) >>> +#define MCHP_OTPC_UID3R (0x6C) >>> +#define MCHP_OTPC_WPMR (0xE4) >>> +#define MCHP_OTPC_WPSR (0xE8) >> >> Are all these used in driver? > > Not all, but some. What are you implying? Only add register > definitions actually used in the driver? Yes! > Why? Less code to maintain. If it's not used there is no meaning to have it. > > Those register offsets won't change, but helped us when debugging. > Debug code (e.g. register dump) is not part of the patch series. > > Greets > Alex > >> >>> >>> #define MCHP_OTPC_NAME "mchp-otpc" >>> #define MCHP_OTPC_SIZE (11 * 1024)