From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CEF4C4363D for ; Fri, 25 Sep 2020 09:11:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11F65206B5 for ; Fri, 25 Sep 2020 09:11:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vTuDkH3B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11F65206B5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e3MEJtmv8tbWZbE0ZGP/ruCke8DCtXpS465ODlKGqok=; b=vTuDkH3Bevwdv/rAeDmObMVJG dsR9ELrUDZzvDY4Km6sVfhoTdP+2ddY+kyAjBXqM37ad139ZqYdbYVd065WxqET1JtkCCXTIhlaRI itfKm6mtA/W+KxmMNBtaiMC52BfwQvR/mAhTEuTgI+8ROSWRPfRvX2vi5MJJ9vS1pKd1cIZogtLww kEm9DQ4uMOzfPSOsmyR609edAwZkSHTt+Jk3J4pUrTQL022m2vewAmDzCycHF/K6zDdr07/xrvs3l vwL3c2seJND97wskZkqRug9cmVAtOUUxiEk5hFf7wLTNhz+0M7aLdEMvfPhgxZA84ziX5V/tdLOJ/ WC4DXDxFQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLjkL-0000n8-TR; Fri, 25 Sep 2020 09:10:29 +0000 Received: from mx.socionext.com ([202.248.49.38]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLjkJ-0000mK-Mj for linux-arm-kernel@lists.infradead.org; Fri, 25 Sep 2020 09:10:28 +0000 Received: from unknown (HELO iyokan-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 25 Sep 2020 18:10:23 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by iyokan-ex.css.socionext.com (Postfix) with ESMTP id 3E3E860060; Fri, 25 Sep 2020 18:10:23 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Fri, 25 Sep 2020 18:10:23 +0900 Received: from yuzu.css.socionext.com (yuzu [172.31.8.45]) by kinkan.css.socionext.com (Postfix) with ESMTP id B546F1A0508; Fri, 25 Sep 2020 18:10:22 +0900 (JST) Received: from [10.212.5.245] (unknown [10.212.5.245]) by yuzu.css.socionext.com (Postfix) with ESMTP id 25612120447; Fri, 25 Sep 2020 18:10:22 +0900 (JST) Subject: Re: [PATCH 2/3] PCI: dwc: Add common iATU register support To: Rob Herring References: <1599814203-14441-1-git-send-email-hayashi.kunihiko@socionext.com> <1599814203-14441-3-git-send-email-hayashi.kunihiko@socionext.com> <20200923155700.GA820801@bogus> From: Kunihiko Hayashi Message-ID: Date: Fri, 25 Sep 2020 18:10:21 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200923155700.GA820801@bogus> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200925_051027_895262_7CCA186E X-CRM114-Status: GOOD ( 19.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi , Jingoo Han , linux-kernel@vger.kernel.org, Murali Karicheri , linux-pci@vger.kernel.org, Bjorn Helgaas , Gustavo Pimentel , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On 2020/09/24 0:57, Rob Herring wrote: > On Fri, Sep 11, 2020 at 05:50:02PM +0900, Kunihiko Hayashi wrote: >> This gets iATU register area from reg property that has reg-names "atu". >> In Synopsys DWC version 4.80 or later, since iATU register area is >> separated from core register area, this area is necessary to get from >> DT independently. >> >> Cc: Murali Karicheri >> Cc: Jingoo Han >> Cc: Gustavo Pimentel >> Suggested-by: Rob Herring >> Signed-off-by: Kunihiko Hayashi >> --- >> drivers/pci/controller/dwc/pcie-designware.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c >> index 4d105ef..4a360bc 100644 >> --- a/drivers/pci/controller/dwc/pcie-designware.c >> +++ b/drivers/pci/controller/dwc/pcie-designware.c >> @@ -10,6 +10,7 @@ >> >> #include >> #include >> +#include >> #include >> >> #include "../../pci.h" >> @@ -526,11 +527,16 @@ void dw_pcie_setup(struct dw_pcie *pci) >> u32 val; >> struct device *dev = pci->dev; >> struct device_node *np = dev->of_node; >> + struct platform_device *pdev; >> >> if (pci->version >= 0x480A || (!pci->version && >> dw_pcie_iatu_unroll_enabled(pci))) { >> pci->iatu_unroll_enabled = true; >> - if (!pci->atu_base) >> + pdev = of_find_device_by_node(np); > > Use to_platform_device(dev) instead. Put that at the beginning as I'm > going to move 'dbi' in here too. Okay, I'll rewrite it with to_platform_device(dev). Should I refer somewhere to rebase to your change? Thank you, --- Best Regards Kunihiko Hayashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel