From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92B69FDEE56 for ; Fri, 24 Apr 2026 02:46:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=anMF1as23eA7xtsnfMdN2TEy44noTjSIt/GIIQtoOkI=; b=Zaxtf2gVIMzcRU7hnF8wJBC6j7 MAxsEFkMBoniSdDCIf9NTFDUejw14pLkEpfN7ZZwSbAqxCRyiUC+ExM0wDSoi2iwz7e7oB28db1Js RTPre4VWhGG7IH6jObPBuco3kzJLQr0BsaSkUf94t1/G3WKHoeCE5fI/H40fr/cUndI+k3S8SkhN9 vhsQkNHlpbZYHi9MaTowKmaPLtNUJvRLvTQNfRAAZ4f0iuXfE5iRqUVJ24utByEDO6hXb1kDFhfMN n6j4UXD1rmcrAscG+yYi+YQgsITbEauWvjRFQ9+DIILy5Y8oteiQZ8FlP00hzZ7fg+iXOb3Vv8SSX lkhKUaaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wG6Yr-0000000CWBN-3G7x; Fri, 24 Apr 2026 02:46:33 +0000 Received: from mail-westusazlp170100001.outbound.protection.outlook.com ([2a01:111:f403:c000::1] helo=BYAPR05CU005.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wG6Yo-0000000CWAx-0qKx for linux-arm-kernel@lists.infradead.org; Fri, 24 Apr 2026 02:46:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uk0MXOcRlODoFZgcenAfCooBZEy6Ohx239PivCC4v5UnyyCbj17kGTANtPzQofmQ36dfBN9W2q/SWsM3+Y7dZRfwzrFqdbgwYS8PyKT6w4LOAyDGsx1bEjmDyWoSFgt7ph9liw6w+8fAA1xBaYqkPWCkApMopM23PPiAc+wfayBkXktkkUXko9HJ6U+yBtv3vnV6YMOS1rhazGsxz8EfO+hLHQsfEvSmceoqpM1QZWWTst5hqmWiGnbXb6LbE53Z0yjpUeLDin9xV8uvgJhlQkQOBXFDoCipvARGqmEUafZV/SWFinThQoiS7bX+v8VwwbUATmGJCwbF/ipkwNHnmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=anMF1as23eA7xtsnfMdN2TEy44noTjSIt/GIIQtoOkI=; b=js96qHkgYydiKSbGISPc0lhzFHPzmkiDoa48/R1KqiTPtGP2h3PG6G1170Nvm+ldjLocTmyw4rl/S/9XButw7U9VxFhZZBqqylp7EKLjOuT8it+UCGutCDHLfYo4jKjeAGwy/QOBDKv51pdCg+Wo2chTOTVAhF77EJypvUSWfBJtxYI2Y6FPdVYhFfdjUgeM4a2SQT/egpikWnyKxltT2ZHKYVAVeBs6fomx/jU1g7IZKG1ODqXpye2WwQ0IoYyHpslxZJ4iGNNpzQA4Qt1ytfEckoM43iaP4aEfErByX8PEym1gE/1DFS+KRHvK3ODXUaFfTXF7soRiKVQGTG78ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=anMF1as23eA7xtsnfMdN2TEy44noTjSIt/GIIQtoOkI=; b=LVMiSJ8VqmPE+T5m/OcpkA9IaoFiBjIWaCiOrkR88HY3PIHjNHCMrysl+lrgqFumi0KSdrXQd22ogFMlLC9We8ZUehAqYBsRuetFiHXyiaPw+w5f/8Ir5MGQ1nbvz8lc3kXA2/1AT/3O33/ekrHd6F3NiGA3iCuWDQ9fHKHMHfYjyzMRtT+qO0Y6dG13U2sWxr9VjInBBDH0+mpsamswpPgwaVlw3kOhEUpe0H4oGIaQqXZ6kDkQtAF9t3bBdyZ5sy7xESnWcO3G0BN6YxuA7VXcUdoDLq5me2JUW3v3WKb1jHm+S1S+LYvOhWjooNC8NFORXIEfpzVgI61OV8sUuQ== Received: from SJ0PR03CA0275.namprd03.prod.outlook.com (2603:10b6:a03:39e::10) by SA1PR12MB6702.namprd12.prod.outlook.com (2603:10b6:806:252::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.20; Fri, 24 Apr 2026 02:46:23 +0000 Received: from SJ5PEPF000001D7.namprd05.prod.outlook.com (2603:10b6:a03:39e:cafe::10) by SJ0PR03CA0275.outlook.office365.com (2603:10b6:a03:39e::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9791.48 via Frontend Transport; Fri, 24 Apr 2026 02:46:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ5PEPF000001D7.mail.protection.outlook.com (10.167.242.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Fri, 24 Apr 2026 02:46:23 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 23 Apr 2026 19:46:06 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 23 Apr 2026 19:46:05 -0700 Received: from Asurada-Nvidia (10.127.8.12) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 23 Apr 2026 19:46:04 -0700 Date: Thu, 23 Apr 2026 19:46:03 -0700 From: Nicolin Chen To: Baolu Lu CC: Will Deacon , Robin Murphy , "Joerg Roedel" , Bjorn Helgaas , "Jason Gunthorpe" , "Rafael J . Wysocki" , "Len Brown" , Pranjal Shrivastava , "Mostafa Saleh" , Kevin Tian , , , , , , , Shuai Xue Subject: Re: [PATCH v3 02/11] iommu: Pass in reset result to pci_dev_reset_iommu_done() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D7:EE_|SA1PR12MB6702:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ace0a23-37dc-42b2-4a62-08dea1abac25 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|7416014|376014|36860700016|13003099007|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: w8WJZQa27c4RLKR+KvrMBZ3ElzaRgjE811EjHt/oQYoD7WBedLOLfxYP+W3RtQZWStsfBNF9XkwTKLJ709hM4t60FhkEh1IpbA1IXNx/4N9qx2ucoYMSXrWLZSLjuke0SbbLiIuKvCoKesgWvf1Y2pCajX8oZoDzYb1MCH4pae0bOflMcbhwPdNUxi3g0sME9It5gkkSw4HdxtkdTK9qTARU2A4TSq3csZ9PSBctwpoLbtwKc8Wfkp/oVwgoWzCu/ZeI1A/S4UC3V1WBEEGuPyMgFVj91uCB0BhBHB+SxKDH59rKxVCT1soAYnRwauAKrv1WVgi0xigw4TGshtPt3kf2+uY17nz1AHWd0bKxHMjeaJdeZQ4G8ZzSBNHZNCeOsZBlo7+2L2O5XxSVnJus3tHp8BWgE0p4rA7gZOuEWC4szyJH+ER0Pny2p4QSjI8Ocj+l6rejc3F79RwMdHzVaFxFpxf10hxYjq4TT4zNg98i6Q3Y+mW4WnRI1xCh7rSeMxy4Tn3uZbYioUvm7vr+V8Nf95g4t1F+Gw7V/NcEf+8ktbwBDqWMfpT7bDrqGKpN9bTsi0Ik/RUNz/hr6aBONYqjbZYeWCfexs1aMqem476FegaWJHTi1u/yJcCAUnfH3EiwnNy5dI6bSRIV1fd/tJn2tMuAK5bbxFsfaYNUdPReuDY3cUjmTS4pMF0t31vUVy0Vvm+WXSkAwFrgtTM0PwanOV/fwnAhIVNE59kGg5BfMp3sqRiaBUVgAjm11ptwgMCxJ0mXgPzfFbWUJZE2Jw== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(7416014)(376014)(36860700016)(13003099007)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: AxpgwnUuc/6BlISJ5EccKGp9tl0whl94UtwzGOGy9aU4yqOnwX6GuVL5KH+xVU+2v073sUqOc4S2EfVvtkAexWz8agBEdpLdGf4azTwCs2ZGfxaYFYRnr3A7tgdVxNHU07Uo63E1lHCFmOJn5SklN/Gh737fPeGvAuR9BaEY7lRUWRploMncxjmKLezfPvifSYp0J+7zdeSfgXlg/Zjii3VjGfiXtgZCgwCzeaGiPoBzxqGbjZDxzDSwiyvRs6gBfy2Znx3+D22G91AVk6KnSl7h8kyMH49kK3yw7ol6ZS0Vi11fx6aRk0FpAoRD1oRyOSpbcyyNxlO2LID4NumNALkoHSCbUHpev1jvxtu3KZ4QUitVuFEIhCJk+qGE4kiBEo/I69KZwn0gcWaybfh+ebxLtN85NubXP2XEf58WmhAXifszD2+5kWjieEgBZqyP X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2026 02:46:23.1468 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ace0a23-37dc-42b2-4a62-08dea1abac25 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D7.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6702 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260423_194630_281700_62C012D0 X-CRM114-Status: GOOD ( 13.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 24, 2026 at 10:38:09AM +0800, Baolu Lu wrote: > On 4/17/26 07:28, Nicolin Chen wrote: > > @@ -4083,6 +4093,18 @@ void pci_dev_reset_iommu_done(struct pci_dev *pdev) > > if (WARN_ON(!group->blocking_domain)) > > return; > > + /* > > + * A reset failure implies that the device might be unreliable. E.g. its > > + * device cache might retain stale entries, which potentially results in > > + * memory corruption. Thus, do not unblock the device until a successful > > + * reset. > > + */ > > + if (!reset_succeeds) { > > + pci_err(pdev, > > + "Reset failed. Keep it blocked to protect memory\n"); > > + return; > > + } > > Nit: pci_dev_reset_iommu_done() does nothing if reset_succeeds is false. > Would it be better to handle this in the caller instead? Something like: > > if (reset_succeeds) > pci_dev_reset_iommu_done(dev); > > ? It would also need a print and some duplicated comments. Actually, that would be my v2, which Kevin suggested this against: https://lore.kernel.org/all/BN9PR11MB5276706AE4E0BBE86F0F6E158C4EA@BN9PR11MB5276.namprd11.prod.outlook.com/ Though I don't have a strong personal reference here, I do see this version slightly cleaner than doing in the callers. Thanks Nicolin