From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: Caio Morais <caiomorais@usp.br>,
jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org,
michal.simek@amd.com, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] iio: fix header includes across multiple drivers
Date: Fri, 24 Apr 2026 12:45:36 +0300 [thread overview]
Message-ID: <aes7wGq2NYmtfMgs@ashevche-desk.local> (raw)
In-Reply-To: <a9307e04-3754-465e-a610-92c6e83cc3e6@baylibre.com>
On Thu, Apr 23, 2026 at 01:45:12PM -0500, David Lechner wrote:
> On 4/23/26 1:33 PM, Caio Morais wrote:
> >
> > Remove unnecessary includes and add missing ones as reported by the
> > include-what-you-use (IWYU) tool.
> >
> > Files changed:
> > - drivers/iio/adc/xilinx-xadc-events.c
> > - drivers/iio/buffer/industrialio-triggered-buffer.c
> > - drivers/iio/common/st_sensors/st_sensors_i2c.c
> > - drivers/iio/common/st_sensors/st_sensors_spi.c
>
> We'll want to split these up, one patch per file in case they every
> need to be backported as a dependency to a fix.
Per driver actually, as the last two belong to the same driver
(different busses though).
...
> This looks like sorting alphabetically, not actually adding or removing
> any headers as seen by the equal number of insertions and deletions.
>
> Usually we don't bother with sorting unless we are making other
> changes on top of that.
Right. At bare minimum we expect sorting + IWYU patch series.
...
> > #include <linux/device.h>
> > #include <linux/err.h>
> > #include <linux/i2c.h>
> > +#include <linux/iio/iio.h>
> > #include <linux/linkage.h>
> > #include <linux/module.h>
> > #include <linux/regmap.h>
> > -#include <linux/iio/iio.h>
>
> On this one, it would be more logical to move the iio header
> down one line to group it with the one below.
Hmm... Personally I consider them different group, I would rather see
linux/*
...blank line...
linux/iio/*
...blank line...
linux/_whatever_driver_specific_
> > #include <linux/iio/common/st_sensors_i2c.h>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-04-24 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 18:33 [PATCH] iio: fix header includes across multiple drivers Caio Morais
2026-04-23 18:45 ` David Lechner
2026-04-24 9:45 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aes7wGq2NYmtfMgs@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=caiomorais@usp.br \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox