From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 075E7FED3F2 for ; Fri, 24 Apr 2026 18:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mehcwLQk7yFuKfbeMZ+FkkoLLFfwD/gT9UIwnqKtjjc=; b=qEHOaVyebHVgrhDlHxbqx06y73 GPFlBLbhniA2yNf3NunG2CRZ/ug6xiRKoMscJCmnHaPb6Qgf/ay9yCfKcgWhuczh0UXiaeLhy2XJx au8Tord1VW/sbrzKf9jvRBS2AV0ECki80b/IN+gfyuKh2tYqG/3czviw1iyCkkbYunwwYPazSpc3I SR+Xq14GfTSBVucr1S04t421cUBwCUUnDMenO0UmBsKyZucnOeEyEkKFNAEKO6B9EkDWwGb0BrP+O Qpazz8KAECv37Op7PSlVlSv8lvusaIjtZOqwX9SqmKVNEGDcTB2BIFXAIvnos1rnnUmWCqz0hvkjw eJb9a4Kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGLVy-0000000Dezf-1RDB; Fri, 24 Apr 2026 18:44:34 +0000 Received: from mail-southcentralusazon11013065.outbound.protection.outlook.com ([40.93.196.65] helo=SA9PR02CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGLVv-0000000DezJ-2HCR for linux-arm-kernel@lists.infradead.org; Fri, 24 Apr 2026 18:44:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GRTo08v6siKVYxCxld+TUHOc5wTNYpZdaVEiOprLKGeRLzhL6xkxLBaidsuj8+zOO5EEwsnlOEPSRYZoWORQM1eDVhXWSuVVLrZy+xW+MD16qRlAs1OZlpH2KKvJ9uhiWww8g9/BEz1tyarA8ELNDdXKIGzhHBwBzJIjYxhXnNdbw+3BCzNpL8PbGrZOR5Al1w+JyWBMP+tBzuYOOt8dr6Tdmoog88Rpai90HZwco95Pg5mlcagz+OcDNhWTscnczHmqZXkYVVKvJkw0VWt662gHwRM5s5aUFh+kJSCgo05INF/skABT9mm1MMUasJ/MCATV4885w8vbYCmLctUJnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mehcwLQk7yFuKfbeMZ+FkkoLLFfwD/gT9UIwnqKtjjc=; b=bFv3zV720iwBve+ngxNa6VmzSAXOVEjceYsfPH0a0wx01J2oCU/W0PeWftlvsWsoy7crOYMg2QW5ct0i0FFNgxLNXL0AvXKkPLagJAuLowEx0+8zlKLezlP6mJQKK1jcGAd4XBsT2nCjnZSnzUitfx3WuNFfDVqGxTkQ23QmEl6yCmi0TgsRP10iWW1MxhVdwGAcyYg2Os8u590DSVnlLuMbjFU1pbSIjCOBZ6zcDKPZsCggHYUQNIXOzMSoAC2+mA4NmczgeI2RjA03shtpuqT2mmbYmSQ8fAGpgEhYjEqcAVlEVvE8YCmXFHmXhn99WnNYYVnu4/azJc4VeIpl1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mehcwLQk7yFuKfbeMZ+FkkoLLFfwD/gT9UIwnqKtjjc=; b=Z3QJtJ8RuVfQPqGcju4KFydl6hKXIxPYZzfJypmbcCCic+okM+4kGCs8mAk0DRorhj34uDJZM5vCXwTosdDqmkYzGpNOaHoDikVy3wcBa9qjntUl4Sg7Imuegu+vIxe6emmRb6lEXkBgPsc78s89kJhMFWpTfCezhbCVcsubIcCiK/miIjiICCqg2F4jJAhVxTySxQ6p6inx5HDTZISEuE6qVhEhR6m0fYsbjcCAQtnbo5vDJvhNYDA9KXnm1iEzUBFK7BnMqp9DevCp9qAOU0F1KxTDp2odgC7YGoEY/BUVpMuW2l9Ubn8ljGiCcSmckEZ7mzsXaTBOlIrXH4AMmw== Received: from SJ0PR03CA0120.namprd03.prod.outlook.com (2603:10b6:a03:333::35) by MN0PR12MB6341.namprd12.prod.outlook.com (2603:10b6:208:3c2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.22; Fri, 24 Apr 2026 18:44:22 +0000 Received: from SJ1PEPF00002327.namprd03.prod.outlook.com (2603:10b6:a03:333:cafe::3c) by SJ0PR03CA0120.outlook.office365.com (2603:10b6:a03:333::35) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.22 via Frontend Transport; Fri, 24 Apr 2026 18:44:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ1PEPF00002327.mail.protection.outlook.com (10.167.242.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Fri, 24 Apr 2026 18:44:21 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Fri, 24 Apr 2026 11:44:15 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Fri, 24 Apr 2026 11:44:15 -0700 Received: from Asurada-Nvidia (10.127.8.12) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Fri, 24 Apr 2026 11:44:13 -0700 Date: Fri, 24 Apr 2026 11:44:12 -0700 From: Nicolin Chen To: Jason Gunthorpe CC: , , , , , , , , , , , , Subject: Re: [PATCH rc v2 2/5] iommu/arm-smmu-v3: Implement is_attach_deferred() for kdump Message-ID: References: <7637d66c0f6c1fb16da4b5c9c4cec71752cf4d23.1776286352.git.nicolinc@nvidia.com> <20260424165927.GD3444440@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20260424165927.GD3444440@nvidia.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002327:EE_|MN0PR12MB6341:EE_ X-MS-Office365-Filtering-Correlation-Id: 7390847b-e69a-4ac0-5f99-08dea2318018 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|82310400026|7416014|376014|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: p9zTcBseHjARo5PBghAQ+ZEr520p3OsBtNKYtXMSgYCwgzW/uM2tOmbwnnEFjgPhTHUjKLFPL4to4c7rRxHvl+vy6p4/jCgEhGJsjRw4t2xE4vUFzYDS/4VLXd8bsAvIeFZrqS1q5VJSGwulo37h6/nc56y/NZiccBFh4Ieuajdo75jxal/FFYeduP2CPAWXu0RTbMKqj07Pm2zsTzwp9VIbUuL3ltlcAOcr6ULa90AG/8+iNZbKk5epq6E889kkAChIAmto0nXWbctXKNDcUGM1Hd6qSPZBxUZU9RxqrWzTQuWMUISCSeWtUd+xEJaT/M9HA1W9cE0Gq7Y0NhBBfgRBoLpmXqA42/smtVdAh3PWaloCyFS+jhgDQtOkMum1XCwbBM2lUFuF4GrZNPvEiZck+hrxG+PpmrD8JMcIhKIqPpcco8S8Oqyl4PW0KBlEW08REGKxR5hfTH7oeBZHxePp2z3vQcwOlAMnpkli05bCZloBT9Ho609zj9iSF2tR+0lGpjeZsnXngGOJuIP8AXFvZ05NNBH6gAp4v95EgGdX9UfdtaQwYhQtPmzkpKCcrJm6DhelvpG3Mqhpt5U/ybg2tNyHW5SFVDzN9gtOACtWHNmI1bhcHN84uT1yOU6PN7Yp37k8TgvSlMR4O6yBihPtW1mXnBQ/YAwPL4OzpKwbd/xj4lPWKi3TIg1XPUyxamUrXCWUfyg72gMLxOuegKT2LlNEMG7/EIosdXVUzrBtt+Jdlv+Cx9lzooeHEsPIts88Kz2MGfAVUzPoaLGJiA== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(82310400026)(7416014)(376014)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: yJ22TiL4Bjs4SSM86G7upw5YLIL/zdDj11QhZG3hIc/OwZ+mu9ySc9XVXFirLn6yDLNMIjLkKod3jVtMMujsI4XaGPGbntxTKW+osx4uBDWte39+HqE+ydxCkPO2PUKEeIrQ8FfI7r26vQ9kPE5R4izYmScxmBvDr0IANddm8BcXzOMhE7y0jS08wlc9vyZH6VaAFlVS+NOUY7Q3FfMY8EjFz784GsbknYGNGBs7uQa1/P8xTB14oy9Hl82yReJAliovoPfwrfEGjthGjSb0TXknsr8kOr0vjVGhW5lDvB5+3xiuhU+zC/ez4Vv0dbiR3B/acC+MaMhQjs+koQdxn8lckL0Gt2P98Bf8Uy2sjaDFj7GnjC/W2AQ5g9fnWTTiOf4kCHvhZitRN2cqI6x3oTpQpQHkqYISHyKQ9k8AGIfi6WTjSmg9BubV6d4tGy7B X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2026 18:44:21.9234 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7390847b-e69a-4ac0-5f99-08dea2318018 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002327.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6341 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260424_114431_588237_C7FADFFD X-CRM114-Status: GOOD ( 15.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 24, 2026 at 01:59:27PM -0300, Jason Gunthorpe wrote: > On Wed, Apr 15, 2026 at 02:17:37PM -0700, Nicolin Chen wrote: > > +static bool arm_smmu_is_attach_deferred(struct device *dev) > > +{ > > + struct arm_smmu_master *master = dev_iommu_priv_get(dev); > > + struct arm_smmu_device *smmu = master->smmu; > > + int i; > > + > > + if (!(smmu->options & ARM_SMMU_OPT_KDUMP)) > > + return false; > > + > > + for (i = 0; i < master->num_streams; i++) { > > + u32 sid = master->streams[i].id; > > + struct arm_smmu_ste *step; > > + > > + /* Guard against unpopulated L2 entries in the adopted table */ > > + if ((smmu->features & ARM_SMMU_FEAT_2_LVL_STRTAB) && > > + !smmu->strtab_cfg.l2.l2ptrs[arm_smmu_strtab_l1_idx(sid)]) > > + continue; > > This can probably just call arm_smmu_init_sid_strtab() > > I think it is OK to allocate another level 2 here and it also has > protections for SID out of range.. Actually, sashiko pointed out that this guard is a dead code. arm_smmu_init_sid_strtab() is called in arm_smmu_insert_master(). Thanks Nicolin