public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Leo Yan <leo.yan@arm.com>, Will Deacon <will@kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kselftest/arm64: Fix build failure with GCC-15
Date: Fri, 24 Apr 2026 17:44:16 +0100	[thread overview]
Message-ID: <aeud4Hqxq4PNitMc@arm.com> (raw)
In-Reply-To: <63409143-f4eb-48c3-89de-1aef4fb57381@sirena.org.uk>

On Fri, Apr 24, 2026 at 05:07:42PM +0100, Mark Brown wrote:
> On Fri, Apr 24, 2026 at 04:51:24PM +0100, Catalin Marinas wrote:
> > On Wed, Apr 22, 2026 at 06:42:54PM +0100, Leo Yan wrote:
> 
> > > Building on Debian sid with GCC 15 fails:
> 
> > I think a better fix is to always define struct user_gcs and only
> > conditionally define NT_ARM_GCS (IOW, move the #endif higher).
> 
> I've not actually double checked that everything is wired up properly
> but I believe these days this should actually pick up asm/ptrace.h from
> the headers_install target so a current kernel copy.  We ought to be
> able to remove the local definition of struct user_gcs I think, there's
> still some weirdness with the NT_ definitions I can't remember but the
> struct should be fine.

OK, so it does look like it picks the kernel uapi/asm/ptrace.h. It
builds fine on Debian stable (no GCS anywhere) with including
asm/ptrace.h and removing struct user_gcs.

But I think we should include asm/ptrace.h in libc-gcs.h and not the
gcs-util.h header (for NT_ARM_GCS it's fine to keep in gcs-util.h).

-- 
Catalin


  reply	other threads:[~2026-04-24 16:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 17:42 [PATCH v2] kselftest/arm64: Fix build failure with GCC-15 Leo Yan
2026-04-22 17:50 ` Mark Brown
2026-04-24 15:51 ` Catalin Marinas
2026-04-24 16:07   ` Mark Brown
2026-04-24 16:44     ` Catalin Marinas [this message]
2026-04-24 17:09       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeud4Hqxq4PNitMc@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=broonie@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=thiago.bauermann@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox