From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4E69606A31A for ; Fri, 23 Oct 2026 15:26:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=y++cFPNZ; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=rsAID/p+ DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=4a2HGeqSU90/oPjDCBfIOMhTpn84AQ4hBfmcEVcMu7Y=; b=y++cFPNZLRvOUF W5XlCWFpZrK34JUtQo9f/S6nZkqnF1Xo/RNfNPRA1KDD87KXqamLU993ZUamYDZesEuUUWLFcb50V rBfgxG2JiJ8QEqwqhI+If5hwkuprdPDQdPFBD0iuDSEFcFLRTzTK9DosFElf8uFQ5ZPzo1oRNrIF1 uO8X+nWSKPwHdvtGICJMXo37M9ohfPhXUq2/Eo3gGidIsKVW/HLUgDNcRAxPKL0cFgqtHPEPXdRDo sRLyLehMNck5RI1ks6eCWB9VAVE/Lbqo71E3MxxtIwuAHgpqEuQeS/2R1wBE5ji5KsHIKu6NQdgNa ArqLJ+xZPzD3KbImB+sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xKH9i-0000000GbRu-2us4; Fri, 23 Oct 2026 15:26:06 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xKH9g-0000000GbRA-1HsR for linux-arm-kernel@lists.infradead.org; Fri, 23 Oct 2026 15:26:05 +0000 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-49d05d51553so7303785e9.2 for ; Fri, 23 Oct 2026 08:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792769161; x=1793373961; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4a2HGeqSU90/oPjDCBfIOMhTpn84AQ4hBfmcEVcMu7Y=; b=rsAID/p+qD/54FsTmbrUnVN1ll8qOmNngBacLxjCaW0bHlKPW9iwB8qzp68SJxi6e6 Yekujotx4cgzlKgiE97Rvq5OcLCRiElcaLIInaQAniicnqBa9xkCtf7fuvLAMb/apPkY O1uA6G2UuzzqwHghSLwx97bFA35n7YEycZs0cJ3J4tRURRJr3eSkSQY6IElUOXAxEjhJ 0NpU1EQ0tNxTG3QsJlxFIcAx/KNzWJ9SqFDB4uPXws/Mqh8/Pd+uOQ7aN8RAVClBH0BC qvYA2UafIt+2rbkqm+4k60z7yF7oySYGxdBAiEllDb5RN+kfA3bEiju3MJv1fvtpYV3t /JaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792769161; x=1793373961; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4a2HGeqSU90/oPjDCBfIOMhTpn84AQ4hBfmcEVcMu7Y=; b=OJa81PAzxHLj1z8u8UnNcPasPRg5Y+0prUqCsGUIURZqEiIbakoJ2L7dfN7EGj8zaF sClqKRsXoBKhYMWAAXmb8YDl7HfTdRLa1bqOqD6HTT1AEo6e2iqq3zkthK/9sC+toLzj f61O8yu2GMS9fM0RvGYO800S3mbwsYEsPmZGPbzVl7d0Gc5WuEk4vXxMsdeIqYWvfqB/ d3T2Xqvk8ZlLgiKrCFD7uQ4unzxlIoImLo4JOfIEL39b2JEbbwqXU6xZhYGtRi1Ynqhw mA9kYur4SUNuyBb/8A5QRLpAeS70rOmCyA5JkUq5PYQAvLtdfR7t4xwDmnZ0LvG6Lphp j5RQ== X-Forwarded-Encrypted: i=1; AKwUvBwQcWMAbCmOvcE9beddH5h7d0bHnBskwk+5g7fpyJs2Yx+yxuYqCH1t75F6w01hCN9KWUidh8vJB1YxgY0EEfo+@lists.infradead.org X-Gm-Message-State: AFq9FYJIasj0nq19OfwMnZHql7U/hw23fwyE/vWYfOM/BWm2dgHRYf1t Kh62qi7ClBfvXVBvrAcER0VnCopRgfeJLuD98dUR2jMnlRYq+Xwmi9U= X-Gm-Gg: AYBFou0ZmBpps1HVxzaLAKoOQqSMzI39KD6b3k6lvzqxCO8k0LB/DFovaugn0wpu59/ /PbvMLd3TDHdCTfuPYOJTiDjNemJx7PpEX1agMJjMRfDUODzxj3vPpQ0yMjj0jS0Jn2M/7kekUF ExZzKa8Mj8xHk7wRtoAhLRf4s+7l/cI+Nuux4w7CY/Pov8nG7dLDr+f0CWRsxfMniqKZZ1UlJyO Ad641/Er9jPr1QJQZqCjTQnGK7Qjb4BqAL1qcjBnTbp0/eYdSce+/nTUJh1PP5hztELxI1snIC6 WemnBl980oBpq6E784niZKuvtoecq87zaYWhdLE3ePEalodbtg9NIrqrjSPRInZ3Aj5wX0cWGUN c5WDrN8r2s09ERMzn47LqQEFwvxmdYP1Cbn2jtiKm3DgvuL3VPMWCjB4K7GWGYmSEWpNrjDEtal ffvsT1zzan03gntZV/qk7aZ8kwSSJVnQm39GkemIS7Cn4aTi+1mIcVzEvAnfPuAPmw+9jRwTLl7 vuVtcuJRYEQO7yyeMv5dFS6JYDHKYuHh0V2uw2S4FlssiMc38ChR12dCVK0BWy3zSpFkpDXHx7n iDb3Gk7pGSSsCAYUPQ2mMBjBv5V4TIGiHJosvdbjQElEiYyD7FjN9DXdFg== X-Received: by 2002:a05:600c:19ca:b0:4a2:397:73f6 with SMTP id 5b1f17b1804b1-4a211c8fa81mr43106325e9.8.1792769161277; Fri, 23 Oct 2026 08:26:01 -0700 (PDT) Received: from ?IPV6:2001:b07:2ec:601d:4b26:1672:75c7:805a? ([2001:b07:2ec:601d:4b26:1672:75c7:805a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a29cda9686sm11718245e9.6.2026.10.23.08.25.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Oct 2026 08:26:00 -0700 (PDT) Message-ID: Date: Fri, 23 Oct 2026 17:25:58 +0200 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 03/13] drm/msm: look for lpac from dts To: Akhil P Oommen , Dmitry Baryshkov , Konrad Dybcio , Bjorn Andersson Cc: Rob Clark , Will Deacon , Robin Murphy , Joerg Roedel , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org References: <20260705-descriptive-name-lpac-upstream-v1-0-01d50c3e0c99@gmail.com> <20260705-descriptive-name-lpac-upstream-v1-3-01d50c3e0c99@gmail.com> <54cb37bb-aaa5-4c5d-a563-acca4822dd35@oss.qualcomm.com> <1f6db59c-b7a9-41a1-8022-6713365fa09e@gmail.com> Content-Language: en-US From: Anna Maniscalco In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261023_082604_398941_DC349DB3 X-CRM114-Status: GOOD ( 23.61 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 10/22/26 11:46 PM, Akhil P Oommen wrote: > > On 10/22/2026 6:24 PM, Anna Maniscalco wrote: >> On 7/9/26 9:39 PM, Dmitry Baryshkov wrote: >>> On Thu, Jul 09, 2026 at 05:54:23PM +0300, Dmitry Baryshkov wrote: >>>> On Thu, Jul 09, 2026 at 07:12:39PM +0530, Akhil P Oommen wrote: >>>>> On 7/7/2026 10:09 PM, Dmitry Baryshkov wrote: >>>>>> On Tue, Jul 07, 2026 at 05:02:43PM +0200, Anna Maniscalco wrote: >>>>>>> On 7/6/26 5:04 PM, Dmitry Baryshkov wrote: >>>>>>>> On Sun, Jul 05, 2026 at 09:13:37PM +0200, Anna Maniscalco wrote: >>>>>>>>> In order to associate the SID used by LPAC to it's own domain and >>>>>>>>> context bank we need a separate node on the DTS. >>>>>>>> Can we use iommu-map instead of adding a new device using the same >>>>>>>> addresses? You provide zero explanations, but it seems like you are >>>>>>>> trying to separate a part of the GPU into a separate device, but it's >>>>>>>> unnecessary. >>>>>>> What I was trying to say is that we need to map sid0 and sid1 to different >>>>>>> context banks. >>>>>>> >>>>>>>  From what I recall, so long as we use the same dt node, the iommu drivert >>>>>>> provides no way of doing this. >>>>>>> >>>>>>> What kgsl does is having a node for the iommu and then subnodes for gfx lpac >>>>>>> and secure. >>>>>>> >>>>>>> The address on the lpac device doesn't really matter. I have very limted >>>>>>> knowledge of DTSs but I think we could just leave it out altogether? >>>>>> I think, you were poined to the Glymur Iris patches. Another option is >>>>>> the QDA driver being submitted too. Both ot them use iommu-map to >>>>>> describe the same usecase - a set of SIDs which are used by the device >>>>>> but which should not be a part of the defaut set. With it in place you >>>>>> don't need to have separate qcom,lpac devices, no additional properties, >>>>>> etc. >>>>>> >>>>>> I'd recommend following the same approach. >>>>> iiuc, the conclusion in this recent thread is to use child nodes for a >>>>> similar case: >>>>> https://lore.kernel.org/all/20260618151745.GD231643@ziepe.ca/ >>>> Let me check internally. >>> After a brief discussion: it can be either, depending on what suites >>> better (and if you can persuade DMA / IOMMU maintainers to let one extra >>> bus or not). >>> >> One thing sashiko is pointing out is that new dt should work with hold kernel so, in general moving sid1 from there would break it since old kernels don't know how to handle them separately. >> > + Bjorn/Konrad > > Not sure how strict is the requirement for compatibility with older kernel version. An > option in your case could be just do an override in the board dts file of the > Steam Frame.' In other words that would mean not upstreaming the DTS change? Although we plan on keeping LPAC off by default upstream it feels like that would be quite a big barrier to enabling it for people that want it. Also yeah not sure where sashiko got that requirement, maybe it's not a real problem? > > -Akhil. > >> Not sure how to address this. >> >> Best regards, Best regards, -- Anna Maniscalco