From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 467D2C001DD for ; Thu, 13 Jul 2023 18:32:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+tvxbK2fT7Wx6mvAmfuClIEHKSJ9gwB02YD3ddAWIMc=; b=YCEcNzQqDa78jV dYkMsu8gd5wXGTqvtgope6GSg4tMKqIBFafHnmrwszhIeMNH5ZepWl95vSuXb2JXLWggnfocE6ixk 92ULWXU92kbnmEKJLvhbmsNPH7kGs+PYucVcVnjye2LxxQFAp09+hogKoNnbqG7vnNTvW7cVBNzqy d7gGor1IR+9uMmeMlWG+EnYkdmZfyaMMUyphDf8LTcdF8jDo5Jz8LSetDNzkgreUx6e/MtT7LpGmp Nz4nOyqCA36tzs3N4uBip1yrz0LxFhW8MeUmev2wq+R6vwyvVW6EItw7IWNzsDs98KlTsIdvP78Ot lHCnaqcfu9yH7IyNtu1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qK16b-0048as-3B; Thu, 13 Jul 2023 18:31:57 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qK16Y-0048a1-1B for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2023 18:31:56 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 36DIVnni085033; Thu, 13 Jul 2023 13:31:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1689273109; bh=cbufHtKmT1x2klHfrhnZCmt3cAyIK/2Lga1xIZFOMgM=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=VlIJo0iX028Ucxb1LYXBud0VvJeH8HDKDq81QFgBdoEa9iit8ODBU4YJXyyAcB5dW IEje4Jlu1mcn+rq0rCUpJAZu0W1h6ketxWtXdn3KPcneKqtoymj5wFir5qQ0o0tJF+ p2XHZBZ3fUQPqoj+J5jRB6dGE9EeO5GD5NgFp94E= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 36DIVnTP012497 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 13 Jul 2023 13:31:49 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 13 Jul 2023 13:31:49 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 13 Jul 2023 13:31:49 -0500 Received: from [10.250.32.50] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 36DIVmA1019630; Thu, 13 Jul 2023 13:31:48 -0500 Message-ID: Date: Thu, 13 Jul 2023 13:31:48 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 3/5] arm64: dts: ti: k3-j784s4: Add WIZ and SERDES PHY nodes Content-Language: en-US To: Nishanth Menon , Jayesh Choudhary CC: , , , , , , , References: <20230710101705.154119-1-j-choudhary@ti.com> <20230710101705.154119-4-j-choudhary@ti.com> <20230712141828.lnpo4mhd5dv34rlz@census> <18310450-05f3-172c-e4bc-fda114f333a4@ti.com> <20230713182107.ashuygyg4x4j77s5@backboard> From: Andrew Davis In-Reply-To: <20230713182107.ashuygyg4x4j77s5@backboard> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_113154_506330_42C1E07C X-CRM114-Status: GOOD ( 15.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/13/23 1:21 PM, Nishanth Menon wrote: > On 21:01-20230713, Jayesh Choudhary wrote: >> >> >> On 12/07/23 19:48, Nishanth Menon wrote: >>> On 15:47-20230710, Jayesh Choudhary wrote: >>>> From: Siddharth Vadapalli >>>> >>>> J784S4 SoC has 4 Serdes instances along with their respective WIZ >>>> instances. Add device-tree nodes for them and disable them by default. >>>> >>>> Signed-off-by: Siddharth Vadapalli >>>> [j-choudhary@ti.com: fix serdes_wiz clock order] >>>> Signed-off-by: Jayesh Choudhary >>>> --- >>> NAK. This patch introduces the following dtbs_check warning. >>> arch/arm64/boot/dts/ti/k3-am69-sk.dtb: serdes-refclk: 'clock-frequency' is a required property >>> >> >> Sorry for this. This property was added in the final board file. >> I will fix it in the next revision. >> I will add '0' as clock-property in the main file similar to j721e[1] >> which will be overridden in the board file with required value to get >> rid of this warning. > > That would follow what renesas (r8a774a1.dtsi) and imx > (imx8dxl-ss-conn.dtsi) seem to be doing as well. Just make sure to add > documentation to the property to indicate expectation. Unless someone > has objections to this approach. > Would it work better to disable these nodes, only enabling them in the board files when a real clock-frequency can be provided? My initial reaction would be to move the whole external reference clock node to the board file since that is where it is provided, but seems that would cause more churn in serdes_wiz* nodes than we would want.. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel