From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 387CEC388F9 for ; Wed, 11 Nov 2020 13:08:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91B55206CA for ; Wed, 11 Nov 2020 13:08:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fBuAcZOg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pcrIMq3o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91B55206CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h7zvhfQHOpoc1PM9ANn8GpLgvTwvnix5kDIO9u85uq4=; b=fBuAcZOgpnbqNonnSshAo0Fpj Teh1QYiy3Sz/P1WwIrKfWxeZwlPzAakXufnnn/8JVdWKeEGN28QTx5Hh3aZYkR9J+6pS/yOUbVVUE 7WxwyqHis13Jhm5KYzAmTv+qQqPe+bceweNute8ryHnKn/6jRYxI8PVL9LOyTv8cKEtttwhvPjmCK aJbW6WzxI522QfIk0SzDmkTbAM1jZoyvFXOrO0n1+JA5FABDa9VF/WwCwlOCNBcY+JVuf+9UXz+j7 St2pGQi92juD1wwfm7mCBcaWa88vZZEJlHxcRvRpmi3TNfdkdd1kuNHczz3EDnCitRKdjr8+pb46K pPdgUqB7Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcppo-0001OX-He; Wed, 11 Nov 2020 13:06:48 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcppk-0001Mz-Oh for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2020 13:06:45 +0000 Received: by mail-lf1-x141.google.com with SMTP id s30so3072695lfc.4 for ; Wed, 11 Nov 2020 05:06:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=82RRu0ROzYm5taPzq2lMWZPSnstixBkqQF5X1RxYego=; b=pcrIMq3o0TmMtnIRNs9t+1HKUABav1CurgNuFaFYakVEf+z580IjUws9F2xhMiDwQX sxsTSh3pZU0M7/AiQG1xqFCqR69wm+t4RX2VQEc55FRRbB/KMtDKfGZtifUZmNq7dDYF SMhoBX05Doo+F0pTepPpTw4QN5RRuLB40oV1rXdeyVwuYbCavF+ICADPwQ7oO8Oh1puX 15Naxi4BuzqTFtLHwUTIn2g9Gc9XHrL04F4bGT+EVEGfcqCU5cokvPlZ1/yQvrMKn407 6D2p4OJYeEUJYIyGsHhhM8q2ADnz3tJaw1HEk8hJo7Fa617e4oItQrlEQ6Cp5PLCgaZL KD3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=82RRu0ROzYm5taPzq2lMWZPSnstixBkqQF5X1RxYego=; b=SkiLKMeRPfZJi18dTCrT4FekaGfkpbV6Q7TawW2y+E7YtZ8mbIDtg5n0VGgt+jjmA7 VzLlLcSzPTk4+pAYi4+QzbpLs6WPLGBDVb0xajCvq0pmYrsl79WXEK0qNlizObYeFzBw 2cSXHCAi6q/PhaHIYChcFr8+/E1PSNVzbPRdD4ml6trbG2bSDmbk6XrENQIO9Xxj//Q3 njZSF6LmJDIWcOOZCsAHmrMERADSp8kbDiXN7zl/kRTm9BnyrV5HaC31tCmG7XKDsg2z OuDHFBqbDdpjMXBYC7wzjTXY1G2SJeqABeN2R/9kdIZS05d+kol/P7pARpS798B/iWI1 /MxQ== X-Gm-Message-State: AOAM533Nkd4C+TCD9MCyYYiyCog4z2HApvk4z7JpvIsE2JvH01/Z8nPU xq+MEW+Fm30T3RmyOWJqqMA= X-Google-Smtp-Source: ABdhPJxFMbJp8eNEkvkR9Sko+OH5lAZGUOWg8rrjbjnIfFbmWVvz6JsvCLZtOvrf3TnsNFdFOeqsTw== X-Received: by 2002:ac2:51d9:: with SMTP id u25mr2937980lfm.52.1605100003102; Wed, 11 Nov 2020 05:06:43 -0800 (PST) Received: from elitebook.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.googlemail.com with ESMTPSA id b8sm230406ljo.68.2020.11.11.05.06.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2020 05:06:41 -0800 (PST) Subject: Re: [PATCH 04/10] ARM: dts: BCM5301X: Add a default compatible for switch node To: Florian Fainelli , netdev@vger.kernel.org References: <20201110033113.31090-1-f.fainelli@gmail.com> <20201110033113.31090-5-f.fainelli@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Message-ID: Date: Wed, 11 Nov 2020 14:06:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201110033113.31090-5-f.fainelli@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201111_080644_900956_2488AC56 X-CRM114-Status: GOOD ( 21.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Scott Branden , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Ray Jui , open list , "David S. Miller" , Rob Herring , "maintainer:BROADCOM IPROC ARM ARCHITECTURE" , Hauke Mehrtens , Jakub Kicinski , Kurt Kanzenbach , Vladimir Oltean , Vivien Didelot , "moderated list:BROADCOM IPROC ARM ARCHITECTURE" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10.11.2020 04:31, Florian Fainelli wrote: > Provide a default compatible string which is based on the 53010 SRAB > compatible, this allows us to have sane defaults and silences the > following warnings: > > arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: > ethernet-switch@18007000: compatible: 'oneOf' conditional failed, one > must be fixed: > ['brcm,bcm5301x-srab'] is too short > 'brcm,bcm5325' was expected > 'brcm,bcm53115' was expected > 'brcm,bcm53125' was expected > 'brcm,bcm53128' was expected > 'brcm,bcm5365' was expected > 'brcm,bcm5395' was expected > 'brcm,bcm5389' was expected > 'brcm,bcm5397' was expected > 'brcm,bcm5398' was expected > 'brcm,bcm11360-srab' was expected > 'brcm,bcm5301x-srab' is not one of ['brcm,bcm53010-srab', > 'brcm,bcm53011-srab', 'brcm,bcm53012-srab', 'brcm,bcm53018-srab', > 'brcm,bcm53019-srab'] > 'brcm,bcm5301x-srab' is not one of ['brcm,bcm11404-srab', > 'brcm,bcm11407-srab', 'brcm,bcm11409-srab', 'brcm,bcm58310-srab', > 'brcm,bcm58311-srab', 'brcm,bcm58313-srab'] > 'brcm,bcm5301x-srab' is not one of ['brcm,bcm58522-srab', > 'brcm,bcm58523-srab', 'brcm,bcm58525-srab', 'brcm,bcm58622-srab', > 'brcm,bcm58623-srab', 'brcm,bcm58625-srab', 'brcm,bcm88312-srab'] > 'brcm,bcm5301x-srab' is not one of ['brcm,bcm3384-switch', > 'brcm,bcm6328-switch', 'brcm,bcm6368-switch'] > From schema: > Documentation/devicetree/bindings/net/dsa/b53.yaml > > Signed-off-by: Florian Fainelli > --- > arch/arm/boot/dts/bcm5301x.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi > index ee23c0841699..807580dd89f5 100644 > --- a/arch/arm/boot/dts/bcm5301x.dtsi > +++ b/arch/arm/boot/dts/bcm5301x.dtsi > @@ -483,7 +483,7 @@ thermal: thermal@1800c2c0 { > }; > > srab: ethernet-switch@18007000 { > - compatible = "brcm,bcm5301x-srab"; > + compatible = "brcm,bcm53010-srab", "brcm,bcm5301x-srab"; I've never seen Northstar device with BCM53010, see below list. *** BCM47081 *** Buffalo WZR-600DHP2 [ 1.816948] b53_common: found switch: BCM53011, rev 2 Luxul XWR-1200 V1 [ 2.602445] b53_common: found switch: BCM53011, rev 5 TP-LINK Archer C5 V2 [ 0.606353] b53_common: found switch: BCM53011, rev 5 *** BCM4708 *** Buffalo WZR-1750DHP [ 1.961584] b53_common: found switch: BCM53011, rev 2 Netgear R6250 V1 [ 2.445594] b53_common: found switch: BCM53011, rev 2 SmartRG SR400ac [ 4.258116] b53_common: found switch: BCM53011, rev 5 *** BCM4709 *** TP-LINK Archer C9 V1 [ 0.640041] b53_common: found switch: BCM53012, rev 5 *** BCM47094 *** D-Link DIR-885L [ 1.373423] b53_common: found switch: BCM53012, rev 0 Luxul XWR-3150 V1 [ 5.893989] b53_common: found switch: BCM53012, rev 0 Luxul XAP-1610 V1 [ 0.761285] b53_common: found switch: BCM53012, rev 0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel