From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 376D7C6FD19 for ; Fri, 10 Mar 2023 09:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SD/hnaRwyrzfaa40Gsxi2tUZyzKd3Z7F8qHLasC3vHk=; b=Kp7pf21WVchRWK Dom+3orxCh9N7qEF99bpKUVbX52hdXqgctSG7Ox7Kjsy8scA5j/yhMa+7yORtSxXUGoI6/IK9J5wz LVU96uKXRlDnca8oOC3jNFjPICGuA7l6ATCJhrKmqcsqsMiX106RjxV3PUPTHP1Vu1TGhKQU1Wm2O UNVLyLzIUP+aRiXq7ICCbw88b7J54E7vQpIccpwS/NYa+E7t5+9rg6lvz3legC4Z8s/PcVrgDVj4T q122nUy9FI0fqNycW4OeEzDrQVJ61jUGwKazPC2FaFXNxv1Q1II3nxm3zKA3pNqUXXZsijftbbdd/ VmCcTRmfd7SGRMqY61rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1paZ4W-00DukT-4o; Fri, 10 Mar 2023 09:29:56 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1paZ4S-00Dui8-1G for linux-arm-kernel@lists.infradead.org; Fri, 10 Mar 2023 09:29:53 +0000 Received: by mail-ed1-x533.google.com with SMTP id g3so17999091eda.1 for ; Fri, 10 Mar 2023 01:29:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678440590; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Wsu4G0p4vEq69pMVCyBTh1I0kHccMhzIhqWLhW5ud4c=; b=Kx72YYwDQDiIAC4wPIWGMjJT8AEzo2ydzXIQJrIaRm6yFcBB/cpxbcETZALCm77ftm 1l/HBA5oGVYkBrJzyGJW7imKGng5FP4UTAMln7m74+LqskH25Aby4hbt5cjv6Ub6u/2z bmJrn4WTr1qIh5H0hK2DIFDvx/naAps863DLpXVA9xoeGgUJH8u5reHpv7wUlrQv1OMx 0fHPu+ZYhU/uInVYptlFHeSxG5t3VJit6DnGhuXIGU7i3qrovc75XWpeOJ4Gr23GYpXk qsw2NudAMhdVV3wawp5XmDA7zHNkESgzSZ6nKnV3WxrIdeJgt0nffL67ZxZFmYI+Ne8n TLyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678440590; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wsu4G0p4vEq69pMVCyBTh1I0kHccMhzIhqWLhW5ud4c=; b=X7Ani2/uIcbKakLSoWI1IygUJbMOlTmz327u8o68w4IosbbhN1P8MLYkLdMfz3hhSs S5qVVyJL/QWT6RquLLOq4XQDfQPi4j9VHF3zMV3qIalkbFO0P+RnpCmvkXuifvEypdK1 T0IdJi9ir8ZbvivmjjXjj6QobEbyV4tnndqdE8yzrkn2ogn+Pllfp5XtGeJSvTWJk098 oBduEw9C0c0jdKKaNu6oFoXST+YLCptQZ5oA4jNFrR9VcqigED14tdyipi/EoQiUxszK cTD02hYnF4kzGlVYIUEVKARbuMSkQXhwgjSzVSj8V7bfM8dk72i4S57Wva1kdXnAATx+ uFGA== X-Gm-Message-State: AO0yUKU6RKHBMEn1JjMTq0TO2PX3mvjJYq1xsvkCElaTc+yA2aFIdv2Q bFNB8ZSX/l7Wkz7krqRdsgd5XQ== X-Google-Smtp-Source: AK7set+oCnVYTX8cnXy7SOVYOpWEmkjZuRXYtFCaMOuDrVNbOSiL1LDDgbBP+EZlM+JqUHrwQ71HYQ== X-Received: by 2002:a17:907:a808:b0:8aa:c35b:a34b with SMTP id vo8-20020a170907a80800b008aac35ba34bmr25831494ejc.20.1678440589760; Fri, 10 Mar 2023 01:29:49 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:2a59:841a:ebc:7974? ([2a02:810d:15c0:828:2a59:841a:ebc:7974]) by smtp.gmail.com with ESMTPSA id ci7-20020a170906c34700b008b17de96f00sm727793ejb.151.2023.03.10.01.29.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Mar 2023 01:29:49 -0800 (PST) Message-ID: Date: Fri, 10 Mar 2023 10:29:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j721e: Add overlay to enable CPSW9G ports in QSGMII mode Content-Language: en-US To: Siddharth Vadapalli , nm@ti.com, vigneshr@ti.com, kristo@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com References: <20230310092804.692303-1-s-vadapalli@ti.com> <20230310092804.692303-3-s-vadapalli@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20230310092804.692303-3-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230310_012952_124828_CA82FC42 X-CRM114-Status: GOOD ( 12.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/03/2023 10:28, Siddharth Vadapalli wrote: > The J7 Quad Port Add-On Ethernet Card for J721E Common-Proc-Board supports > QSGMII mode. Use the overlay to configure CPSW9G ports in QSGMII mode. > > Add support to reset the PHY from kernel by using gpio-hog and gpio-reset. > > Add aliases for CPSW9G ports to enable kernel to fetch MAC addresses > directly from U-Boot. > > +&exp2 { > + qsgmii-line-hog { > + gpio-hog; > + gpios = <16 GPIO_ACTIVE_HIGH>; > + output-low; > + line-name = "qsgmii-pwrdn-line"; > + }; > +}; > + > +&main_pmx0 { > + mdio_pins_default: mdio_pins_default { No underscores in node names. Didn't you already get such comments? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel