Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Horgan <ben.horgan@arm.com>
To: Andre Przywara <andre.przywara@arm.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Hanjun Guo <guohanjun@huawei.com>,
	Sudeep Holla <sudeep.holla@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Fenghua Yu <fenghuay@nvidia.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Srivathsa L Rao <srivathsa.rao@oss.qualcomm.com>,
	Ganapatrao Kulkarni <ganapatrao.kulkarni@oss.qualcomm.com>,
	Trilok Soni <tsoni@quicinc.com>,
	Srinivas Ramana <sramana@qti.qualcomm.com>,
	Niyas Sait <niyas.sait@arm.com>, Lee Trager <lee@trager.us>,
	Ritwick Sharma <ritwick.sharma@arm.com>,
	linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 00/10] arm_mpam: Add MPAM-Fb firmware support
Date: Thu, 30 Jul 2026 18:10:30 +0100	[thread overview]
Message-ID: <af820923-c423-4f19-99dd-7d8fdd2da864@arm.com> (raw)
In-Reply-To: <20260730152539.2712312-1-andre.przywara@arm.com>

Hi Andre,

On 7/30/26 16:25, Andre Przywara wrote:
[...]
> The first six patches rework all MSC access wrappers to propagate error
> information. Pure MMIO based MSC accesses would never fail, but the
> MPAM-Fb access can go wrong in multiple ways. The patches have been split
> up purely for reviewing reasons, if the number is a problem, we could as
> well squash them. Please note that until the very last patch of this series
> any MSC accesses would always only return 0, it's only the final enablement
> of MPAM-Fb that could possibly introduce errors. Hence all former patches
> can add error handling gradually, those code paths wouldn't be triggered
> before patch 10/10.

I had a go at injecting some errors and noticed that at least some aren't getting to user space.
When writing the schemata file any MPAM-Fb error is not propagated to the user. The
resctrl_arch_update_domains() continues to return 0 as there are some missing links in the chain
down to the writes, e.g. __write_config() always returns 0.

Thanks,

Ben



      parent reply	other threads:[~2026-07-30 17:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 15:25 [PATCH v6 00/10] arm_mpam: Add MPAM-Fb firmware support Andre Przywara
2026-07-30 15:25 ` [PATCH v6 01/10] arm_mpam: let low level MSC accessors return an error Andre Przywara
2026-07-30 15:25 ` [PATCH v6 02/10] arm_mpam: propagate MSC access errors for hw_probe functions Andre Przywara
2026-07-30 15:25 ` [PATCH v6 03/10] arm_mpam: propagate MSC access errors for MBWU counters Andre Przywara
2026-07-30 15:25 ` [PATCH v6 04/10] arm_mpam: propagate MSC access errors for msmon helpers Andre Przywara
2026-07-30 15:25 ` [PATCH v6 05/10] arm_mpam: propagate MSC access errors for __ris_msmon_read() Andre Przywara
2026-07-30 15:25 ` [PATCH v6 06/10] arm_mpam: propagate MSC access errors for state saving function Andre Przywara
2026-07-30 15:25 ` [PATCH v6 07/10] arm_mpam: prepare mon_sel locking for MPAM-Fb Andre Przywara
2026-07-30 18:37   ` Jonathan Cameron
2026-07-30 21:46   ` Lee Trager
2026-07-30 15:25 ` [PATCH v6 08/10] arm_mpam: add MPAM-Fb MSC firmware access support Andre Przywara
2026-07-30 19:05   ` Jonathan Cameron
2026-07-30 15:25 ` [PATCH v6 09/10] arm_mpam: change MPAM-Fb error IRQ to use a threaded IRQ handler Andre Przywara
2026-07-30 19:13   ` Jonathan Cameron
2026-07-30 15:25 ` [PATCH v6 10/10] arm_mpam: detect and enable MPAM-Fb PCC support Andre Przywara
2026-07-30 16:13   ` Ben Horgan
2026-07-30 19:17   ` Jonathan Cameron
2026-07-30 22:28   ` Lee Trager
2026-07-30 17:10 ` Ben Horgan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af820923-c423-4f19-99dd-7d8fdd2da864@arm.com \
    --to=ben.horgan@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=fenghuay@nvidia.com \
    --cc=ganapatrao.kulkarni@oss.qualcomm.com \
    --cc=guohanjun@huawei.com \
    --cc=james.morse@arm.com \
    --cc=jic23@kernel.org \
    --cc=lee@trager.us \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=niyas.sait@arm.com \
    --cc=rafael@kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=ritwick.sharma@arm.com \
    --cc=sramana@qti.qualcomm.com \
    --cc=srivathsa.rao@oss.qualcomm.com \
    --cc=sudeep.holla@kernel.org \
    --cc=tsoni@quicinc.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox