From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96ADBEFCD7C for ; Mon, 9 Mar 2026 10:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yX6mALvExdy6/wRMI3tNt7SgqpZLttlzmTg+ykyM6sU=; b=fur+KkhZm77U9fyV8mxxi7U+al tI6zUJ5sr0Rem8j4aSgdSKrpivUEYvrHToB5CcPEDSga78sXLRGolW9vwYhzt8lftSIAKO+m1WwbC OwfqvEXbqh3JJ4nT8eLxHHUZoPWM9u9bORVRXQkGCIqlc2pC0MJd8L+krdT7z6mTmapbhIGiBz82J 7ekWSp6c1HHDQWwQeld7mJRs5Ddx7qVbyyk9WSA54D5NyQm1RiNU7DpCI59NMEKss8EXEi00l/tW2 HB0oItr26mT9MzGYGf57M+Hc/HmOVmrquPQ7vjnFtQHC9Xn7FSIfbS7P3NaiiEuksEj2F1TlPiXTx uAv/0+sA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzXgc-000000074j9-1LCi; Mon, 09 Mar 2026 10:18:06 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzXga-000000074im-0G5K; Mon, 09 Mar 2026 10:18:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 2580260141; Mon, 9 Mar 2026 10:18:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D5CDC19423; Mon, 9 Mar 2026 10:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773051482; bh=SRnH1NwAp8w9VnUxeMdQQ22bjINRJvdOwnb+w2CyyoA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WbvrwkY69JG/s4o3qMNFez6zGnP0aaTiwhZ6euNW7VfFe957SK4mE3Hky70kXumBX 4WyaPMbTtArfbPihZMGhiqYjFUUp/49Y4vp/Et7+bkZTvscn+wBpkdzU3c8b4VmPRz PSRTkwBr/LrC6S+wpDsZ2jRP+4xm2SVSo8S+9iAhXafBTW6FilzgATwKSLZIIHsW8i i6Jwm7PmgHbXeHrULS7xLCb22+pxt7in3qIpCvD+CC3h7aqJxuetboQx9QmMwdvxU+ qFsiREvlGT5VIFdokr2t+wRM9g1GbzgQPen6AhuzpqrlcGFnbXc10NnfENbHMipjD8 y0NhDnxGbPh7g== Message-ID: Date: Mon, 9 Mar 2026 11:17:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/14] dt-bindings: pinctrl: realtek: Rename 'realtek,duty-cycle' to 'realtek,pulse-width-adjust' To: =?UTF-8?B?WXUtQ2h1biBMaW4gW+ael+elkOWQm10=?= Cc: "linusw@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "bartosz.golaszewski@oss.qualcomm.com" , "afaerber@suse.com" , =?UTF-8?B?SmFtZXMgVGFpIFvmiLTlv5fls7Bd?= , =?UTF-8?B?Q1lfSHVhbmdb6buD6Ymm5pmPXQ==?= , =?UTF-8?B?U3RhbmxleSBDaGFuZ1vmmIzogrLlvrdd?= , =?UTF-8?B?VFlfQ2hhbmdb5by15a2Q6YC4XQ==?= , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-realtek-soc@lists.infradead.org" References: <20260306075244.1170399-1-eleanor.lin@realtek.com> <20260306075244.1170399-10-eleanor.lin@realtek.com> <20260307-purring-kind-binturong-1fcb37@quoll> <1baf65a11c26482cae4f7b54df1521c5@realtek.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <1baf65a11c26482cae4f7b54df1521c5@realtek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/03/2026 10:18, Yu-Chun Lin [林祐君] wrote: >> On Fri, Mar 06, 2026 at 03:52:39PM +0800, Yu-Chun Lin wrote: >>> From: Tzuyi Chang >>> >>> Rename 'realtek,duty-cycle' to 'realtek,pulse-width-adjust'. >>> >>> The previous name was misleading because this hardware block is not a >>> PWM generator. It does not generate a signal with a specific frequency >>> and duty ratio. >>> >>> Instead, it provides a fixed nanosecond-level adjustment to the >>> rising/ falling edges of an existing signal. >>> >>> Signed-off-by: Tzuyi Chang >>> Co-developed-by: Yu-Chun Lin >>> Signed-off-by: Yu-Chun Lin >>> --- >>> .../bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml | 9 ++++++--- >>> .../bindings/pinctrl/realtek,rtd1319d-pinctrl.yaml | 9 ++++++--- >>> .../bindings/pinctrl/realtek,rtd1619b-pinctrl.yaml | 9 ++++++--- >>> 3 files changed, 18 insertions(+), 9 deletions(-) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.y >>> aml >>> b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.y >>> aml index 90bd49d87d2e..7b3888b2cea8 100644 >>> --- >>> a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.y >>> aml >>> +++ b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinct >>> +++ rl.yaml >>> @@ -133,10 +133,13 @@ patternProperties: >>> minimum: 0 >>> maximum: 7 >>> >>> - realtek,duty-cycle: >>> + realtek,pulse-width-adjust: >> >> No, that's ABI break without explanation. "misleading" is not the sufficient >> argument for breaking ABI. >> You are stuck with the ABI you added back in 2023. >> >> Best regards, >> Krzysztof > > The reason I renamed 'realtek,duty-cycle' to 'realtek,pulse-width-adjust' is that > during the v1 review, it was pointed out that the name caused confusion with > standard PWM bindings [1]. Since I need to modify the driver logic to address > this, I intended to update the binding simultaneously. Again, confusion is not reason to break ABI. > > Although the binding was added in 2023, there are currently no DTS files in the > mainline kernel that use the 1315e, 1319d, or 1619b pinctrl device nodes. Still ABI. > Therefore, changing this property name will not break any existing device support > in the mainline tree. Yeah, but will break all other users. Best regards, Krzysztof