From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED244C433F5 for ; Mon, 11 Oct 2021 18:15:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B22D360F11 for ; Mon, 11 Oct 2021 18:15:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B22D360F11 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lXy6bTTxBgioxal5mKF48vCrw3Q1xTawW2h4Pi4AjwU=; b=HVO4Vod2YQUIh4 w0bCbfbxiDx4XuWceTTEOJJu+Wrz3FxvdGovoRYcxtcr/Nc6p6jzAJgJyoL8f29bbZciHkOfGB1FR iVLVtE99FSh3ZvNqlRRfPjWfDHOjf/t69Xvh61qV+VwuWvKvgTek44oGz7Qf8DC3sqXhYxxSCib7r Fu3XT3ahT844w3ohWMlEjpH1kBqZjGlCqHjglCdJS8M5Xykyz4irEXhGDIClYM3hwWZyQUnE/5gSi r2LNKGNPLbpS4dNqY6HTl1UImgcMzFIB65a/c19Ac6eEUX8AbmoBbkwX1YNC/7IFSiZoklmpS8ql6 GB0JzC8tvVR6ycbDjFUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZznv-00AMHX-5B; Mon, 11 Oct 2021 18:13:39 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZznr-00AMGO-Jx for linux-arm-kernel@lists.infradead.org; Mon, 11 Oct 2021 18:13:36 +0000 Received: by mail-pf1-x42d.google.com with SMTP id m26so15539805pff.3 for ; Mon, 11 Oct 2021 11:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+xcssxkZTlEueyseAvWLLQTd3E+oYkVw7Pd99PMykLI=; b=co5exKtJ6qDmfzZFrPgxDp6dqyVCFIoEid4UcPCcvPulI+0EzTXG61Pdez9ro0k9TS rOqlkqHbLbs2QHttLz3uTb6FqVFfYGau8dOoF7d8CZwoS8IEYnHQZBODZEK+ayBNrDC4 mmf1m5zkVYjFjoFAZO+qn4E//mgIiKpgP9WawSEHMmuJH5366WhZeUNOgVEvJQ9WoKc1 w1I1YrdkMK4y17nyUPVbWsw/BUl5YZdgZWUWmAuHlTUTRqsnesaIrFsyYA+gGHJdB4+V e8K3rRj5c63yQgy8L641j+g+Fp1O3jICAzScshja8m+16hA+t3Fo7xzZfrbZB4ZV8VOd Wg9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+xcssxkZTlEueyseAvWLLQTd3E+oYkVw7Pd99PMykLI=; b=yx3wMbdYH72xlBcFp9/5KZb6zYg07c/Fva1F8tIDkLg6gsXV1ErRgaCv8uC/LlKhTV dMjXhOAqhhlh2YMNE56yOsEU+2MkcbOuIGYu24E4ygC17mRDrJxxdXfeIPHn3wYV1rr3 62KMMsT7IjYmE6iZHtF6aIAPzpPkdM+2EZX+sMq3EYxhj6dLMlFFFnVr/1hBZtfBvDmo CJ5hqDplbLMa6uOmu1NeNOHO6vYa9kGI5OItW1jBC7iEfmM3ug6MuoVqrIIu4HNsOCcv 2oeyZelqQwS5z5QBwRZ025HAIzOFk6WM6bMuyUsgnZcSZLvSBhwbP9biZ4SJ5BTbGkA3 fIJA== X-Gm-Message-State: AOAM533WsH+qb5/ThavWegD4Gbyfe8v2MWLoPU6utwg9iSbUKRDEg+5q oLn8gZSVv/frbsSbiJilk0k= X-Google-Smtp-Source: ABdhPJxLvHgE+mf4PpgZ/Eb4hUwxN9ixlNaScFlJnQ9Fn0zNCjBFQz8suRQ/dY0sjpiLMCC6Zs3adQ== X-Received: by 2002:a63:1717:: with SMTP id x23mr19276856pgl.182.1633976014242; Mon, 11 Oct 2021 11:13:34 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:9f95:848b:7cc8:d852:ad42]) by smtp.gmail.com with ESMTPSA id m7sm8780611pgn.32.2021.10.11.11.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 11:13:33 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com Cc: Naveen Naidu , linux-kernel-mentees@lists.linuxfoundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Toan Le , Lorenzo Pieralisi , Rob Herring , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER FOR APPLIEDMICRO XGENE) Subject: [PATCH 22/22] PCI: xgene: Use PCI_ERROR_RESPONSE to specify hardware error Date: Mon, 11 Oct 2021 23:43:19 +0530 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211011_111335_705494_B4BE5D85 X-CRM114-Status: GOOD ( 12.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Include PCI_ERROR_RESPONSE along with 0xffffffff in the comment to specify a hardware error. This makes finding where MMIO read error occurs easier. Signed-off-by: Naveen Naidu --- drivers/pci/controller/pci-xgene.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/pci-xgene.c b/drivers/pci/controller/pci-xgene.c index e64536047b65..4b10794e1ba1 100644 --- a/drivers/pci/controller/pci-xgene.c +++ b/drivers/pci/controller/pci-xgene.c @@ -176,10 +176,10 @@ static int xgene_pcie_config_read32(struct pci_bus *bus, unsigned int devfn, * Retry Status (CRS) logic: when CRS Software Visibility is * enabled and we read the Vendor and Device ID of a non-existent * device, the controller fabricates return data of 0xFFFF0001 - * ("device exists but is not ready") instead of 0xFFFFFFFF - * ("device does not exist"). This causes the PCI core to retry - * the read until it times out. Avoid this by not claiming to - * support CRS SV. + * ("device exists but is not ready") instead of + * 0xFFFFFFFF (PCI_ERROR_RESPONSE) ("device does not exist"). This causes + * the PCI core to retry the read until it times out. + * Avoid this by not claiming to support CRS SV. */ if (pci_is_root_bus(bus) && (port->version == XGENE_PCIE_IP_VER_1) && ((where & ~0x3) == XGENE_V1_PCI_EXP_CAP + PCI_EXP_RTCTL)) -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel