From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99999C3271E for ; Mon, 8 Jul 2024 10:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a37xqtAhqBn6RFQufMqGlI4wV85VoVHD0Umy9Ckc/Lc=; b=o2DW+F8VZE5sosnhh2NDhvP3LQ ijb3THrsKSRGZXahhMGDjZXQwD3X9h6vnmzGVNgzQ2mTXuGshzl/92W7kUIWu70ZZ74Fs62VVnKVy m7sfP+qz3X7/Y5DHU8IKF9zuedsA1J+tYfSyle9HAnr1jep/biSYIoWWskE76loWiO/0VFlKTSTP8 jDSrw0VWmtOJxCTVz5AvxpdahloKXLyZt+zBPNeYu3hoBW0XSwU7Fd8dBGzpKOdD0VrhEP1VqDREA uxg+586NoxDxNR9XH1zMGYcaTyZQZ4DP6PBeViWekQxGlexaolRogL8Yzrr/Wles2vW4FN5Sxx5xA VuNzzR2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQlrl-00000003UQG-1OKo; Mon, 08 Jul 2024 10:45:05 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQlrW-00000003UN1-3E4H for linux-arm-kernel@lists.infradead.org; Mon, 08 Jul 2024 10:44:52 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-367ab76d5e1so703629f8f.3 for ; Mon, 08 Jul 2024 03:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720435486; x=1721040286; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=a37xqtAhqBn6RFQufMqGlI4wV85VoVHD0Umy9Ckc/Lc=; b=t8x01ogppXEVOszFaCUkH3C4kxy2F5JdZYnJtrdLd0cIF4Bl+J9E2yzJVrCVzQMeSZ bu+eV7B8QhcK+q6nAkgn33qSwqQv8UQvylQUX65+p86XfgZqtQa3xzV27iasHgxT0ane 9xoVfTx3Z+wc9hEn9UXHjUkJ3+UPWez6ENdZeK70Dlx2hyQDIqFiEGMMw5wCyzhvEA7W gNBfMtnBm0DTlqR4ptpdcEWe2bDibuRUDon1v17RHFd5OLWWEfUesySM3npUssYrH13V Gn4HEzOMqUG4mRINbi/Lye8rEF5SsIIgz0Mhi3NdsS48g0hCcT83hZZl20wlbQ+hcd9k tthw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720435486; x=1721040286; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a37xqtAhqBn6RFQufMqGlI4wV85VoVHD0Umy9Ckc/Lc=; b=KFpcodhwQpbIaInw5RqUfh0Jf5X2XHacY/nttWCsrVydpgwamJ+XxXLn0YfY0usRFl 5+kPTBE73bo3ftEsn8XFufGVwe1BUWT0PdiiCbub8ymkHk4tSD9QX2mJryImOMfKsqos p9a0bCBfzqyS0JPlYztX04kYWNHBjtkKNpdkisa/CWo6QtRsSNd1L+d/s580HazTPDbI RwEp/4HS8ACZt+Bgf0q3J+tf4keydiyTS71oV6gePe2PGeXgUYyk1R+Ym/lkF+xwMp5c Z4bpsRtrpOLH0aTjejRrSlAevtJFAGxi1Yj2rQncuPsqwGBIUVSpABT13qDjsiDa8HiY SAsQ== X-Forwarded-Encrypted: i=1; AJvYcCW6ABTjw1/AJwPyGkL9IZ/6UqDXWroDNRCx62khSH8LVBw89imHIvPN0OTvyLA9bDhNWGyy/88rhZyeiDbByGjogGO9CceQw4ePju59g8jGXlHOsyM= X-Gm-Message-State: AOJu0YyQ14XgaTY/VyAkM2F9jD9OHVUmLXa473+VlYgvWOSl2gieZbz5 E7bkMOZE5YtjwaNEArfbU6h6Hteay1C6j3dRZb5NsXh1Lvh9Hm7nw/OH3y573Ls= X-Google-Smtp-Source: AGHT+IEX4+Ix+R9k1DiSQE1LFtm+JaPwNJfxzl5UgCb/G8Xy6bP/f5Oerfl19+46U34y0fv2YfKoww== X-Received: by 2002:a05:6000:4023:b0:367:8e53:7fe5 with SMTP id ffacd0b85a97d-3679dd353b8mr8685700f8f.40.1720435486564; Mon, 08 Jul 2024 03:44:46 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.137]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36798e435c3sm11479442f8f.72.2024.07.08.03.44.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jul 2024 03:44:46 -0700 (PDT) Message-ID: Date: Mon, 8 Jul 2024 12:44:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] Coresight: Add Coresight Control Unit driver To: JieGan Cc: Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Mike Leach , Rob Herring , Krzysztof Kozlowski , James Clark , Jinlong Mao , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Trilok Soni , Song Chai , linux-arm-msm@vger.kernel.org References: <20240705090049.1656986-1-quic_jiegan@quicinc.com> <20240705090049.1656986-4-quic_jiegan@quicinc.com> <9b502ba5-7042-424e-b0a2-5659e4064462@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240708_034451_043842_584A0180 X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/07/2024 05:16, JieGan wrote: > >> >>> + >>> + drvdata->base = devm_ioremap(dev, res->start, resource_size(res)); >> >> Use proper wrapper for this two. > Replaced by: > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > drvdata->base = devm_ioremap_resource(dev, res); Why? Use the wrapper. ... >>> + >>> +static struct platform_driver ccu_driver = { >>> + .probe = ccu_probe, >>> + .remove = ccu_remove, >>> + .driver = { >>> + .name = "coresight-ccu", >>> + .of_match_table = ccu_match, >>> + .suppress_bind_attrs = true, >> >> Why? > Sorry, I dont get the point here. You do not get the point why I am asking "why?"? Why do you need it? > We dont need automatic bind/unbind, so the suppress_bind_attrs sets to true. But I need it... > We need configure some settings before we register the device. Hm, is this expected for coresight devices? Best regards, Krzysztof