From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D78ACC64EC4 for ; Wed, 8 Mar 2023 11:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mr+BKDZPwNmIEBRU5VOfw/m+R/T66zTHNbZJMelHXNY=; b=udAK+Zu15T7ubJ gP83/PRXutk5u9+ZS0nhDDDi849ogdI8TOXsvHlDvS+xZjHE0lXixXuSelHGACAapGigTY52qi4dc w61nXiC1e4yyfsAwD9iIsRulH1WBHz+q2ddi+qZaGGEbUVXBePJLgRaZ8BAqffc+PtGdWHG2lKt13 ehl0L80SPudHyRgB+kolAEcqW/jbn1TNZiTXSpJ58pCi3L3QLEhixU1tvYx+ytxzC24RjExfqM4QW vU5Q40iCJTsLthOLa9LYvKFssIK4NKt2LJpzyuh5C+2dpXKHaF6TVfQCvP+X8c1fgFNksd0Ctfspo aZ57Qvjw4ZaqyJWTu3+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZs6S-004ddy-Di; Wed, 08 Mar 2023 11:37:04 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZs6P-004dci-J2 for linux-arm-kernel@lists.infradead.org; Wed, 08 Mar 2023 11:37:03 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 328Bav7r016709; Wed, 8 Mar 2023 05:36:57 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1678275417; bh=gw3v1EU0BElckaHwj1NxL18/TTUoPdYzshVSNuiDOtw=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=jwg2CsjJIBsrrOqkBaD7Ck18fdVAZLXQ7BKKXf8wGHccFLdD/+/adRtXYE72a5LuZ 4hQdF786KyVu82f1z5h1m5jYJvH9Ihx/d3vjzel9awbmRwluO+VsY911x44MTvUlbC 0XbCPSjs2MVMUrTb7HVcWHZH6SXg5emTkmTuWGRQ= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 328BavSP067935 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 8 Mar 2023 05:36:57 -0600 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Wed, 8 Mar 2023 05:36:57 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Wed, 8 Mar 2023 05:36:57 -0600 Received: from [10.24.69.114] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 328Baq4S121331; Wed, 8 Mar 2023 05:36:53 -0600 Message-ID: Date: Wed, 8 Mar 2023 17:06:52 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [EXTERNAL] Re: [PATCH v3 3/6] soc: ti: pruss: Add pruss_cfg_read()/update() API Content-Language: en-US To: Roger Quadros , MD Danish Anwar , "Andrew F. Davis" , Suman Anna , Vignesh Raghavendra , Mathieu Poirier , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon CC: , , , , , , References: <20230306110934.2736465-1-danishanwar@ti.com> <20230306110934.2736465-4-danishanwar@ti.com> <7076208d-7dca-6980-5399-498e55648740@kernel.org> From: Md Danish Anwar Organization: Texas Instruments In-Reply-To: <7076208d-7dca-6980-5399-498e55648740@kernel.org> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230308_033701_747954_74049580 X-CRM114-Status: GOOD ( 19.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Roger, On 08/03/23 13:57, Roger Quadros wrote: > Hi, > > On 06/03/2023 13:09, MD Danish Anwar wrote: >> From: Suman Anna >> >> Add two new generic API pruss_cfg_read() and pruss_cfg_update() to >> the PRUSS platform driver to allow other drivers to read and program >> respectively a register within the PRUSS CFG sub-module represented >> by a syscon driver. This interface provides a simple way for client > > Do you really need these 2 functions to be public? > I see that later patches (4-6) add APIs for doing specific things > and that should be sufficient than exposing entire CFG space via > pruss_cfg_read/update(). > > I think the intention here is to keep this APIs pruss_cfg_read() and pruss_cfg_update() public so that other drivers can read / modify PRUSS config when needed. The later patches (4-6) add APIs to do specific thing, but those APIs also eventually call pruss_cfg_read/update(). >> drivers without having them to include and parse the CFG syscon node >> within their respective device nodes. Various useful registers and >> macros for certain register bit-fields and their values have also >> been added. >> >> It is the responsibility of the client drivers to reconfigure or >> reset a particular register upon any failures. >> >> Signed-off-by: Suman Anna >> Co-developed-by: Grzegorz Jaszczyk >> Signed-off-by: Grzegorz Jaszczyk >> Signed-off-by: Puranjay Mohan >> --- >> drivers/soc/ti/pruss.c | 41 +++++++++++++ >> include/linux/remoteproc/pruss.h | 102 +++++++++++++++++++++++++++++++ >> 2 files changed, 143 insertions(+) >> >> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c >> index c8053c0d735f..537a3910ffd8 100644 >> --- a/drivers/soc/ti/pruss.c >> +++ b/drivers/soc/ti/pruss.c >> @@ -164,6 +164,47 @@ int pruss_release_mem_region(struct pruss *pruss, >> } >> EXPORT_SYMBOL_GPL(pruss_release_mem_region); > > cheers, > -roger -- Thanks and Regards, Danish. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel