From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 357E6C25B75 for ; Thu, 23 May 2024 15:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1rhxvCRT30XPCE7CeSgydgJdUvnspPzUDXioUtV5jDg=; b=o67Vyri4ccUyA0 RTbyILHSuIwap8N7EiAgNUsclS7KH7iUBOkFMMtFxd5Ut+8yH9n67p5k6JiH03LZ8OpKyPLyS2K7H evN3zFkY2kZhCS0MUmRac3ltQxA2gsAemIQ907tCFUd5PjL9wNoQdReST6XtuosqyKgZPZzFpToaa f0Cs3mIdvd0DsD9SdoNHk3JjcNcRvs5yVDto4TQebc2SMZGDbypkvY4Awj5gNX4EuvlJOwc/XSyBh 3Tn5P/hRoDIkXtTHZkOSqHQ9GtOcYBqsrIv9fxxexJTeDw9aUNmFhWQuIwB5siS4ByK1vHW00HdRt kdqenQU0YsSYX2hFyamA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sAAEV-00000006cxc-1n6M; Thu, 23 May 2024 15:19:55 +0000 Received: from out-188.mta0.migadu.com ([91.218.175.188]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sAAES-00000006cv4-1QL5 for linux-arm-kernel@lists.infradead.org; Thu, 23 May 2024 15:19:54 +0000 X-Envelope-To: helgaas@kernel.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716477587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VmITnvzd0IbZjn+ZkuoMDkt3gI/vCxtww1N54pkDA9I=; b=OpvT5SxIDvfkaJ43NWWVgmtXxXm9YUZ34/wYw58Zs01n4yoSD/UwTHQiDU9FGAaJkSQqP1 4S0uaJa2uC04OL73hIW4vvZK84wGboDHnlkNBp8J3Evaeb/KBnMPgfVH11gt3ntqBivv6T EeOGRQ0SD6N0Y4GKyv51WZ4uHS6ozHY= X-Envelope-To: g@bhelgaas X-Envelope-To: lpieralisi@kernel.org X-Envelope-To: kw@linux.com X-Envelope-To: robh@kernel.org X-Envelope-To: linux-pci@vger.kernel.org X-Envelope-To: michal.simek@amd.com X-Envelope-To: thippeswamy.havalige@amd.com X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: bhelgaas@google.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: conor+dt@kernel.org X-Envelope-To: krzysztof.kozlowski+dt@linaro.org X-Envelope-To: devicetree@vger.kernel.org Message-ID: Date: Thu, 23 May 2024 11:19:42 -0400 MIME-Version: 1.0 Subject: Re: [PATCH v3 1/7] dt-bindings: pci: xilinx-nwl: Add phys To: Bjorn Helgaas , g@bhelgaas Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , linux-pci@vger.kernel.org, Michal Simek , Thippeswamy Havalige , linux-arm-kernel@lists.infradead.org, Bjorn Helgaas , linux-kernel@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , devicetree@vger.kernel.org References: <20240522222838.GA101305@bhelgaas> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20240522222838.GA101305@bhelgaas> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240523_081952_756997_6C118FD1 X-CRM114-Status: GOOD ( 13.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/22/24 18:28, Bjorn Helgaas wrote: > On Mon, May 20, 2024 at 10:53:56AM -0400, Sean Anderson wrote: >> Add phys properties so Linux can power-on/configure the GTR >> transcievers. > > s/transcievers/transceivers/ I always forget the spelling is backwards on this one > Possibly s/phys/PHYs/ in subject, commit log, DT description to avoid > confusion with "phys" (short for generic "physical"). Or maybe even > just "PHY properties"? Well, this is the name for the property... > What does "GTR" mean? Possibly expand that? It's "xlnx,zynqmp-psgtr-v1.1". These are the available transceivers on the ZynqMP, which is the only SoC this device is present on. I had hoped this would be clear by calling them "GTR transcievers"... --Sean >> Signed-off-by: Sean Anderson >> --- >> >> Changes in v3: >> - Document phys property >> >> Changes in v2: >> - Remove phy-names >> - Add an example >> >> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> index 426f90a47f35..cc50795d170b 100644 >> --- a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> @@ -61,6 +61,11 @@ properties: >> interrupt-map: >> maxItems: 4 >> >> + phys: >> + minItems: 1 >> + maxItems: 4 >> + description: One phy per logical lane, in order >> + >> power-domains: >> maxItems: 1 >> >> @@ -110,6 +115,7 @@ examples: >> - | >> #include >> #include >> + #include >> #include >> soc { >> #address-cells = <2>; >> @@ -138,6 +144,7 @@ examples: >> <0x0 0x0 0x0 0x3 &pcie_intc 0x3>, >> <0x0 0x0 0x0 0x4 &pcie_intc 0x4>; >> msi-parent = <&nwl_pcie>; >> + phys = <&psgtr 0 PHY_TYPE_PCIE 0 0>; >> power-domains = <&zynqmp_firmware PD_PCIE>; >> iommus = <&smmu 0x4d0>; >> pcie_intc: legacy-interrupt-controller { >> -- >> 2.35.1.1320.gc452695387.dirty >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel