From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14246FF8855 for ; Tue, 5 May 2026 15:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8IE/CrCxj5AIf4hfnkjgG0AIJbFdqjG49akaTCAKyUI=; b=Mu7dQAU7PpbRxykoi2pspJQtfT W/rD2oTXZ7yQxxUFwkkV9ZCxIbwcmdd1x8Ghzneo2AI3Pid5v4SYn3Ap6toOySqkh1z9FwQdNK90N tI29HxnAEO6GluvWw9ZJa2YqoilkYlW5IRplz291PhiZu4uU0YRd7RL/r2H1la58IqBx3SmVaGys1 jXi24bSd7I1mT7decJhe9/oTXUIBMCWA+q3bTDEm/YaSnUjtu23cXQ8ho8c0Xs8jYD4VLUuccvkRQ krvG2ycb4SfvimVrhgMiITf1GktDZx8H1jCTgKiYUJ0Q/iUbX5uk82KxseclPhLo/RrZTmDJ6gH7N kzb4ASsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wKHsY-0000000Gght-0L7H; Tue, 05 May 2026 15:40:10 +0000 Received: from mail-northeuropeazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c200::5] helo=DUZPR83CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wKHsT-0000000GggE-3M2C; Tue, 05 May 2026 15:40:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Wam5s7lqYHD76PxqKlAQtGi4NhJhZYowsO8huoYK2w8pl2a75U2RjgaWtJBE4pQ4r/a7QqNZvLN/ij35WF//VNPBCTnwS+AZol4CcOrYwgwri+rUTkScSBjD5qAoldWohzCNKYbzQ8I5btqT2B5DxmxaJUMqcjtmuytJa9zMozmKEHQX6BehrooqEEv7BCyI/gi+GcVp+xAMm9qQoQ1ysjEr/PxAq+Bd+lt0bqOXLSY9amZHwvSpJbsIgtjJKO/d42Daq/ESRKzd9kopS5huV2tBfalQuqjljNkt73BBWRyKB3cXGlrMoRSPEoGiWAdHSaygTg4hbnsNsFeVuo0BjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8IE/CrCxj5AIf4hfnkjgG0AIJbFdqjG49akaTCAKyUI=; b=mluJC14B7TP31/5eL1qF0svAIv0A/hAJiLVCZr17lq3zqiwHB6yGJN+bbvzJt1ltOfGLnwjVtAYobWeCQDaiZUp2sYW57Ell8i0HgZs6Nqh/v8rDGJGGodPQB6fR/ySXxtNPjRc4W+8rTxY3xOHTsSfdD1JU1DtFldMv4pG6r9+1wSywm8THGXLs5vQc0QCae+AdmhCifIn9/qzUBYKAbPGI10ERhlM5PgzV1IYRUZ+CvzkHcMU5V7BlVEjg/Q/R/qXoG7z4MUEPLDP/u4TpwpxF71pdwmAinmfm27yrryNuRRNb8D0qjtkjPXKF6DQK0/p1HFHMFBK2Qa6irkibpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8IE/CrCxj5AIf4hfnkjgG0AIJbFdqjG49akaTCAKyUI=; b=oBpxsb5d0/Yloa/qRh+W4VYBKDAPKfBUTNAiiaiugWe21DPUP6+53fChbnHFP5ver1Q3YltKTCecsnTiRZERh+zQbZpFfJrsjcVyhpW599FGvfBMuPSlDbtxXT+M1AR0k1qK8nmP6OTspDe0DOabihB4R9PRy6wcrTztvYxvUmMDlrllqGnIsF8zlyTwkEtxfbPIusiECKcXQaaLtR/d6Hyuhq099zhks2P/AoJCw11x/z4mi5/DaOXwkr+f6vxqfxXjMaXyYJftbTqzIciJEWHU8/y4LJaIPr8J0ZlSZBh4r+czCx0G7EeXqVLLvh9irj2W5t8oWzEz9QMpOn54SA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PA4PR04MB9366.eurprd04.prod.outlook.com (2603:10a6:102:2a9::8) by AM0PR04MB7026.eurprd04.prod.outlook.com (2603:10a6:208:192::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.25; Tue, 5 May 2026 15:40:01 +0000 Received: from PA4PR04MB9366.eurprd04.prod.outlook.com ([fe80::75e4:8143:ddbc:6588]) by PA4PR04MB9366.eurprd04.prod.outlook.com ([fe80::75e4:8143:ddbc:6588%6]) with mapi id 15.20.9870.023; Tue, 5 May 2026 15:40:00 +0000 Date: Tue, 5 May 2026 11:39:52 -0400 From: Frank Li To: Hans Zhang <18255117159@163.com> Cc: broonie@kernel.org, sunny.luo@amlogic.com, xianwei.zhao@amlogic.com, neil.armstrong@linaro.org, khilman@baylibre.com, han.xu@nxp.com, haibo.chen@nxp.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, lhjeff911@gmail.com, hayashi.kunihiko@socionext.com, mhiramat@kernel.org, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH 05/10] spi: nxp-xspi: Use FIELD_MODIFY() Message-ID: References: <20260430155456.36998-1-18255117159@163.com> <20260430155456.36998-6-18255117159@163.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260430155456.36998-6-18255117159@163.com> X-ClientProxiedBy: SN7PR04CA0004.namprd04.prod.outlook.com (2603:10b6:806:f2::9) To PA4PR04MB9366.eurprd04.prod.outlook.com (2603:10a6:102:2a9::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR04MB9366:EE_|AM0PR04MB7026:EE_ X-MS-Office365-Filtering-Correlation-Id: 4789953b-0c6f-4b53-d264-08deaabc919b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|19092799006|7416014|52116014|376014|366016|38350700014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: 6zTvDhTXKR6DFj2e1/ZZ+YKDzKDPv2X56hSgQMQpkDnxPcUDNsyeFxJwdn7wKwF/PxSonefd7JPVt6Qk0rS+tUmXw866nAGLejysAnwKPvLs2vwMVhWMptJZ1zDv4F3kFUfouChPhohhvD0nRTR75zCcihE6d0YjaGM7xG6SV3VXoNqTYSg6+LABGM6hld7Nhumtf/AgR9NJeIJZWbodiCwv3Fj1/vjzY1VJ8hL7HnQZ4vICmiDegDtYG1z9RI6DFh9wa5TnKswOAcoKy8ejt4rfvYL8p8SHWVM0WcIV2ezGcnqFjQYVm3WmOfgPs6b4mELU+SoDjcK4OzIznd88jK3+TE6wHz+nMxUTPtTHyLIqun03q7Vfyud2SBnIMmXLytk+F01KIr2/BPLrbvCBCTFRt0BaA6Pg6ID+BaM2wm7UbfuvjZapTtQEvS8JHBVRdXW5Orjf7hmx8U85RHfm15hoVZx/R+oXqNT1y8glnZuDUmv7T1uqjplBFwqHJRcZ8Q3pdx4bkHr+7zXCGV17x6KWhqVD+HkLO0etByoh/MWwEeENpmxkV/WNrKLY2j43HJN1/VDd9TAPooju1uMHiVWgoS/c7tOiOwArqk9PNlcB2FvgWYzjczROiemwIMJgwdMeStpeRaZ1ZAG8t98B2Y5yftrDV84BCHx7N+B2MHjspYIcWGfbkPmi0IpKeIwEtXP9ihUFqjPzEGA/AH6p6LnOyNZjjAemSM8kDCUuQVa/iLCuxT46/GbbydNkofaz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR04MB9366.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(19092799006)(7416014)(52116014)(376014)(366016)(38350700014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?V6dmm7vUvyJIyS3nf56hzYhitL6ZDpMByXzO2MBl0FMD2ErJ34SXqRb3TPDP?= =?us-ascii?Q?4XNmaIQ0QqwtyR08eWdVxQYn3Bm5k0T50jft2CrRifxekpCbbec+O78lCXkX?= =?us-ascii?Q?TREa5uj6xAkpmVYVcf0ZCoPkbPCmtybq2WLVU9lZ2JiNilYilUznhWYhnFig?= =?us-ascii?Q?n47j0F/9sA4OzDN0jsS6dUERWo5dwRVJ5JqsPjj/9PNkh3gmVKEfTEzOBDtc?= =?us-ascii?Q?UfF1TmhvtJ4591Z7eRqbduE6HVg+IMkzLpOX0j1ytf1nwvkzIU/7JO3gOcxC?= =?us-ascii?Q?yxf4IW81kp03b/qMnf048G/AAD9vYmMtEIrwKrrztG1SrBhNIIaQwUZxH1Ph?= =?us-ascii?Q?1mRVrYSr1T6l7FKxYH/b0jz6+X+8BnZ1pOYLDA+IntsnYHfQ/imwdE/LLzGZ?= =?us-ascii?Q?jgFRCCtDVsHHXb1uM4ylySHADWjJezne8Sm22YU20iM6odSTBKEz7Y8cAwXG?= =?us-ascii?Q?fKhbYOZXhd747x5gMA6BGUPv38RklFCPs4Adjv0+Wa5BoG1ksp6B6YaVmnp3?= =?us-ascii?Q?mgLdfm03b+tbOhvdz7nWJkRQhTxZPutNUHMH30CwWHskxgcpFFe5h4oOC1w3?= =?us-ascii?Q?P7dg8uxxEZ4vLRJ1E+JVjlNIk9Jq1fr0sijKtgckY4hR38U83g2y6tE13Bye?= =?us-ascii?Q?1MfeU2T9gykmPt5iIdtE6uxCC1l1weVXMpshFcrxWi5I0GSaC6FOajAvhKXc?= =?us-ascii?Q?7PyplOmrQJr7qYU2W3+iI3g0LsPzSBpsKmgx5P9MHUo56Cjmp44w1ZVSR2fG?= =?us-ascii?Q?o/OUKF95v5/BVg5oPkqyxxGCpEPFwzwSYxhxKyCujkCMTOeLKT/DiUTEG0tZ?= =?us-ascii?Q?ON+mSiHiS2rUWGmkfSttkmn/OFjQH4ef5bXjlBh9eNBISASHmFFNQtgj9zcN?= =?us-ascii?Q?Paeg8NIfngkjz64FLRs0cXpF3i/chYmsnjIB6SS1bFTui7/oNu967wNlYO34?= =?us-ascii?Q?4eGPMK5npO0TWPk+//ArgAbI3qXs1B84FQaA4VbqbADJB92NLF71fXa4ODGZ?= =?us-ascii?Q?pciiKpbTFO8x/blDXyEchNKsamhULV+OGDDsmari0sgzTcWG72SIyHKArovP?= =?us-ascii?Q?IT1jTJGz17MOa5eFXVUoFBrWv7ok+FJbZUgGH4v+9AhKwL7vYk2JONW/RJrw?= =?us-ascii?Q?wwEYIewiwctU7kxJ0Vo8Vgra1wZBApFh5Y9QedkCHKDP+uCCrvS6mhKpuydQ?= =?us-ascii?Q?cGmvK1za0IwmUial4+kd26M5i53JZfhab8GvX3dfIqfIliXzCjzh3LUto2Nc?= =?us-ascii?Q?VC30sVCvwcIxkd680mMJyr44i/gqwJM+IV/B/H4i6hwp8qY9IioKLxm9TbJP?= =?us-ascii?Q?b4SHsj1T5r4WBPlsEHWUjcjuuJnrxbbj4hge4y+wGgHh4FO4dKC1k4X5pqQA?= =?us-ascii?Q?FfZtsNjexcvHr7dLmyKI0I2uSJvW43XhgF/GbIBWs4djW0uqpr/MMSdPExCj?= =?us-ascii?Q?/2jV9uFu40eChYbrO10UjBIoDznbuV0XYTOk3SGXX4zSqbjFSfTjlviW8/ps?= =?us-ascii?Q?UePz5jVG/R3LZfB5AV2ECOWOE+yU0DWs7h2qcKlMSp0wvaZhB8V/PECGIArJ?= =?us-ascii?Q?4cGilqTxwsn8Excg5Z+uwrBP216htqhYQV4wG4Z8PJ+nmEC0htWaV1azVqO3?= =?us-ascii?Q?u4AIQjYcHxEgNEn4SdVkUt8GhFM8ZdX4TM3QhumIo3ap5fEK1P5nPmYmegUs?= =?us-ascii?Q?y+lKltz9S7ga6xiORYLX57yrwdtXe0HiH6rdHEPcQsvJWEWkqkIoCG+WEZvP?= =?us-ascii?Q?Cg8YOBV/Uw=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4789953b-0c6f-4b53-d264-08deaabc919b X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9366.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2026 15:40:00.8381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SsHaNS20+x6Yj/x/Psw73/Kznz0dZGuXRzfYok5cbUka8lPp+Jb+l/MF6SPWqki3OfCuijz2C8p9xPzcKaPgtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7026 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260505_084005_844032_57B63ED9 X-CRM114-Status: GOOD ( 14.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 30, 2026 at 11:54:51PM +0800, Hans Zhang wrote: > Use FIELD_MODIFY() to remove open-coded bit manipulation. > No functional change intended. > > Signed-off-by: Hans Zhang <18255117159@163.com> > --- Reviewed-by: Frank Li > drivers/spi/spi-nxp-xspi.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/spi/spi-nxp-xspi.c b/drivers/spi/spi-nxp-xspi.c > index 385302a6e62f..037eac24e6fd 100644 > --- a/drivers/spi/spi-nxp-xspi.c > +++ b/drivers/spi/spi-nxp-xspi.c > @@ -493,9 +493,8 @@ static void nxp_xspi_disable_ddr(struct nxp_xspi *xspi) > writel(reg, base + XSPI_MCR); > > reg &= ~XSPI_MCR_DDR_EN; > - reg &= ~XSPI_MCR_DQS_FA_SEL_MASK; > /* Use dummy pad loopback mode to sample data */ > - reg |= FIELD_PREP(XSPI_MCR_DQS_FA_SEL_MASK, 0x01); > + FIELD_MODIFY(XSPI_MCR_DQS_FA_SEL_MASK, ®, 0x01); > writel(reg, base + XSPI_MCR); > xspi->support_max_rate = 133000000; > > @@ -524,15 +523,13 @@ static void nxp_xspi_enable_ddr(struct nxp_xspi *xspi) > writel(reg, base + XSPI_MCR); > > reg |= XSPI_MCR_DDR_EN; > - reg &= ~XSPI_MCR_DQS_FA_SEL_MASK; > /* Use external dqs to sample data */ > - reg |= FIELD_PREP(XSPI_MCR_DQS_FA_SEL_MASK, 0x03); > + FIELD_MODIFY(XSPI_MCR_DQS_FA_SEL_MASK, ®, 0x03); > writel(reg, base + XSPI_MCR); > xspi->support_max_rate = 200000000; > > reg = readl(base + XSPI_FLSHCR); > - reg &= ~XSPI_FLSHCR_TDH_MASK; > - reg |= FIELD_PREP(XSPI_FLSHCR_TDH_MASK, 0x01); > + FIELD_MODIFY(XSPI_FLSHCR_TDH_MASK, ®, 0x01); > writel(reg, base + XSPI_FLSHCR); > > reg = FIELD_PREP(XSPI_SMPR_DLLFSMPFA_MASK, 0x04); > @@ -1096,8 +1093,7 @@ static int nxp_xspi_default_setup(struct nxp_xspi *xspi) > > /* Give read/write access right to EENV0 */ > reg = readl(base + XSPI_FRAD0_WORD2); > - reg &= ~XSPI_FRAD0_WORD2_MD0ACP_MASK; > - reg |= FIELD_PREP(XSPI_FRAD0_WORD2_MD0ACP_MASK, 0x03); > + FIELD_MODIFY(XSPI_FRAD0_WORD2_MD0ACP_MASK, ®, 0x03); > writel(reg, base + XSPI_FRAD0_WORD2); > > /* Enable the FRAD check for EENV0 */ > -- > 2.34.1 >