From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97B11FF8855 for ; Tue, 5 May 2026 20:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lflu3RVHsQktucpV5ercTdqtfn0roku4H7lizLCj3To=; b=GeLLlvrx9EtZdVMWvBKG97YdNg 1Jz0loU5qBxPdFkQ8S4WDUx8vqb9UStD5UETANvvlNh7XKvR5FDYu3ipNzp6uqCD53RtR09uaZPpj qCL5VtBkqH/IaeH735BqbrH2Z9tkHyIiCKtC5SWIiSTTK4ho9gxhsI0v1sLtzCzFf6sIHHjuhtIOd /8pwuZ+BOQA/mT/psBd3tDHrAhLNxQjGdlr/SkxudcwL+1gr7WQJUPTvpHAg4SYQA5vCto7vhr0CD dw2vuEPUmhwI7kbkGxu7Ef2xvyaLsDm2NfPCErGawFVU7HAfhu1POKOBlDaoaciPJyau8XG2DdTzg rZOUPZRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wKMUO-0000000HRcv-2gt1; Tue, 05 May 2026 20:35:32 +0000 Received: from leonov.paulk.fr ([185.233.101.22]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wKMUM-0000000HRcH-0jJ1 for linux-arm-kernel@lists.infradead.org; Tue, 05 May 2026 20:35:32 +0000 Received: from laika.paulk.fr (12.234.24.109.rev.sfr.net [109.24.234.12]) by leonov.paulk.fr (Postfix) with ESMTPS id 38FB71F8004D for ; Tue, 5 May 2026 20:35:27 +0000 (UTC) Received: by laika.paulk.fr (Postfix, from userid 65534) id 54F49B4058D; Tue, 5 May 2026 20:35:26 +0000 (UTC) Received: from shepard (unknown [192.168.1.1]) by laika.paulk.fr (Postfix) with ESMTPSA id 2A1DAB4058A; Tue, 5 May 2026 20:35:25 +0000 (UTC) Date: Tue, 5 May 2026 22:35:22 +0200 From: Paul Kocialkowski To: Chen-Yu Tsai Cc: Maxime Ripard , Mauro Carvalho Chehab , Jernej Skrabec , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine Message-ID: References: <20260505134812.408316-1-wens@kernel.org> <20260505134812.408316-6-wens@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FpfFtflQBQQ4ZJAp" Content-Disposition: inline In-Reply-To: <20260505134812.408316-6-wens@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260505_133530_544396_5BE1FAEF X-CRM114-Status: GOOD ( 25.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --FpfFtflQBQQ4ZJAp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Chen-Yu, On Tue 05 May 26, 21:48, Chen-Yu Tsai wrote: > The SRAM C region contains a partial alias to the VE SRAM already > referenced by the video engine. To avoid access through this alias > window, the region should also be claimed by the video engine. >=20 > Add a reference to the SRAM C region to the video engine node. It feels very weird to have a reference to the DE2 SRAM region in the VE node. It seems unlikely that the same region would be used by both DE2 a= nd VE and I am pretty sure can have both running at the same time without overstepping. =46rom what I can see we have so far assumed that the SRAM C and SRAM C1 are two different physical SRAM areas, but this is most likely not the case. My guess would be that SRAM C1 is actually a part of SRAM C and the DE2 is using another part of it. The syscon block probably allows switching access to these different parts of SRAM C. Also the sram_c1 node implies it's 2 MiB, which sounds quite unlikely. All the best, Paul >=20 > Fixes: b542570e5605 ("arm64: dts: allwinner: h6: Add Video Engine node") > Signed-off-by: Chen-Yu Tsai > --- > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/bo= ot/dts/allwinner/sun50i-h6.dtsi > index 72ce1a75647b..88c6e3e105c0 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > @@ -205,7 +205,7 @@ video-codec@1c0e000 { > clock-names =3D "ahb", "mod", "ram"; > resets =3D <&ccu RST_BUS_VE>; > interrupts =3D ; > - allwinner,sram =3D <&ve_sram 1>; > + allwinner,sram =3D <&ve_sram 1>, <&de2_sram 1>; > iommus =3D <&iommu 3>; > }; > =20 > --=20 > 2.47.3 >=20 --=20 Paul Kocialkowski, Independent contractor - sys-base - https://www.sys-base.io/ Free software developer - https://www.paulk.fr/ Expert in multimedia, graphics and embedded hardware support with Linux. --FpfFtflQBQQ4ZJAp Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEAbcMXZQMtj1fphLChP3B6o/ulQwFAmn6VIoACgkQhP3B6o/u lQz8VBAAkfyeAYZhinUwpsJmf+oDlItFt7Lfusv+8SkH/qZnD6zCrAQk/Geol1rW wZlYqRlWIV1tboLHrW+hgJmK43/FRZ8zoXdUVBTmn1qlfDX0VtLF2DvHC+uaufyF 4DTP/NfJmIdPOIltCC3FEYzt78hqUzYwwEnsyR+uZ0kPKS8dQyvBoS24LOwnF70g huYXW9SWc+458Sjd+NVae7vJneQsx8xrtafjkfPP5Zx2PdYmMTsGPxuBNgLa2CiA TvtW1mzJtP2egSTdCfzIJRVCdQ6w9/lYvQoFQfz7U+L+MwpB8U7g3yU7sbIEEBwz 1RzbbYTvHm68D95/Qb4wkxEPXPw/HTD5Hy3iHdw6JLz3VOXvvQapTbOQqADL7SqD 6HE8NxgGcLLVMO6P3Na0l+nu6AyuXnou5x99ukr1lQYNAVeUCcq4CpN6GV9/Tgq+ 5ZcTzVFJqD2RJfdPbuljaRgWU5i7fUk1QX0QiNmW+m84Kg5e+wkzf/TB1E5JmypQ w4d8oYb059s57puI8NZgwHnyhoLu3HB/NhjboHLcuwzcbgY6PMq68lqazv6qNY/p bvQU0TQ/2HwBmCtQT7dIn1ShT5xfo0cu3qpl0bHH9iKBcnXCjdGGqmrNliwBIhta 5rW/eK5LQyKRXSSg3mKHjITNERBpiraMB65z3LMKUrE/UHivWxA= =03GE -----END PGP SIGNATURE----- --FpfFtflQBQQ4ZJAp--