From: Mark Brown <broonie@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2 2/3] ASoC: pxa2xx: push gpio usage into arch code
Date: Wed, 6 May 2026 08:58:21 +0900 [thread overview]
Message-ID: <afqEHZSUCASXPUze@sirena.co.uk> (raw)
In-Reply-To: <20260505202426.3605262-2-arnd@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
On Tue, May 05, 2026 at 10:24:25PM +0200, Arnd Bergmann wrote:
> index 7df78867db49..0d5eaf4b100c 100644
> --- a/include/linux/platform_data/asoc-pxa.h
> +++ b/include/linux/platform_data/asoc-pxa.h
> @@ -6,6 +6,6 @@
> #include <sound/pcm.h>
> #include <sound/ac97_codec.h>
>
> -extern void pxa27x_configure_ac97reset(int reset_gpio, bool to_gpio);
> +extern void pxa27x_configure_ac97reset(struct gpio_desc *reset_gpio, bool to_gpio);
>
> #endif
You're adding a use of struct gpio_desc but not including the header for
it or declaring it. Which won't really matter here but still.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-05-05 23:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 20:24 [PATCH v2 1/3] ASoC: arm: pxa2xx: remove platform_data processing Arnd Bergmann
2026-05-05 20:24 ` [PATCH v2 2/3] ASoC: pxa2xx: push gpio usage into arch code Arnd Bergmann
2026-05-05 23:58 ` Mark Brown [this message]
2026-05-06 8:15 ` Andy Shevchenko
2026-05-06 8:13 ` Andy Shevchenko
2026-05-05 20:24 ` [PATCH v2 3/3] ASoC: pxa: integrate sound/arm/pxa2xx into sound/soc/pxa2xx Arnd Bergmann
2026-05-06 1:14 ` [PATCH v2 1/3] ASoC: arm: pxa2xx: remove platform_data processing Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afqEHZSUCASXPUze@sirena.co.uk \
--to=broonie@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robert.jarzmik@free.fr \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox