From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A081CD5BB1 for ; Thu, 21 May 2026 12:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jauKNf6YmB3cZhW+7szP4H8kKNn0SlSF8XuPMEW0m3Q=; b=xTNYaE/dA+CL4ltjlZjC+PsPMo fUZDJRqIS0/XB+RkCeo+GQm94zxOIeP88jaHR9WwwPjB7md9t2kC3PUDq7dYBapkdt+oTiRHJsXES a5dU1s+dh7pRVOhvBxYe7882b/krGZ9kDvGa6iI+xhf0TNyF8W7kcxzJhOIWiIsWaajH7vPF6xHtq ZdUduPFHsBJ71T+nu8x2Tqi5pb4n+OTReXxbRpPp/2E48vFf8AxRnrLU8pHUkEZkK7p0rsGwo2dFe WJu0YsTe5gDuIxs3gWMnhDuDJmyO44vSKaI4irWzYG+KAksq7txBEetK/wnpCQY24fGO0oiMHQrIy Y0DlD6QQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQ2pl-00000007lqI-2Q0b; Thu, 21 May 2026 12:49:05 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQ2pi-00000007lpI-3QcZ for linux-arm-kernel@lists.infradead.org; Thu, 21 May 2026 12:49:03 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wQ2pZ-0001I8-Dh; Thu, 21 May 2026 14:48:53 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wQ2pY-0016dZ-1K; Thu, 21 May 2026 14:48:52 +0200 Received: from mtr by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wQ2pY-00000004ViT-3Xge; Thu, 21 May 2026 14:48:52 +0200 Date: Thu, 21 May 2026 14:48:52 +0200 From: Michael Tretter To: Sven =?utf-8?Q?P=C3=BCschel?= Cc: Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, nicolas@ndufresne.ca, sebastian.reichel@collabora.com, p.zabel@pengutronix.de, Nicolas Dufresne Subject: Re: [PATCH v7 07/28] media: rockchip: rga: use clk_bulk api Message-ID: Mail-Followup-To: Michael Tretter , Sven =?utf-8?Q?P=C3=BCschel?= , Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, nicolas@ndufresne.ca, sebastian.reichel@collabora.com, p.zabel@pengutronix.de, Nicolas Dufresne References: <20260521-spu-rga3-v7-0-3f33e8c7145f@pengutronix.de> <20260521-spu-rga3-v7-7-3f33e8c7145f@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260521-spu-rga3-v7-7-3f33e8c7145f@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: m.tretter@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260521_054902_852465_4D2118E5 X-CRM114-Status: GOOD ( 23.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 21 May 2026 00:44:12 +0200, Sven Püschel wrote: > Use the clk_bulk API to avoid code duplication for each of the three > clocks. > > Reviewed-by: Nicolas Dufresne > Signed-off-by: Sven Püschel > --- > drivers/media/platform/rockchip/rga/rga.c | 65 ++++--------------------------- > drivers/media/platform/rockchip/rga/rga.h | 6 +-- > 2 files changed, 11 insertions(+), 60 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c > index fea63b94c5f3d..4e710a050cb7c 100644 > --- a/drivers/media/platform/rockchip/rga/rga.c > +++ b/drivers/media/platform/rockchip/rga/rga.c > @@ -698,48 +698,10 @@ static const struct video_device rga_videodev = { > .device_caps = V4L2_CAP_VIDEO_M2M_MPLANE | V4L2_CAP_STREAMING, > }; > > -static int rga_enable_clocks(struct rockchip_rga *rga) > -{ > - int ret; > - > - ret = clk_prepare_enable(rga->sclk); > - if (ret) { > - dev_err(rga->dev, "Cannot enable rga sclk: %d\n", ret); > - return ret; > - } > - > - ret = clk_prepare_enable(rga->aclk); > - if (ret) { > - dev_err(rga->dev, "Cannot enable rga aclk: %d\n", ret); > - goto err_disable_sclk; > - } > - > - ret = clk_prepare_enable(rga->hclk); > - if (ret) { > - dev_err(rga->dev, "Cannot enable rga hclk: %d\n", ret); > - goto err_disable_aclk; > - } > - > - return 0; > - > -err_disable_aclk: > - clk_disable_unprepare(rga->aclk); > -err_disable_sclk: > - clk_disable_unprepare(rga->sclk); > - > - return ret; > -} > - > -static void rga_disable_clocks(struct rockchip_rga *rga) > -{ > - clk_disable_unprepare(rga->sclk); > - clk_disable_unprepare(rga->hclk); > - clk_disable_unprepare(rga->aclk); > -} > - > static int rga_parse_dt(struct rockchip_rga *rga) > { > struct reset_control *core_rst, *axi_rst, *ahb_rst; > + int ret; > > core_rst = devm_reset_control_get(rga->dev, "core"); > if (IS_ERR(core_rst)) { > @@ -771,23 +733,12 @@ static int rga_parse_dt(struct rockchip_rga *rga) > udelay(1); > reset_control_deassert(ahb_rst); > > - rga->sclk = devm_clk_get(rga->dev, "sclk"); > - if (IS_ERR(rga->sclk)) { > - dev_err(rga->dev, "failed to get sclk clock\n"); > - return PTR_ERR(rga->sclk); > - } > - > - rga->aclk = devm_clk_get(rga->dev, "aclk"); > - if (IS_ERR(rga->aclk)) { > - dev_err(rga->dev, "failed to get aclk clock\n"); > - return PTR_ERR(rga->aclk); > - } > - > - rga->hclk = devm_clk_get(rga->dev, "hclk"); > - if (IS_ERR(rga->hclk)) { > - dev_err(rga->dev, "failed to get hclk clock\n"); > - return PTR_ERR(rga->hclk); > + ret = devm_clk_bulk_get_all(rga->dev, &rga->clks); > + if (ret < 0) { This changes the behavior since the call is now successful if there are no clocks specified in the device tree. Is this an intended change? Michael > + dev_err(rga->dev, "failed to get clocks\n"); > + return ret; > } > + rga->num_clks = ret; > > return 0; > } > @@ -935,7 +886,7 @@ static int __maybe_unused rga_runtime_suspend(struct device *dev) > { > struct rockchip_rga *rga = dev_get_drvdata(dev); > > - rga_disable_clocks(rga); > + clk_bulk_disable_unprepare(rga->num_clks, rga->clks); > > return 0; > } > @@ -944,7 +895,7 @@ static int __maybe_unused rga_runtime_resume(struct device *dev) > { > struct rockchip_rga *rga = dev_get_drvdata(dev); > > - return rga_enable_clocks(rga); > + return clk_bulk_prepare_enable(rga->num_clks, rga->clks); > } > > static const struct dev_pm_ops rga_pm = { > diff --git a/drivers/media/platform/rockchip/rga/rga.h b/drivers/media/platform/rockchip/rga/rga.h > index 72a28b120fabf..2db10acecb405 100644 > --- a/drivers/media/platform/rockchip/rga/rga.h > +++ b/drivers/media/platform/rockchip/rga/rga.h > @@ -6,6 +6,7 @@ > #ifndef __RGA_H__ > #define __RGA_H__ > > +#include > #include > #include > #include > @@ -81,9 +82,8 @@ struct rockchip_rga { > struct device *dev; > struct regmap *grf; > void __iomem *regs; > - struct clk *sclk; > - struct clk *aclk; > - struct clk *hclk; > + struct clk_bulk_data *clks; > + int num_clks; > struct rockchip_rga_version version; > > /* vfd lock */ > > -- > 2.54.0 > >