From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4252CCD5BAC for ; Thu, 21 May 2026 14:40:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hKs1wGtTKcSBmSwQxcOcdV5Ynyi4NSoFVgrZJr2maq0=; b=xedXYxfygH+eNWNOLRpVxOYErQ QTPq3ze+qvmtGTMkxbaJU9jdrKcS9UIivworHLcyhsfeBCyegzHwg+n+U3sGJtG0whsiZt2i/ISvY NXEuBg0eOIetuMSCZzwqE9G3FVKFXf8nzc3HP317dR2b/8n4TuEROl++j4UfE0mBUtR2KVe/i8+ty 22Q9h4WyqDWNkMWMOPvCVRANkgynOCANoRfT2r8d/VoVuE33rVUeB2R7QxUUHfdLl0oLIDHs5EMXH yjvU1qDVms3TgRp+wWru5VDBhpbSZxqRqz477biw8g/tTgw705GIEJFwzm8dnbnr2IKBAbyJ885HL nQFCe/nA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQ4Z6-000000086dz-3BFu; Thu, 21 May 2026 14:40:00 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQ4Z2-000000086c0-0Mtv for linux-arm-kernel@lists.infradead.org; Thu, 21 May 2026 14:39:59 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wQ4Ys-0002Y8-Hi; Thu, 21 May 2026 16:39:46 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wQ4Yq-0017VH-2e; Thu, 21 May 2026 16:39:45 +0200 Received: from mtr by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wQ4Yr-00000004XAS-171E; Thu, 21 May 2026 16:39:45 +0200 Date: Thu, 21 May 2026 16:39:45 +0200 From: Michael Tretter To: Sven =?utf-8?Q?P=C3=BCschel?= Cc: Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, nicolas@ndufresne.ca, sebastian.reichel@collabora.com, p.zabel@pengutronix.de Subject: Re: [PATCH v7 16/28] media: rockchip: rga: reuse cmdbuf contents Message-ID: Mail-Followup-To: Michael Tretter , Sven =?utf-8?Q?P=C3=BCschel?= , Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, nicolas@ndufresne.ca, sebastian.reichel@collabora.com, p.zabel@pengutronix.de References: <20260521-spu-rga3-v7-0-3f33e8c7145f@pengutronix.de> <20260521-spu-rga3-v7-16-3f33e8c7145f@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260521-spu-rga3-v7-16-3f33e8c7145f@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: m.tretter@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260521_073956_294748_406B58B9 X-CRM114-Status: GOOD ( 31.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 21 May 2026 00:44:21 +0200, Sven Püschel wrote: > Reuse the command buffer contents instead of completely writing it > for every frame. Therefore we only need to replace the source and > destination addresses for each frame. This reduces the amount of CPU > and memory operations done in each frame. A new cmdbuf_dirty flag notes > if the cmdbuf has to be rewritten on the next frame. > > The initial idea of initializing the cmdbuf on streamon broke the > ability to update controls while streaming (e.g. mirroring). > > Signed-off-by: Sven Püschel > > --- > Changes in v6: > - Reworked the commit to not setup the cmdbuf on streamon but rather > re-initialize it on the next frame when something changed. > - Sasahiko flagged the cmdbuf setup at streamon: > https://sashiko.dev/#/patchset/20260428-spu-rga3-v5-0-eb7f5d019d86%40pengutronix.de?part=17 > - Dropped Reviewed-by: Nicolas Dufresne > due to the reworked patch and commit message contents > > Changes in v5: > - Don't set the flipping and rotation values at streamon and preventing > the userspace from chainging them at runtime > --- > drivers/media/platform/rockchip/rga/rga-hw.c | 13 +++++++++---- > drivers/media/platform/rockchip/rga/rga.c | 11 +++++++++-- > drivers/media/platform/rockchip/rga/rga.h | 2 ++ > 3 files changed, 20 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rga/rga-hw.c b/drivers/media/platform/rockchip/rga/rga-hw.c > index dac3cb6aa17d3..567d39e58d33f 100644 > --- a/drivers/media/platform/rockchip/rga/rga-hw.c > +++ b/drivers/media/platform/rockchip/rga/rga-hw.c > @@ -417,8 +417,6 @@ static void rga_cmd_set(struct rga_ctx *ctx, > { > struct rockchip_rga *rga = ctx->rga; > > - memset(ctx->cmdbuf_virt, 0, RGA_CMDBUF_SIZE); > - > rga_cmd_set_src_addr(ctx, src->dma_desc_pa); > /* > * Due to hardware bug, > @@ -427,11 +425,9 @@ static void rga_cmd_set(struct rga_ctx *ctx, > rga_cmd_set_src1_addr(ctx, dst->dma_desc_pa); > > rga_cmd_set_dst_addr(ctx, dst->dma_desc_pa); > - rga_cmd_set_mode(ctx); > > rga_cmd_set_src_info(ctx, &src->offset); > rga_cmd_set_dst_info(ctx, &dst->offset); > - rga_cmd_set_trans_info(ctx); > > rga_write(rga, RGA_CMD_BASE, ctx->cmdbuf_phy); > > @@ -440,6 +436,14 @@ static void rga_cmd_set(struct rga_ctx *ctx, > PAGE_SIZE, DMA_BIDIRECTIONAL); > } > > +static void rga_hw_setup_cmdbuf(struct rga_ctx *ctx) > +{ > + memset(ctx->cmdbuf_virt, 0, RGA_CMDBUF_SIZE); > + > + rga_cmd_set_mode(ctx); > + rga_cmd_set_trans_info(ctx); > +} > + > static void rga_hw_start(struct rockchip_rga *rga, > struct rga_vb_buffer *src, struct rga_vb_buffer *dst) > { > @@ -582,6 +586,7 @@ const struct rga_hw rga2_hw = { > .max_height = MAX_HEIGHT, > .stride_alignment = 4, > > + .setup_cmdbuf = rga_hw_setup_cmdbuf, > .start = rga_hw_start, > .handle_irq = rga_handle_irq, > .get_version = rga_get_version, > diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c > index d080cb672740b..394b14b9469df 100644 > --- a/drivers/media/platform/rockchip/rga/rga.c > +++ b/drivers/media/platform/rockchip/rga/rga.c > @@ -38,6 +38,11 @@ static void device_run(void *prv) > unsigned long flags; > > spin_lock_irqsave(&rga->ctrl_lock, flags); > + if (ctx->cmdbuf_dirty) { > + ctx->cmdbuf_dirty = false; > + rga->hw->setup_cmdbuf(ctx); > + } > + spin_unlock_irqrestore(&rga->ctrl_lock, flags); > > rga->curr = ctx; > > @@ -47,8 +52,6 @@ static void device_run(void *prv) > dst = v4l2_m2m_next_dst_buf(ctx->fh.m2m_ctx); > > rga->hw->start(rga, vb_to_rga(src), vb_to_rga(dst)); > - > - spin_unlock_irqrestore(&rga->ctrl_lock, flags); I guess that the unlock can be moved, because relevant content of the cmdbuf is now only changed in the setup_cmd() function and changes done by rga_cmd_set() don't have to be synchronized. It would be helpful if this is explained in the commit message or even moved to a separate patch. Michael > } > > static irqreturn_t rga_isr(int irq, void *prv) > @@ -141,6 +144,7 @@ static int rga_s_ctrl(struct v4l2_ctrl *ctrl) > ctx->fill_color = ctrl->val; > break; > } > + ctx->cmdbuf_dirty = true; > spin_unlock_irqrestore(&ctx->rga->ctrl_lock, flags); > return 0; > } > @@ -228,6 +232,7 @@ static int rga_open(struct file *file) > ret = -ENOMEM; > goto rel_ctx; > } > + ctx->cmdbuf_dirty = true; > > ctx->rga = rga; > /* Set default formats */ > @@ -448,6 +453,7 @@ static int vidioc_s_fmt(struct file *file, void *priv, struct v4l2_format *f) > frm->crop.height = pix_fmt->height; > > frm->pix = *pix_fmt; > + ctx->cmdbuf_dirty = true; > > v4l2_dbg(debug, 1, &rga->v4l2_dev, > "[%s] fmt - %p4cc %dx%d (stride %d, sizeimage %d)\n", > @@ -564,6 +570,7 @@ static int vidioc_s_selection(struct file *file, void *priv, > } > > f->crop = s->r; > + ctx->cmdbuf_dirty = true; > > return ret; > } > diff --git a/drivers/media/platform/rockchip/rga/rga.h b/drivers/media/platform/rockchip/rga/rga.h > index 38518146910a6..5360f092fecf0 100644 > --- a/drivers/media/platform/rockchip/rga/rga.h > +++ b/drivers/media/platform/rockchip/rga/rga.h > @@ -55,6 +55,7 @@ struct rga_ctx { > > void *cmdbuf_virt; > dma_addr_t cmdbuf_phy; > + bool cmdbuf_dirty; > > int osequence; > int csequence; > @@ -152,6 +153,7 @@ struct rga_hw { > u32 max_width, max_height; > u8 stride_alignment; > > + void (*setup_cmdbuf)(struct rga_ctx *ctx); > void (*start)(struct rockchip_rga *rga, > struct rga_vb_buffer *src, struct rga_vb_buffer *dst); > bool (*handle_irq)(struct rockchip_rga *rga); > > -- > 2.54.0 > >