From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E17FCD5BAF for ; Thu, 21 May 2026 17:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cS6fnA3lU2D/+Z8LnfqqCPtAqVL4T2HGREkrLBAbKIc=; b=0+M23yrPObYvgXWEITEvkSyyDK uWKvFKJaDvcqxWoDfvKTJJlKLArSV13OwHOS3e2u1ED75ADevv+gOjorm84lfVNamUWTrslR9qy7Z amgRdwgGdDXW+jrt6vDCLYcpJpJm429kIv9VPTWJ+15zc1SStntbOf9rdiIq+Fs/KoFEOeTSBTRqV TUFzLeAYlBtjUbbTfN+3CD1H2rs5dpvjRLTUsMoKF24/9zC9T1yXIKdVxYesAZs257/fZVccb5Y0a qVRlYKLZG1Z0+EryBIFIe1AtNd3qkH59DUWYkMt3xApiQGcr5PZeHzc421UD49B5phtq2/fbBvuxd tass1g8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQ7Sn-00000008gR6-0efz; Thu, 21 May 2026 17:45:41 +0000 Received: from mail-westus3azon11011071.outbound.protection.outlook.com ([40.107.208.71] helo=PH0PR06CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQ7Sl-00000008gQV-0gyr for linux-arm-kernel@lists.infradead.org; Thu, 21 May 2026 17:45:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LETUtezBm0wzqMjV+xVvh1zSYr4fT/TXQxJ9aIJrJy5XNh0+AUqR03WEHZNU0xRnlDv1h7BH539XKMvK1WNcEgSlU1Xtn+OkZ3viYOH/JGx5bLwsASfT/fo8Ed/S2f8d6Quep5wxEKn+dxXEDcWFa7iWfW+LmZHqAjPrxI4mmrf5sf2w/dEiSTUfJH2PlZ2Ctf1sGOK5Yv0TcQoizVq7n1qwYW0erYldlUK5vrLTgwxUccv6vPIcLzaUGsKtcaeoMWth7Vlhy70bP5Fbz1auHDWl9puptPSVgZbLw6CP35VPbU3SUYjLqVfpZgryk2Rm/K7dmXWmRS/xonn4H+OccA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cS6fnA3lU2D/+Z8LnfqqCPtAqVL4T2HGREkrLBAbKIc=; b=fgWOFM1MIvU77GWlf3o80++W7r4uE6rBFPsX6Qf+Woir3I4lPKjxilXDXJ7ENVBbAx9mE1hd5d1uPVWZZIHRGol501P+9NtS6bDvOuT3qdqluF/R7c5x7tCR2caxgEXmDH8vC/txbbJkkbyqRTWLdalX/yV081+BAcPChwhwMF5RNpZuV8nS3VfLq/uBtwtXa49yMJCSFWCZKx+qRMvjKAiZWLPQlVKuruc+x1owRA8VVdJLHyXTjpZJX5DHQEk28TYFI8Q5L5MVYbKHBjJqG0yawvArCeu78DJp5mkQq49jLD6lR4LGHV2OcQ67bvPZxBX+0Zl17UwArswOE1CmHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cS6fnA3lU2D/+Z8LnfqqCPtAqVL4T2HGREkrLBAbKIc=; b=FOYB4XGuGq/41vvh3eL+vEJp2viDczaQYvtVC09HvFUTQ5qcdEpfG+gB5KhmIqO59O40Mo+LhaV3+4IIRfGScL5g+F8GpXGUiOtV+YvG5FiDYXy9sPYbbiI00pJ8bUvOKpocFaBNqFe5bik6xmoTM+Us+P1FUkT5a5oZbKlSQx0uzJJRJwldl/f56+ML508/E2ipka9cfwStgduXdlz9XhanwsMsCH1KYzuGkshVXhqMKIyRZoa4Ub394b1vTQRnBGli5uzdVxrvq+RF8vUbBFJo4ytYW1f/ZLqLsEGoseCoONh0fhxL2J1C6rwS21zyBC9/wyHxZhtJQC+GiVuYQw== Received: from MN0PR02CA0001.namprd02.prod.outlook.com (2603:10b6:208:530::21) by SJ0PR12MB6966.namprd12.prod.outlook.com (2603:10b6:a03:449::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.17; Thu, 21 May 2026 17:45:23 +0000 Received: from BL02EPF00021F6E.namprd02.prod.outlook.com (2603:10b6:208:530:cafe::37) by MN0PR02CA0001.outlook.office365.com (2603:10b6:208:530::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.17 via Frontend Transport; Thu, 21 May 2026 17:45:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by BL02EPF00021F6E.mail.protection.outlook.com (10.167.249.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.7 via Frontend Transport; Thu, 21 May 2026 17:45:22 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 21 May 2026 10:45:03 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 21 May 2026 10:45:02 -0700 Received: from Asurada-Nvidia (10.127.8.9) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 21 May 2026 10:45:01 -0700 Date: Thu, 21 May 2026 10:44:55 -0700 From: Nicolin Chen To: Jason Gunthorpe CC: , , , , , , , , , , , , , , , , Subject: Re: [PATCH v5 3/3] iommu/arm-smmu-v3: Allow ATS to be always on Message-ID: References: <20260521134409.GG3602937@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20260521134409.GG3602937@nvidia.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6E:EE_|SJ0PR12MB6966:EE_ X-MS-Office365-Filtering-Correlation-Id: 2fc38333-d4de-4a95-6d4d-08deb760bb71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|7416014|376014|1800799024|82310400026|11063799006|56012099003|18002099003|22082099003|4143699003; X-Microsoft-Antispam-Message-Info: jVaCFrMgb8PVU44UR+FzIujRbMc/DWQ3InH8UF8wRt8lAwT5yfpjJ6Pa20LTBwivthoNvQe+gXy82ck6MTF10oc6V+fmuToD0HoM+ZkJ+ooDUbQ5oDwosaoW9VflDdS+VLOdt7DLpu0n1Z2ikz7LFUJxIY4hJpREeGRmlCC9XXeL9TpJiRG/xZXd+8LNZsfg/wlZSbNuL9lGFzuNZE/tL8zctgVRiV1+aR0JZQbu1g2vq2rnezjFf9zcRgfgEZYflZJp5pB8qUg2D3CWC9fv11GzLlJS8rpErQEUlgZoEzvRFs2WKdKerZQ6QyfoQ/31AkTcv8wrLk2vQva0EbufFyNDrXFC+cHC5xWjs5n/TLnIhFofWEje24poCKv/xLjlZRpTjO2630Klj5hR97s2XRcopzC46JLxRrTqawVfEFb0lZ3jLigmQKyY2OQgch3OZyw7myu42lIbYzXZ3FV6bYhcl8+oig5k3IPW/MrOWvmaVcrw9eD6R1SQdC2DAmhgEkO6FM+qitUtGW+ZctYKKNTPPdcPSvfVZ93v941VjWavgzl7gN3d1sPKc76rHfPpnuljxGhNxd4vw4PZBpkVpGT+51O22Z4+J3Wae7s9WOFIVC7rss7yurfISode8fHajMlgzXgCbw3diBcws/85c0tsDXwa3ec404862zeWxi1h8ZdwvdXJUdQYwKdms2a/CUUt1gIaItOrif6SPTqqcZNFKQzb0/Q6NC/AQaoP97Y= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700016)(7416014)(376014)(1800799024)(82310400026)(11063799006)(56012099003)(18002099003)(22082099003)(4143699003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5LSmE+lN7OMQsDlTrdNnXK3aw178rYJ/P4fIxzhQVNc5Sl/W2pG8YLbAfBejUgQleYtq7pyUzw3/64Hsts2KuS2pxDbLxDfq2qvKhkB8r6HH0t/h/hFRc3jHGO9sLvNeV6hRi+sa78gxrd0aBXv+Hdab7cij8JFl9a5qu3MuuSRSja/MmQi/rBBcRxaNaq+Awrc0PX+HlcMOST0QspixrlutykMROYEZViA6E5iCCCaGeNtYWb36cLk59l4GiUUcX1xsWA8sZBMGFQKqFYwwg/RG1qimeereUX9WwOfg+IGXh9ZUvRkvzA9EXiBX4hXZq5YoBrvmZZ5Z7uLlSiUI6YDXkaFHZYy23HIY33DXcOtMkvzUfHo/Y3U3PiLOsLQpBQ4ya8UfOaRkT4ynp9W0Gs3R30XWjFp+JZYtLxx4qqWYGleGYVeMFDAjm5nl5Rf5 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2026 17:45:22.0719 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2fc38333-d4de-4a95-6d4d-08deb760bb71 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6966 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260521_104539_207535_E964FA2F X-CRM114-Status: GOOD ( 14.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 21, 2026 at 10:44:09AM -0300, Jason Gunthorpe wrote: > On Wed, May 20, 2026 at 03:35:32PM -0700, Nicolin Chen wrote: > > @ -3870,13 +3870,15 @@ static int arm_smmu_blocking_set_dev_pasid(struct iommu_domain *new_domain, > > * When the last user of the CD table goes away downgrade the STE back > > * to a non-cd_table one, by re-attaching its sid_domain. > > */ > > - if (!master->ats_always_on && > > - !arm_smmu_ssids_in_use(&master->cd_table)) { > > + if (!arm_smmu_ssids_in_use(&master->cd_table)) { > > struct iommu_domain *sid_domain = > > iommu_driver_get_domain_for_dev(master->dev); > > + bool ats_always_on = master->ats_always_on && > > + sid_domain->type != IOMMU_DOMAIN_BLOCKED; > > + bool downgrade = sid_domain->type == IOMMU_DOMAIN_IDENTITY || > > + sid_domain->type == IOMMU_DOMAIN_BLOCKED; > > > > - if (sid_domain->type == IOMMU_DOMAIN_IDENTITY || > > - sid_domain->type == IOMMU_DOMAIN_BLOCKED) > > + if (!ats_always_on && downgrade) > > sid_domain->ops->attach_dev(sid_domain, dev, > > sid_domain); > > Only identity should remain with the CD S1DSS STE, BLOCKED should > attach the normal blocking domain still Yea. I have !ats_always_on guarding here. Thanks Nicolin