From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B73ECD4F24 for ; Wed, 13 May 2026 09:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TEGFWKjOqhgzGH/MA0MNwle+lypf2nUBTYyQwRxwPQY=; b=T0izRTlO7esPPPKitI1XTNyECs xuv8/aCLUmjWF7nWre38PK6YgzC1y37yCXodncc3BxbuYodnfoErEiWBsnzbSGjPIgAcVYgdLCwKL 6QYIICtVxWKcX/sGKdCOechy8x83bz7f07PVAR4n6WJGYJG/DO4xstL5zk1D1MxZMY9liTzLRrgCm ylGE7ZZ0XarnpFPTTowfbNiqftcCTEvSwgDeoQvLLx12qD8ZFLb9FMi7WjeijxkyXhMQpmXNd8tcg 0dN98/ZKi53efJS5uzKJCF+sA/cLI4q+mgVwk+AC+R4MBx9K25l+pmuwnEQ1M3BgzGHY+1NEGY3a9 7HP+B7Nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wN63x-00000001x1h-3EiA; Wed, 13 May 2026 09:39:33 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wN63u-00000001x11-3Rit for linux-arm-kernel@lists.infradead.org; Wed, 13 May 2026 09:39:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id E335E439CF; Wed, 13 May 2026 09:39:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6410EC2BCB7; Wed, 13 May 2026 09:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778665169; bh=TcFQKIO6/vF+a3AYUGgIu/LGO27K1VGQqQ73DvAzV+E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ldhuKbdqCzllph7J2oBe1tFll52xEIvi/X5XGIsQ9jlPH3V0+5FbslEKFvpvKUiey HSKP1mujb09J9IRarHFIY+IvP8fHk1kSV3cbnMYwTayb3UO0mgP9sfcdRQntIkGUTu 8hAczgPHMmt8pRtF4EuoQhgN7nQeAdY1hvBLLOt7mrjk4pQLM6V3UWowNDtbhyBRjw YCW00YAQABZgtqpqyraWAbwmBydtOYzf1m+oxQGD9sgkosK/znBBNIdMFnhh1kZInm UG/vKw205xcei0CUxLtGjz5m1s4IYeEFwqoa9JVp50Qxbmoc9fsBf4bBFGgLVI7PCo //3toDnC0mkUw== Date: Wed, 13 May 2026 10:39:27 +0100 From: Lorenzo Stoakes To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Ryan Roberts , Mark Rutland , Andrew Morton , David Hildenbrand , Mike Rapoport , Linu Cherian , Usama Arif , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC V2 00/14] arm64/mm: Enable 128 bit page table entries Message-ID: References: <20260513044547.4128549-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260513044547.4128549-1-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260513_023930_901745_2CD1EBE9 X-CRM114-Status: GOOD ( 28.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org -cc my previous kernel address Hi Anshuman, Sorry to be a pain, but I'm using ljs@kernel.org now for my kernel mail, so I am at risk of missing stuff sent to my @oracle.com address (I changed things around to make managing the... rather large quantities of mail I get a bit easier :) Hence I missed this previously, can you send future revisions to ljs@kernel.org? Thanks! Cheers, Lorenzo On Wed, May 13, 2026 at 10:15:33AM +0530, Anshuman Khandual wrote: > FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128 > translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards. > So with this feature arm64 platforms could have two different translation > systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled. > > FEAT_D128 adds 128 bit page table entries, thus supporting larger physical > and virtual address range while also expanding available room for more MMU > management feature bits both for HW and SW. > > This series has been split into two parts. Generic MM changes followed by > arm64 platform changes, finally enabling D128 with a new config ARM64_D128. > > READ_ONCE() on page table entries get routed via level specific pxdp_get() > helpers which platforms could then override when required. These accessors > on arm64 platform help in ensuring page table accesses are performed in an > atomic manner while reading 128 bit page table entries. > > All ARM64_VA_BITS and ARM64_PA_BITS combinations for all page sizes are now > supported both on D64 and D128 translation regimes. Although new 56 bits VA > space is not yet supported. Similarly FEAT_D128 skip level is not supported > currently. > > Basic page table geometry has also been changed with D128 as there are fewer > entries per level. Please refer to the following table for leaf entry sizes. > > D64 D128 > ------------------------------------------------ > | PAGE_SIZE | PMD | PUD | PMD | PUD | > -----------------------------|-----------------| > | 4K | 2M | 1G | 1M | 256M | > | 16K | 32M | 64G | 16M | 16G | > | 64K | 512M | 4T | 256M | 1T | > ------------------------------------------------ > > D64 D128 > -------------------------------------------------------------------- > | PAGE_SIZE | CONT_PTE | CONT_PMD | CONT_PTE | CONT_PMD | > --------------------------|------------|-------------|-------------- > | 4K | 64K | 32M | 64K | 16M | > | 16K | 2M | 1G | 1M | 256M | > | 64K | 2M | 16G | 1M | 16G | > -------------------------------------------------------------------- > > From arm64 kernel features perspective KVM, KASAN and UNMAP_KERNEL_AT_EL0 > are currently not supported as well. > > This series applies on v7.1-rc3 and there are no apparent problems while > running MM kselftests with and without CONFIG_ARM64_D128. Besides this has > been built tested on other platform such as x86, powerpc, riscv, arm and > s390 etc. > > Changes in RFC V2: > > - Dropped some patches that were merged upstream and rebased on v7.1-rc3 > - Moved pxdval_t definition inside generic page table header per Mike > - Restored print format in __print_bad_page_map_pgtable() per Usama > - Renamed __PRIpte as __PRIpxx per David > - Dropped _once from pgprot_[read|write]() callbacks per Mike > - Moved back all helpers back from arch/arm64/mm/mmu.c into the header > - Renamed all ptdesc_ instances as pxxval_ instead > - Moved arm64 pgtable header READ_ONCE() replacements later in the series > - Updated commit message for the 5-level fixmap change per David > - Updated ARM64_CONT_[PTE|PMD]_SHIFT both for 16K and 64K base pages > - Added abstraction for tlbi_op > - Adopted TLBIP implementation to recent TLB flush changes > - Updated all commit messages as required and suggested > > Changes in RFC V1: > > https://lore.kernel.org/linux-arm-kernel/20260224051153.3150613-2-anshuman.khandual@arm.com/ > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Ryan Roberts > Cc: Mark Rutland > Cc: Lorenzo Stoakes > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Mike Rapoport > Cc: Linu Cherian > Cc: Usama Arif > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org > > Anshuman Khandual (13): > mm: Abstract printing of pxd_val() > mm: Add read-write accessors for vm_page_prot > arm64/mm: Convert READ_ONCE() as pmdp_get() while accessing PMD > arm64/mm: Convert READ_ONCE() as pudp_get() while accessing PUD > arm64/mm: Convert READ_ONCE() as p4dp_get() while accessing P4D > arm64/mm: Convert READ_ONCE() as pgdp_get() while accessing PGD > arm64/mm: Route all pgtable reads via pxxval_get() > arm64/mm: Route all pgtable writes via pxxval_set() > arm64/mm: Route all pgtable atomics to central helpers > arm64/mm: Abstract printing of pxd_val() > arm64/mm: Override read-write accessors for vm_page_prot > arm64/mm: Enable fixmap with 5 level page table > arm64/mm: Add initial support for FEAT_D128 page tables > > Linu Cherian (1): > arm64/mm: Add an abstraction level for tlbi_op > > arch/arm64/Kconfig | 51 +++++++- > arch/arm64/Makefile | 4 + > arch/arm64/include/asm/assembler.h | 4 +- > arch/arm64/include/asm/el2_setup.h | 9 ++ > arch/arm64/include/asm/pgtable-hwdef.h | 137 ++++++++++++++++++++ > arch/arm64/include/asm/pgtable-prot.h | 18 ++- > arch/arm64/include/asm/pgtable-types.h | 12 ++ > arch/arm64/include/asm/pgtable.h | 169 ++++++++++++++++++++----- > arch/arm64/include/asm/smp.h | 1 + > arch/arm64/include/asm/tlbflush.h | 138 ++++++++++++++------ > arch/arm64/kernel/head.S | 12 ++ > arch/arm64/mm/fault.c | 20 +-- > arch/arm64/mm/fixmap.c | 24 +++- > arch/arm64/mm/hugetlbpage.c | 10 +- > arch/arm64/mm/kasan_init.c | 14 +- > arch/arm64/mm/mmu.c | 65 +++++----- > arch/arm64/mm/pageattr.c | 8 +- > arch/arm64/mm/proc.S | 25 +++- > arch/arm64/mm/trans_pgd.c | 14 +- > include/linux/pgtable.h | 25 ++++ > mm/huge_memory.c | 4 +- > mm/memory.c | 25 ++-- > mm/migrate.c | 2 +- > mm/mmap.c | 2 +- > 24 files changed, 624 insertions(+), 169 deletions(-) > > -- > 2.43.0 >