From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB20BCD4F5B for ; Tue, 19 May 2026 13:34:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=igLXJd4fTn7BrUWoEo6/WCNhTtAf6rW8Mq0yK1dWozI=; b=rN/vETnqav6joqrD22blc0Lzir HcVOtr3vYbiWh3J1q4wsjeDHcImBJdM1ZMMYm+avQTJany4zEruqBNMY+4z64lAC+F8yXbUVfgoVi 7IqbclEFHhPmTYJ7/5LGCnGckfg9TqdxnWqWtAmO+Ul09EytNRbHRGzKnBVCjBgPS05dI8waWHstY d7gJpYS5AEt8pDekA033jaX1jFpqEKcw4d5WIpSLfae/bFaskgAnpTKG1p6yORJz79IxzM/lN9qxk +MlAylpwQ0+5cqkK1LDXehdRTKDz8uFCjY1sRjT7FH8aWMPcgkcdjZCTOcrUnRRE5qGp/LZUpGwDF Tbxe0srw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPKap-00000001g4m-1HdP; Tue, 19 May 2026 13:34:43 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPKam-00000001g3e-3u6x; Tue, 19 May 2026 13:34:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id EFCEA402FC; Tue, 19 May 2026 13:34:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6AA2C2BCC6; Tue, 19 May 2026 13:34:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779197679; bh=jZ9eiUfdecTYmnNTglbe4v4suLmPNtkaKYThIKqcEms=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DDTfph8DoNxs0r7uOMyzlcGYs56uMr1Oz4qj1hQo+aMCMvqfCj5wWWtFFuzaXr20G yOrNWL62DjLdDDlRviIJLyzu7SLkguP5tlMqTJ2WQIVJWPTnA86I5YPVIip7/TFWQ9 FfrnD4ESweJw+hFMJuTvrUpCxGuU6H47B2CfWi24NlBhbxtC8GhtBFvViN70YQOnHi 8Ne2TKTGwa05BOzhDmg5PqaztRqe9W0pUc1pz8Dwx2hEmHekf3M22g1B0bmBSyTO4M LSoTbzYoydCPM/mKQeRc4B3bTUv/T+VH4Q+CW5WrMmkFxAUx1H1A4n9+s9VNkHK0yl xbNoiM2Z8+puA== Date: Tue, 19 May 2026 14:34:29 +0100 From: Lorenzo Stoakes To: Barry Song Cc: Yang Shi , Matthew Wilcox , surenb@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, david@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, mhocko@suse.com, jack@suse.cz, pfalcato@suse.de, wanglian@kylinos.cn, chentao@kylinos.cn, lianux.mm@gmail.com, kunwu.chan@gmail.com, liyangouwen1@oppo.com, chrisl@kernel.org, kasong@tencent.com, shikemeng@huaweicloud.com, nphamcs@gmail.com, bhe@redhat.com, youngjun.park@lge.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, Nanzhe Zhao Subject: Re: [PATCH v2 0/5] mm: reduce mmap_lock contention and improve page fault performance Message-ID: References: <20260430040427.4672-1-baohua@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260519_063441_059978_663700C6 X-CRM114-Status: GOOD ( 61.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 19, 2026 at 07:07:37PM +0800, Barry Song wrote: > On Tue, May 19, 2026 at 5:21 AM Yang Shi wrote: > > > > On Sun, May 17, 2026 at 1:45 AM Barry Song wrote: > > > > > > On Sat, May 2, 2026 at 1:58 AM Matthew Wilcox wrote: > > > > > > > > On Sat, May 02, 2026 at 01:44:34AM +0800, Barry Song wrote: > > > > > On Fri, May 1, 2026 at 10:57 PM Matthew Wilcox wrote: > > > > > > > > > > > > On Fri, May 01, 2026 at 06:49:58AM +0800, Barry Song wrote: > > > > > > > 1. There is no deterministic latency for I/O completion. It depends on > > > > > > > both the hardware and the software stack (bio/request queues and the > > > > > > > block scheduler). Sometimes the latency is short; at other times it can > > > > > > > be quite long. In such cases, a high-priority thread performing operations > > > > > > > such as mprotect, unmap, prctl_set_vma, or madvise may be forced to wait > > > > > > > for an unpredictable amount of time. > > > > > > > > > > > > But does that actually happen? I find it hard to believe that thread A > > > > > > unmaps a VMA while thread B is in the middle of taking a page fault in > > > > > > that same VMA. mprotect() and madvise() are more likely to happen, but > > > > > > it still seems really unlikely to me. > > > > > > > > > > It doesn’t have to involve unmapping or applying mprotect to > > > > > the entire VMA—just a portion of it is sufficient. > > > > > > > > Yes, but that still fails to answer "does this actually happen". How much > > > > performance is all this complexity in the page fault handler buying us? > > > > If you don't answer this question, I'm just going to go in and rip it > > > > all out. > > > > > > > > > > Hi Matthew (and Lorenzo, Jan, and anyone else who may be > > > waiting for answers), > > > > > > As promised during LSF/MM/BPF, we conducted thorough > > > testing on Android phones to determine whether performing > > > I/O in `filemap_fault()` can block `vma_start_write()`. > > > I wanted to give a quick update on this question. > > > > > > Nanzhe at Xiaomi created tracing scripts and ran various > > > applications on Android devices with I/O performed under > > > the VMA lock in `filemap_fault()`. We found that: > > > > > > 1. There are very few cases where unmap() is blocked by > > > page faults. I assume this is due to buggy user code > > > or poor synchronization between reads and unmap(). > > > So I assume it is not a problem. > > > > > > 2. We observed many cases where `vma_start_write()` > > > is blocked by page-fault I/O in some applications. > > > The blocking occurs in the `dup_mmap()` path during > > > fork(). > > > > > > With Suren's commit fb49c455323ff ("fork: lock VMAs of > > > the parent process when forking"), we now always hold > > > `vma_write_lock()` for each VMA. Note that the > > > `mmap_lock` write lock is also held, which could lead to > > > chained waiting if page-fault I/O is performed without > > > releasing the VMA lock. > > > > > > My gut feeling is that Suren's commit may be overshooting, > > > so my rough idea is that we might want to do something like > > > the following (we haven't tested it yet and it might be > > > wrong): > > > > > > diff --git a/mm/mmap.c b/mm/mmap.c > > > index 2311ae7c2ff4..5ddaf297f31a 100644 > > > --- a/mm/mmap.c > > > +++ b/mm/mmap.c > > > @@ -1762,7 +1762,13 @@ __latent_entropy int dup_mmap(struct mm_struct > > > *mm, struct mm_struct *oldmm) > > > for_each_vma(vmi, mpnt) { > > > struct file *file; > > > > > > - retval = vma_start_write_killable(mpnt); > > > + /* > > > + * For anonymous or writable private VMAs, prevent > > > + * concurrent CoW faults. > > > + */ > > > + if (!mpnt->vm_file || (!(mpnt->vm_flags & VM_SHARED) && > > > + (mpnt->vm_flags & VM_WRITE))) > > > + retval = vma_start_write_killable(mpnt); > > > if (retval < 0) > > > goto loop_out; > > > if (mpnt->vm_flags & VM_DONTCOPY) { > > > > Maybe a little bit off topic. This is an interesting idea. It seems > > possible we don't have to take vma write lock unconditionally. IIUC > > the write lock is mainly used to serialize against page fault and > > madvise, right? I got a crazy idea off the top of my head. We may be > > able to just take vma write lock iff vma->anon_vma is not NULL. > > > > First of all, write mmap_lock is held, so the vma can't go or be > > changed under us. > > > > Secondly, if vma->anon_vma is NULL, it basically means either no page > > fault happened or no cow happened, so there is no page table to copy, > > this is also what copy_page_range() does currently. So we can shrink > > the critical section to: > > > > if (vma->anon_vma) { > > vma_start_write_killable(src_vma); > > anon_vma_fork(dst_vma, src_vma); > > copy_page_range(dst_vma, src_vma); > > } > > > > But page fault can happen before write mmap_lock is taken, when we > > check vma->anon_vma, it is possible it has not been set up yet. But it > > seems to be equivalent to page fault after fork and won't break the > > semantic. > > Re-reading Suren's commit log for fb49c455323ff8 > ("fork: lock VMAs of the parent process when forking"), > it seems that vm_start_write() is used to protect > against a race where anon_vma changes from NULL to > non-NULL during fork. In that scenario, we hold the > mmap_lock write lock, but not vma_start_write(), so a > concurrent anon_vma_prepare() could still install an > anon_vma. > > " A concurrent page fault on a page newly marked read-only by the page > copy might trigger wp_page_copy() and a anon_vma_prepare(vma) on the > source vma, defeating the anon_vma_clone() that wasn't done because the > parent vma originally didn't have an anon_vma, but we now might end up > copying a pte entry for a page that has one. > " > > If that is the case, then your change does not work. > > Nowadays, nobody calls anon_vma_prepare(vma) directly. I see callers? Am I imagining them? :) https://elixir.bootlin.com/linux/v7.0.9/A/ident/anon_vma_prepare > Instead, vmf_anon_prepare() is used, and we always > require the mmap_lock read lock before calling > __anon_vma_prepare(). As a result, anon_vma cannot > transition from NULL to non-NULL during fork. Right, yes the mmap read lock is required for that. > > So the original race condition has effectively > disappeared. Err the page tables? All the other cases which require page table copying? Concurrent faults mean that copy_page_range() and faulting with vma->anon_vma _or_ any of the multiple cases mentioned elsewhere. And who knows what else serialises on that. > > You also mentioned the madvise() case. If I understand > correctly, madvise() should take mmap_lock before > modifying anon_vma. Only some parts of madvise() can > support per-VMA locking. Therefore, we probably do not > need: > > if (vma->anon_vma) { > vma_start_write_killable(src_vma); > ... > } I like how you hand wave the VMA lock operations in madvise() :) (Maybe) guard regions being present cause page tables to be copied, they're installed under VMA (read) lock, and can race now. And it sets traps for future changes - introducing more horrible edge case race conditions in fork is just a big nope nope nope. This isn't an area to play around in. > > > > > Anyway, just a crazy idea, I may miss some corner cases. > > To me, it seems that we could remove vma_start_write() > entirely now. Or is that an even crazier idea? As above that'd be totally broken. NAK. > > Thanks > Barry Thanks, Lorenzo