From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E63C4CD6E55 for ; Mon, 1 Jun 2026 19:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=elXuand+n/viDgsywhdjTLL4Sq6m2LCvhd5nnF4PGAE=; b=MlJnp55hZD9l2AL3MNhD7pOpMe QcuhA4OidnNTK+ZZAHTmpMdpoh0iq4v0UR50V4oAZ5sJHQiXA8jrYtm0O9MSf5gn5rdo4+2JlxFM4 VId5f3erOb68cqcsq7LtVGBKqpz9jQytIv4ecTf8As6bgjUdFNLgU9LSIdD/ToCPSRwXogsxfIPEJ A5BEeKpYJap7SvL2CusKzVQiWUeX8iQcDSge+Yufp9VNymuWt1I6Zw+Iaplv+3QvtQU0C4Ytcwpaj JZsLcRtTQ3qEIDT2MWTXtM9zueI3OJM9I1LpWVt78kalR7zMAgMkoCT1YiFdLzRbEi3p5uiGshqym NTpIfG3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wU80R-0000000BhJa-1EQQ; Mon, 01 Jun 2026 19:08:59 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wU80P-0000000BhJ4-3BOl for linux-arm-kernel@lists.infradead.org; Mon, 01 Jun 2026 19:08:58 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 13BFC40E2B; Mon, 1 Jun 2026 19:08:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C29501F00898; Mon, 1 Jun 2026 19:08:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780340937; bh=elXuand+n/viDgsywhdjTLL4Sq6m2LCvhd5nnF4PGAE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=mD5ROBonnzUew3QCRjyhq+2GxLjZyXfTZHazuIgIgTKTCtPXlSpXOq2KTubw6Bafo QQ1/jINkJySUG5j5QeHnxk/9GsW+g/QRB+iU1nS/HrWUqoF2M8w8e2wsi2vjCPiT0D IltrUTYgiyn+GTxaIEx9FU9Ea/eDBFHTyLK3rkARAprsPrUUyD+ikKTg4YPS2Q5zvy L7kXogwHSq5F9+C1bdWYar3dIK7rmQLvmiqi3V/2hFPoi1jSY13/NNiRUePLmgpk7M YbbaeYe2Mu7Eg6aiv4Z4jrVem1AfqSuLYs0YAHTyHbvaR2zg6j15n64S0/oLfFMzD6 Ik1b337U8R9Bg== Date: Mon, 1 Jun 2026 12:08:55 -0700 From: Oliver Upton To: Hyunwoo Kim Cc: maz@kernel.org, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, kees@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: vgic-its: Drop the translation cache reference only for the erased entry Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260601_120857_840175_88D180AC X-CRM114-Status: GOOD ( 28.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Hyunwoo, Nice find. On Mon, Jun 01, 2026 at 11:53:26PM +0900, Hyunwoo Kim wrote: > vgic_its_invalidate_cache() walks the per-ITS translation cache with > xa_for_each() and drops the cache's reference on each entry with > vgic_put_irq(). It puts the iterated pointer, though, rather than the > value returned by xa_erase(). > > The function is called from contexts that do not exclude one another: the > ITS command handlers hold its_lock, the GITS_CTLR write path holds > cmd_lock, and the path that clears EnableLPIs in a redistributor's > GICR_CTLR holds neither. Two or more of them can drain the same cache > concurrently, and if each one observes the same entry, erases it and then > puts it, the single reference the cache holds on that entry is dropped > more than once. The entry can then be freed while an ITE still maps it. > > xa_erase() is atomic and returns the previous entry, so put only the entry > that this context actually removed. The cache reference is then dropped > exactly once per entry even when the invalidations run concurrently, and > the behavior is unchanged when only one context runs. Next time: Cc: stable@vger.kernel.org > Fixes: 8201d1028caa ("KVM: arm64: vgic-its: Maintain a translation cache per ITS") > Signed-off-by: Hyunwoo Kim > --- > arch/arm64/kvm/vgic/vgic-its.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/vgic/vgic-its.c b/arch/arm64/kvm/vgic/vgic-its.c > index 1d7e5d560af4..1e3706ac3b8e 100644 > --- a/arch/arm64/kvm/vgic/vgic-its.c > +++ b/arch/arm64/kvm/vgic/vgic-its.c > @@ -597,8 +597,10 @@ static void vgic_its_invalidate_cache(struct vgic_its *its) > unsigned long idx; > > xa_for_each(&its->translation_cache, idx, irq) { > - xa_erase(&its->translation_cache, idx); > - vgic_put_irq(kvm, irq); > + /* Only the context that erases the entry drops its cache ref. */ > + irq = xa_erase(&its->translation_cache, idx); > + if (irq) > + vgic_put_irq(kvm, irq); > } > } This definitely works but TBH I'd rather just plug the subtle race and do invalidations behind the its_lock since it already nests with the cmd_lock. Could you give this a spin? diff --git a/arch/arm64/kvm/vgic/vgic-its.c b/arch/arm64/kvm/vgic/vgic-its.c index 2ea9f1c7ebcd..b2225da212ec 100644 --- a/arch/arm64/kvm/vgic/vgic-its.c +++ b/arch/arm64/kvm/vgic/vgic-its.c @@ -596,6 +596,8 @@ static void vgic_its_invalidate_cache(struct vgic_its *its) struct vgic_irq *irq; unsigned long idx; + lockdep_assert_held(&its->its_lock); + xa_for_each(&its->translation_cache, idx, irq) { xa_erase(&its->translation_cache, idx); vgic_put_irq(kvm, irq); @@ -607,17 +609,16 @@ void vgic_its_invalidate_all_caches(struct kvm *kvm) struct kvm_device *dev; struct vgic_its *its; - rcu_read_lock(); + guard(mutex)(&kvm->lock); - list_for_each_entry_rcu(dev, &kvm->devices, vm_node) { + list_for_each_entry(dev, &kvm->devices, vm_node) { if (dev->ops != &kvm_arm_vgic_its_ops) continue; its = dev->private; + guard(mutex)(&its->its_lock); vgic_its_invalidate_cache(its); } - - rcu_read_unlock(); } int vgic_its_resolve_lpi(struct kvm *kvm, struct vgic_its *its, @@ -1725,8 +1726,10 @@ static void vgic_mmio_write_its_ctlr(struct kvm *kvm, struct vgic_its *its, goto out; its->enabled = !!(val & GITS_CTLR_ENABLE); - if (!its->enabled) + if (!its->enabled) { + guard(mutex)(&its->its_lock); vgic_its_invalidate_cache(its); + } /* * Try to process any pending commands. This function bails out early -- Thanks, Oliver