Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Seth Forshee <sforshee@nvidia.com>
To: Sudeep Holla <sudeep.holla@kernel.org>
Cc: Sebastian Ene <sebastianene@google.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] firmware: arm_ffa: Fall back to minimum buffer size if RXTX_MAP fails
Date: Tue, 2 Jun 2026 11:21:33 -0500	[thread overview]
Message-ID: <ah8DDVyxO0vNH-nb@omni-lfn-logwh> (raw)
In-Reply-To: <20260602-defiant-perfect-bustard-cbf22e@sudeepholla>

On Tue, Jun 02, 2026 at 04:48:11PM +0100, Sudeep Holla wrote:
> On Mon, Jun 01, 2026 at 03:45:12PM -0500, Seth Forshee wrote:
> > FFA_FEATURES only supports a maximum size value for RXTX_MAP in v1.2+.
> > Older implementations may still reject larger sizes, which can happen
> > when the minimum size is rounded up to the page size when PAGE_SIZE >
> > 4K.
> > 
> > Fall back to the minimum size when RXTX_MAP fails with
> > INVALID_PARAMETERS to fix the regression on these platforms. This also
> > has the side effect of falling back for v1.2+ with a maximum of 0 (i.e.
> > no maximum), where the rounded-up value isn't expected to be rejected,
> > but there's no harm in retrying with a smaller size and it might even be
> > of benefit for a non-compliant SPMC.
> > 
> 
> Is this needed on any of your platforms ? I don't want to push a solution
> or fallback/workaround if there are no users for it.

Yes, we have platforms for which commit 83210251fd70 causes RXTX_MAP
failures with page sizes larger than 4K.

Thanks,
Seth


  reply	other threads:[~2026-06-02 16:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 20:45 [PATCH 0/2] firmware: arm_ffa: Fix RXTX_MAP buffer size regressions Seth Forshee
2026-06-01 20:45 ` [PATCH 1/2] firmware: arm_ffa: Honor maximum RX/TX buffer size Seth Forshee
2026-06-02 15:56   ` Sudeep Holla
2026-06-02 16:12     ` Seth Forshee
2026-06-02 16:27       ` Sudeep Holla
2026-06-02 17:05         ` Seth Forshee
2026-06-02 21:58           ` Seth Forshee
2026-06-01 20:45 ` [PATCH 2/2] firmware: arm_ffa: Fall back to minimum buffer size if RXTX_MAP fails Seth Forshee
2026-06-02 15:48   ` Sudeep Holla
2026-06-02 16:21     ` Seth Forshee [this message]
2026-06-02 16:29       ` Sudeep Holla
2026-06-02 17:12         ` Seth Forshee
2026-06-02 16:51 ` [PATCH 0/2] firmware: arm_ffa: Fix RXTX_MAP buffer size regressions Sudeep Holla
2026-06-02 17:19   ` Seth Forshee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ah8DDVyxO0vNH-nb@omni-lfn-logwh \
    --to=sforshee@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sebastianene@google.com \
    --cc=sudeep.holla@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox