From: Nicolin Chen <nicolinc@nvidia.com>
To: Qinxin Xia <xiaqinxin@huawei.com>
Cc: <robin.murphy@arm.com>, <will@kernel.org>, <jpb@kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <iommu@lists.linux.dev>,
<wangzhou1@hisilicon.com>, <prime.zeng@hisilicon.com>,
<fanghao11@huawei.com>, <jonathan.cameron@huawei.com>,
<wuyifan50@huawei.com>, <linuxarm@huawei.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] iommu/arm-smmu-v3: Add Stream Table Entry display to debugfs
Date: Tue, 26 May 2026 19:43:06 -0700 [thread overview]
Message-ID: <ahZaOpADaIep+lWs@Asurada-Nvidia> (raw)
In-Reply-To: <ahZUjmpkB8puCNds@Asurada-Nvidia>
On Tue, May 26, 2026 at 07:18:54PM -0700, Nicolin Chen wrote:
> On Wed, May 20, 2026 at 02:37:09PM +0800, Qinxin Xia wrote:
> > +int arm_smmu_debugfs_create_stream_table(struct arm_smmu_device *smmu,
> > + struct device *dev)
> > +{
> > + struct dentry *stream_dir, *dev_dir;
> > + struct arm_smmu_master *master;
> > + struct ste_context *ctx;
> > + char name[64];
> > + u32 sid;
> > + int i;
> [...]
> > + master = dev_iommu_priv_get(dev);
> > + if (!master || !master->num_streams)
> > + return -ENODEV;
>
> The caller has master. Why not just pass it in? Then, you would
> have master->smmu and master->dev.
I forgot that this is to fence against concurrent device unplug.
Maybe add a note for the reason of having smmu and dev instead?
Nicolin
next prev parent reply other threads:[~2026-05-27 2:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 10:17 [RFC PATCH v2 0/5] Add debugfs support for ARM SMMUv3 Qinxin Xia
2026-03-28 10:17 ` [RFC PATCH v2 1/5] iommu/arm-smmu-v3: Add basic debugfs framework Qinxin Xia
2026-03-30 10:46 ` Nicolin Chen
2026-04-02 3:50 ` Qinxin Xia
2026-03-28 10:17 ` [RFC PATCH v2 2/5] iommu/arm-smmu-v3: Add register display to debugfs Qinxin Xia
2026-03-30 11:25 ` Nicolin Chen
2026-03-28 10:17 ` [RFC PATCH v2 3/5] iommu/arm-smmu-v3: Add Stream Table Entry " Qinxin Xia
2026-04-04 5:43 ` Nicolin Chen
2026-03-28 10:17 ` [RFC PATCH v2 4/5] iommu/arm-smmu-v3: Add device symlink in stream table debugfs Qinxin Xia
2026-03-28 10:17 ` [RFC PATCH v2 5/5] iommu/arm-smmu-v3: Add Context Descriptor display to debugfs Qinxin Xia
2026-05-20 6:37 ` [PATCH 0/5] Add debugfs support for ARM SMMUv3 Qinxin Xia
2026-05-20 6:37 ` [PATCH 1/5] iommu/arm-smmu-v3: Add basic debugfs framework Qinxin Xia
2026-05-27 0:41 ` Nicolin Chen
2026-05-20 6:37 ` [PATCH 2/5] iommu/arm-smmu-v3: Add register display to debugfs Qinxin Xia
2026-05-27 1:28 ` Nicolin Chen
2026-05-20 6:37 ` [PATCH 3/5] iommu/arm-smmu-v3: Add Stream Table Entry " Qinxin Xia
2026-05-27 2:18 ` Nicolin Chen
2026-05-27 2:43 ` Nicolin Chen [this message]
2026-05-20 6:37 ` [PATCH 4/5] iommu/arm-smmu-v3: Add device symlink in stream table debugfs Qinxin Xia
2026-05-20 6:37 ` [PATCH 5/5] iommu/arm-smmu-v3: Add Context Descriptor display to debugfs Qinxin Xia
2026-05-27 2:40 ` Nicolin Chen
2026-05-27 0:07 ` [PATCH 0/5] Add debugfs support for ARM SMMUv3 Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahZaOpADaIep+lWs@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=fanghao11@huawei.com \
--cc=iommu@lists.linux.dev \
--cc=jonathan.cameron@huawei.com \
--cc=jpb@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=prime.zeng@hisilicon.com \
--cc=robin.murphy@arm.com \
--cc=wangzhou1@hisilicon.com \
--cc=will@kernel.org \
--cc=wuyifan50@huawei.com \
--cc=xiaqinxin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox