Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
	John Garry <john.g.garry@oracle.com>,
	Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
	Leo Yan <leo.yan@linux.dev>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ian Rogers <irogers@google.com>, Leo Yan <leo.yan@arm.com>
Subject: Re: [PATCH] perf arm-spe: Don't warn about the discard bit if it doesn't exist
Date: Fri, 29 May 2026 21:21:36 -0300	[thread overview]
Message-ID: <ahotkEL09FARMsRB@x1> (raw)
In-Reply-To: <bf58d60f-1483-4832-9424-5e85e0e5f943@linaro.org>

On Fri, May 29, 2026 at 10:42:34AM +0100, James Clark wrote:
> On 13/05/2026 1:55 pm, Ian Rogers wrote:
> > On Wed, May 13, 2026 at 3:20 AM Leo Yan <leo.yan@arm.com> wrote:
> > > On Fri, Apr 10, 2026 at 12:05:12PM +0100, James Clark wrote:
> > > > Opening an SPE event shows a warning that doesn't concern the user:

> > > >    $ perf record -e arm_spe
> > > >    Unknown/empty format name: discard

> > > > Perf only wants to know if the discard bit is set for configuring the
> > > > event, not in response to anything the user has done. Fix it by adding
> > > > another helper that returns if a config bit exists without warning.

> > > > We should probably keep the warning in evsel__get_config_val() to avoid
> > > > having every caller having to do it, and most format bits should never
> > > > be missing.

> > > > Add a test for the new helper. Rename the parent test function to be
> > > > more generic rather than adding a new one as it requires a lot of
> > > > boilerplate.

> > > > Signed-off-by: James Clark <james.clark@linaro.org>

> > > Reviewed-by: Leo Yan <leo.yan@arm.com>

> > Reviewed-by: Ian Rogers <irogers@google.com>

> Ping, thanks

Thanks, applied to perf-tools-next, for v7.2.

- Arnaldo


      reply	other threads:[~2026-05-30  0:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 11:05 [PATCH] perf arm-spe: Don't warn about the discard bit if it doesn't exist James Clark
2026-05-13 10:20 ` Leo Yan
2026-05-13 12:55   ` Ian Rogers
2026-05-29  9:42     ` James Clark
2026-05-30  0:21       ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahotkEL09FARMsRB@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=leo.yan@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox