From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8CD6CD8CA4 for ; Tue, 9 Jun 2026 13:47:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yo3zYdZKSWJzNYV+L+iKq++E9ZMSoh1N5rmIiAtAG8s=; b=xMjkEnK9qDmxZfxdnpfjrhWS3d sjNzm5HTGfIAPuMr6uV5r6Ng70faUwMZsS+uTZTlRuownuQEKa1aGK+5buCiUkEs4lwvh9USSP1vw LagI6f+ueAooEQBUJ4RqtKkfLxg4OOjUTZSo7ZrdxOSp5vQWgq4t1jg/eEYTER9e+AQ/P7ByJmcrf 9jfxlBggPt4YELsNRz3/m7Ae2RT+PVknFSDuinyYBBqt/Hk55KZBAY+feifAaJAACATcDzvJbCI+I dtHU5w5t30eNQ8CUvO27gkrGRxBVzOFLrTRGledkLPuGxnZGonHOdRu/IIqMsIMc2NAHWVYCUlSPH rl9nm6YQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWwn7-00000005hSP-40M4; Tue, 09 Jun 2026 13:46:54 +0000 Received: from leonov.paulk.fr ([185.233.101.22]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWwn2-00000005hRc-189O for linux-arm-kernel@lists.infradead.org; Tue, 09 Jun 2026 13:46:51 +0000 Received: from laika.paulk.fr (12.234.24.109.rev.sfr.net [109.24.234.12]) by leonov.paulk.fr (Postfix) with ESMTPS id F0BC03700273 for ; Tue, 9 Jun 2026 13:46:42 +0000 (UTC) Received: by laika.paulk.fr (Postfix, from userid 65534) id 10F2CB43C09; Tue, 9 Jun 2026 13:46:41 +0000 (UTC) Received: from collins (unknown [192.168.1.1]) by laika.paulk.fr (Postfix) with ESMTPSA id 73E79B43C04; Tue, 9 Jun 2026 13:46:41 +0000 (UTC) Date: Tue, 9 Jun 2026 15:46:39 +0200 From: Paul Kocialkowski To: Chen-Yu Tsai Cc: Krzysztof Kozlowski , soc@kernel.org, Jernej Skrabec , Samuel Holland , linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [GIT PULL] Allwinner DT Changes for 7.2 Message-ID: References: <20260609-mighty-excellent-shoebill-04d7fa@quoll> <98f3e864-3a9e-4f96-a633-0c0053ec35fb@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LIBKS0aWDw24Pb3i" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260609_064648_719947_0CD701F1 X-CRM114-Status: GOOD ( 35.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --LIBKS0aWDw24Pb3i Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Le Tue 09 Jun 26, 22:26, Chen-Yu Tsai a =C3=A9crit : > On Tue, Jun 9, 2026 at 10:18=E2=80=AFPM Krzysztof Kozlowski wrote: > > > > On 09/06/2026 14:38, Chen-Yu Tsai wrote: > > > On Tue, Jun 9, 2026 at 8:51=E2=80=AFPM Krzysztof Kozlowski wrote: > > >> > > >> On 09/06/2026 13:48, Chen-Yu Tsai wrote: > > >>> On Tue, Jun 9, 2026 at 8:43=E2=80=AFPM Krzysztof Kozlowski wrote: > > >>>> > > >>>> On Tue, Jun 02, 2026 at 03:09:52AM +0800, Chen-Yu Tsai wrote: > > >>>>> The following changes since commit 254f49634ee16a731174d2ae34bc50= bd5f45e731: > > >>>>> > > >>>>> Linux 7.1-rc1 (2026-04-26 14:19:00 -0700) > > >>>>> > > >>>>> are available in the Git repository at: > > >>>>> > > >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git= tags/sunxi-dt-for-7.2 > > >>>>> > > >>>>> for you to fetch changes up to 44cf19e41c769720750dbb8752aca75c24= 7e565f: > > >>>>> > > >>>>> arm64: dts: allwinner: a523: add gpadc node (2026-05-25 05:02:5= 8 +0800) > > >>>>> > > >>>>> > > >>>>> As mentioned in the tag, this pull request contains a change that= should > > >>>>> be shared between the soc and clk trees. However since I don't ha= ve any > > >>>>> clk changes to send this cycle, I think it can just go through th= e soc > > >>>>> tree without any issues. > > >>>> > > >>>> But the clock driver change cannot be in the DTS branch. This shou= ld go > > >>>> via clock tree even if it is one change. And definitely not via DTS > > >>>> branch. > > >>> > > >>> It is a shared change, because it moves two symbols from the driver= 's > > >>> private header to the public DT binding header. I don't see how this > > >>> can go through just the clk tree when one of the subsequent patches > > >>> uses those new symbols. > > >>> > > >>> "clk: sunxi-ng: v3s: Export MBUS and DRAM clocks to the public head= er" > > >>> is needed by "ARM: dts: sun8i: v3s: Add mbus node to represent the > > >>> interconnect". > > >>> > > >>> The other way to go about this is to use raw numbers first, then > > >>> another patch in the next cycle to switch the numbers to actual > > >>> macros. IMHO not worth the churn and headache. > > >> > > >> You can have a duplicated define. > > > > > > I honestly did not know that it worked. > > > > > > However, splitting what is effectively one logical change (*move* > > > something) into two patches just to be able to merge them through two > > > separate trees still seems wrong to me. > > > > It is not really one logical change. Defining a new ABI (binding header > > define) is considered one change. Merging binding change into driver > > commit breaks rule of splitting bindings from implementation. > > > > Second rule is that DTS branch CANNOT take driver changes. So if you do > > not want to adhere to the above rule you still cannot combine it into > > DTS branch. >=20 > Very well. I will drop the two changes and send a revised pull request. >=20 > Paul, can you redo the clk changes as requested in the next cycle? Sure, so if I understand correctly, commit: clk: sunxi-ng: v3s: Export MBUS and DRAM clocks to the public headersunxi should be split into two, one adding the definitions to the dt-bindings headers first and a second one removing them from the clk driver? Can it still make it for 7.2? All the best, Paul --=20 Paul Kocialkowski, Independent contractor - sys-base - https://www.sys-base.io/ Free software developer - https://www.paulk.fr/ Expert in multimedia, graphics and embedded hardware support with Linux. --LIBKS0aWDw24Pb3i Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEAbcMXZQMtj1fphLChP3B6o/ulQwFAmooGT8ACgkQhP3B6o/u lQze5hAAh4nb0JtdBQTcb6rqE0JuYghcRY3WgOq9a+D58szlF96Vmt8kVC41vjXe lH6Q3THbnM6nemQW/N6z6Nj8cZerQ6lgZF8d6MkjGIbvvrHzazajOY2BiAWYqurz g87lGjeYnIoqMrwM2c6uAbJL59QqPSvYBUVHhNuthh8dq57NvToZ4rHGOd+1qU6X Fc8IyiduL1p11BKAGiFxSsAaeauvwU/YDViT5GU5qAeLaxR3vud7N/PaGqlyNfsz 7NaCEpMUFZ1jZRGXebVkc680JjDWgjNwiF2gGN1pM5DXqPiKD8EB394ylb1lgZ44 +Iw9rAJpdgwgCvZ1MhBxHDbyrnIptkn6WpYGn5DEFhlwiuHztCEfgSgE6M34mzv0 jNn5+4iHAe8ewEH5FJXqy7xgFtbnKEcJLPUOW3MXe6hG9UyEBKZFqyl8bk6rPVPU 9TVKH3NsseD3m0KnZsL5j/Ljs0ySTWU5pm2cvy/+sy0vckIzkJT5z1RAMOauTyj/ bXceU2ZgcNm8e4pJ7fz6np7RrSDsDF53Jn2mPWFIUr/CLP9B4t4GuHiQE0yUsChf SejY/kPJx2/Hpg2gwuIhuYwHw8NUZ+khe0rxstVqV7rBJVcK5YZU7JM3WKwrrEzh 4KcHRtdA9x+UFc2/w7PycdePOH695+fZ5neoLHiR77A0r8c7nII= =+eke -----END PGP SIGNATURE----- --LIBKS0aWDw24Pb3i--