From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E01A3CD8C9D for ; Thu, 11 Jun 2026 20:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=crdsBjE7ZqbatQyB5pSRoEZDHX8kp0Be7BEVWnCPbMw=; b=gcIv6NAWTfO+ZzZNn1JDpdkwqb JEdAPWzQnhPaQydBqIWXFhc7LmvrLtBhnPH8RNfO88g0hQU+TdbxQiYWwzOGE7dSFfoUAguXD27xs IU148+DvXxCGwElWxjuQhCRZGBcqX1NZAdU4j3g6s+cSDq5Y0EsdKsq4yCuPMpObkFD2mA6iZjXDU esen1kCBnl2BGF51bkyAcY/VnH9TsUuv4600nOBHToz2DkbIlKw/i5x/+vxYzoxuWkroQyViMcQ6B XzRf5r29SrQAPhH9SDB/pb30I+Vgwv68aUl9oHDYCsUf/ILd/kB28KJjD9aj0XLGriz9nwN+37Q1z XLX+wukA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXkYH-00000009urw-1Sm1; Thu, 11 Jun 2026 18:54:53 +0000 Received: from mgamail.intel.com ([192.198.163.8]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXkYE-00000009ur7-2h0i; Thu, 11 Jun 2026 18:54:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781204091; x=1812740091; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=T54buALKRrnV/NkHhNnF9DYrF9mnjHeDsPLsjZLccVc=; b=K0+ZBT0nkOFcS8gaMxOMMP0Lb9pTVV6zWJ2CiHfsodGaZonTK8th1/Wk 8ipifrAzbV/3CDmcJ8UwAGAslH+7S9JQks4cMWh5H9Jdi5nX0ItoAp4+T sewGv0VX/vbAxt3rbzgcF1J1gvmVARqxyXIHSLlBKgVgHCqIhJRg6IJfo psXOfnWHHb/paYKSSHVKfenMWg1rYfm0Ojv1ozYt9BbgJV/TDODTppeDx +vRWk1ABkCR++wQ6IFuARVqLQf+dQWasE9i49YwVz0cJavUMglzA6rrfO l8ysO56MxM69OCHGU4Pcm7upaxxvwUVg0BVn4U7/+CwEMCfnHvYuKoAYK A==; X-CSE-ConnectionGUID: qVwU5afFS0CGPSvoA0EYsw== X-CSE-MsgGUID: shSRIcTjRhGJaf9ubAiRpQ== X-IronPort-AV: E=McAfee;i="6800,10657,11813"; a="99606448" X-IronPort-AV: E=Sophos;i="6.24,199,1774335600"; d="scan'208";a="99606448" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2026 11:54:50 -0700 X-CSE-ConnectionGUID: 8c6VWJAfS46EAVViB8yt6A== X-CSE-MsgGUID: zgLRcfSXSzCuoVc837orwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,199,1774335600"; d="scan'208";a="246654990" Received: from ettammin-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.244.123]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2026 11:54:44 -0700 Date: Thu, 11 Jun 2026 21:54:41 +0300 From: Andy Shevchenko To: Heikki Krogerus Cc: Bartosz Golaszewski , Greg Kroah-Hartman , Daniel Scally , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Alan Stern , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Chen-Yu Tsai Subject: Re: [PATCH v2 05/16] usb: hub: Associate port@ fwnode with USB port device Message-ID: References: <20260610084053.2059858-1-wenst@chromium.org> <20260610084053.2059858-6-wenst@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260611_115450_693770_D6D28D1C X-CRM114-Status: GOOD ( 31.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 11, 2026 at 06:48:56PM +0300, Heikki Krogerus wrote: > On Thu, Jun 11, 2026 at 11:35:13AM +0200, Bartosz Golaszewski wrote: > > On Thu, Jun 11, 2026 at 10:37 AM Andy Shevchenko > > wrote: > > > On Thu, Jun 11, 2026 at 04:20:58AM -0400, Bartosz Golaszewski wrote: > > > > On Wed, 10 Jun 2026 16:16:12 +0200, Andy Shevchenko > > > > said: > > > > > On Wed, Jun 10, 2026 at 04:40:39PM +0800, Chen-Yu Tsai wrote: > > > > >> When a USB hub port is connected to a connector in a firmware node > > > > >> graph, the port itself has a node in the graph. > > > > >> > > > > >> Associate the port's firmware node with the USB port's device, > > > > >> usb_port::dev. This is used in later changes for the M.2 slot power > > > > >> sequencing provider to match against the requesting port. > > > > > > > > > > Okay, would this affect ACPI-based systems? if so, how? > > > > > Can you elaborate on that, please? > > > > > > > > Is it possible that there's an ACPI device node associated with the port like > > > > on some DT systems? I don't think so and there should be no impact IMO but I > > > > also don't know enough about ACPI. > > There are device nodes for the USB ports in ACPI, and I think they get > always assigned in drivers/usb/core/usb-acpi.c. > > > > The API is agnostic. There is a possibility to have software nodes associated > > > with the port. I think the best is to be sure that ACPI-aware people who are > > > experts in USB will check this (Heikki?). > > I can't say what's the impact from this patch - I'm not an expert with > this side of USB. Is there a danger that we end up overwriting the > ACPI node for the port, or something else? Exactly this one is my worrying, but I haven't checked the actual flow. > > Even if there is a software node - it shouldn't really matter. It will > > just be assigned to the port device. -- With Best Regards, Andy Shevchenko