From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89FD2CD98C5 for ; Mon, 15 Jun 2026 14:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SQTpoYqYDt+wwaX7XKeMsaf6yhmttUPt+OGGWaW5pwQ=; b=kP5DPtKFe9pPozq4+hfyBanj8X AxFEGeRo7PrEWG3mvz+8JhlKv6FD0KNrLYDmmaEji6uKoqKzDqWA9SD5+CxgQgs9gX6bhPBgPaf0v mMLQeOVS3cLJGdrW08LLsveG4NdTLaikERfNEWRvca6D+WWT5S9MnVTfeHM0i7A99QApONkugVfPJ TPHdXxM2RgXZ6uSeg5Ye6M73jkb6GsmA9+2WOG8F9sMRLUOmHEgEH4N4dOIc5grl01fj7DBHsb95Z Zduq81+5hHOTDqSMQtqoNz+9LoLp83vD45SZJJfCFCf0ZdE2+OC0HycJuZ1306yVR9oxp3pa11XEQ UFfE9iJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZ86c-0000000ENaB-2MMz; Mon, 15 Jun 2026 14:16:02 +0000 Received: from mail-westeuropeazon11013004.outbound.protection.outlook.com ([52.101.72.4] helo=AM0PR02CU008.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZ86Z-0000000ENZ5-1xMx for linux-arm-kernel@lists.infradead.org; Mon, 15 Jun 2026 14:16:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D5Yldb9M3W5x7RdcAalrRZW8t/j9o/BmEXWVY9QwfmnhIy5n0r+YpZdUYthDQ5RxarOKnMDHx5cG49T3Im5Dj75Vq+dmDJ+CtSZYc4z4Nil3L1IEuCRlZFgRSXepGKWz3B+OtlZ8iITzUADA7e3wE31rwjAJS4nYnqEE7m/tVY1Yn+ahuCv5oadddwZ78wszriDqF3aIkuy7Zjqt7PtnSwOw4KIlXwCAureQntH4+eAlybSQliRTNj18fit410+lbY9r5AO8NiADlEIZo/9GycdY8aDOumkUe5aYDOKgE3DnKqd758mbs2IANzqZkhHkrJmata5DzGts0/TDmYyUUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SQTpoYqYDt+wwaX7XKeMsaf6yhmttUPt+OGGWaW5pwQ=; b=EPGmC93vVvLad1ScnXLGBPO/phzDS8DxtLYBxcs901WJMKPGP7dd3br1Ge2MLfz5GM8kOw9W0nQOxFlrF1JaUq1u8qgz7r8ijD3BhaRjwHStN3Rs/UgZVJjWa+TNqlLHGB1zbN+fmL1OdK9G3JxsqaO6oa/ViVb9/uICNnkJrftN2dhyzxk4d74Gmawzx1kDar8WuNa/1P9cTYoR9eU+KKSv+263TnYYPu0X3QiuJOoVJnRA37Sf9OTAUjHg0Ah2FkR5iX1qLBDL6ifwPDREtJe3sjjpfW683d9bJ83CIi1lkfoziRn0Bq5ear/As8zpSg7cAxl3y6r8EmdcoQOpMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SQTpoYqYDt+wwaX7XKeMsaf6yhmttUPt+OGGWaW5pwQ=; b=LOdAu+AkHEzUYrksMzLOQFYchf2PHr7NuKH1bX+zoCcvC4zm2j3bSC/pjC1pbj2qhCDORYRIUc4gahtYzbqLY75+cNOZgeXrWdvWA2c2WqABgHg4XNetiDMjiWBGae6A30Cv3aOWk625g0o3z7R1rdn948fJOnhky8mLAiNjiMe3snU9nRZmxVaUgxl+7g3536JHNMjO7mDBBMqak/kRyqmPzTIgOJhSsWDtkB291g2BnZECVG3UzQfo6SpTiJT8/Wf40C0g7Z+qOTmgjF8E870TJpOw3eBJPkS370fiRQD5Ir5kWQeATlT/bxcVEFox/lbEp9sJwn599m1V5nfzog== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) by AM8PR04MB7459.eurprd04.prod.outlook.com (2603:10a6:20b:1dc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.113.18; Mon, 15 Jun 2026 14:15:54 +0000 Received: from GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c]) by GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c%6]) with mapi id 15.21.0113.015; Mon, 15 Jun 2026 14:15:54 +0000 Date: Mon, 15 Jun 2026 09:15:43 -0500 From: Frank Li To: phucduc.bui@gmail.com Cc: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Frank Li , Fabio Estevam , Nicolin Chen , Sascha Hauer , Pengutronix Kernel Team , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 04/11] ASoC: fsl_esai: Use guard() for spin locks Message-ID: References: <20260615093824.115751-1-phucduc.bui@gmail.com> <20260615093824.115751-5-phucduc.bui@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260615093824.115751-5-phucduc.bui@gmail.com> X-ClientProxiedBy: SA1PR03CA0007.namprd03.prod.outlook.com (2603:10b6:806:2d3::16) To GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR04MB11799:EE_|AM8PR04MB7459:EE_ X-MS-Office365-Filtering-Correlation-Id: a07dbb7a-3446-4cf3-1315-08decae89c90 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|19092799006|376014|1800799024|366016|23010399003|6133799003|22082099003|18002099003|4143699003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: q0EvNCrQ+ujFr36yhfD8+idWbhwGKPL8QPuGJRgY3YDZ0IQKULTKwj1LN3C0zYE4dQFSnTZQRiXUitsczerlQ9nhFqbIYENZHN7xk1HOQAvPKIYO/A1OjgA6pteSq7Fj2MnWnb+bJRd5LYfQwSuwBo4XJolPupyLpWBSyjnvgx5AanwD88KZq1WSjjEAEj0WNkce11LwxnxLqcxnoLJ0eoUw4g1TCkDHzJ2LLLNlOqaPZx0vOPFya8R2vVIUOgvOzq27RcDUfnuK66yHGAESMafDgDggKNvqk5ZTaVBit89SNf81TYCOX83qlsTbZnbZ0a9FKFnFN5DDTfXCICFTcMJsWY0owkCyoywSkg3YM2p/lnfqpTJ1K+LCtedzIBlDv32lX4EOl5DI5iYBpVoEv2q7eupLKjFQiOamqkU3abyFZvbxOi+zYu5uS+XToBi/Wv5MlFDfG7kAPlYvwhFlCU5SEfsk2Oh4s/ADAlH1gP46DKWzX5jxmvtDSFBc4hxneXQKjS4ubwV+3PLJZ/ODPipzBpKeIPksrt1HA2Q6+K5wg9o5B1+OBeevGYmHMfu6CabEPDmC78XGRMPqg8anfQeod832y9yFRx4tNJBX7mXN2nAJ2+rj+XRSDSgxzEgkP3+wda5cRNm05xhuBPf77S3pyzX2BnyltXtfIIS60+8PP0/fDsI5ZSHb/ErwFgm3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR04MB11799.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(19092799006)(376014)(1800799024)(366016)(23010399003)(6133799003)(22082099003)(18002099003)(4143699003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TDD4iMiraoQItmcuBCLDwsAiu8m2v+fyi0j5b/Yc6ki2gcZwYE99Ly8BTeqO?= =?us-ascii?Q?1F23xhMJ1m1e3NINyUbWkgTJFyDAYvX4m09jQbXACENMJUKUVr0/M318rdU+?= =?us-ascii?Q?n0nRWVJbgK0yxoNrVV1PNJPVhHhG5lA3VLBk3xIZl3u2Wxs05wHdknbpKm7o?= =?us-ascii?Q?yjTZ6b3YYwCJn5APj1dwuDyF8pwP0UbInHD/6LlcwTiQQk4czJ6zQ0qQMJih?= =?us-ascii?Q?xz/EFmZkDlAjURa5/DkWG3TT8gLb6C4E8ql5WvjKECylt7qRDD5t7FUizrUc?= =?us-ascii?Q?NBCMtZZqy0XDsLaa3l+dOav8yFPiSeqZdfcmyyuZYVRNaSYHK7dPjIeH3zWt?= =?us-ascii?Q?smmeOCwWcEgNfK8nQhTvWG0giKvgQAP78chPsFf6NKid553ECmhMEr+jDaHC?= =?us-ascii?Q?m1IwDcKumNIxyeaR3r/DHyrU70dW08RVqHzwIWyjvZF6Qm3XDiN9gxICDA8b?= =?us-ascii?Q?cH1mG1FNAxWCOQ2ch7v+ONaw4gWJ3jI6+wc0l4i+jCVRATUPWBE+gVlvUU3/?= =?us-ascii?Q?DHG8KRiToBwFA/u7aJ+JrEV0o7nxCcJOASiJELewrWofvgSDK/mkye1C5mkE?= =?us-ascii?Q?KdTil2n7uyF588aDX/DQnha4sMan4xvSY7KNB/BZ5XkaJbisNezFTGKQ1amq?= =?us-ascii?Q?Guk5i83DZY0OiBRYNlO6r0j0QcqLRd6BHClCjkJRrBD7aAvAJAFccIoSoN7/?= =?us-ascii?Q?i9LVNeofIgCZ9fzuEkurzpk/1FRGaoye9Y6o5HQS9AZSXjzGO4yBQTrwWRCc?= =?us-ascii?Q?/lIhGV9fnYyhz0Z6DqXJf1ub+lKBZz0THssUCiJO154BK8f8oxTtSgH66PPN?= =?us-ascii?Q?OJ0IBnwQ8i1lABAgJlrU8RXho5SDbwo7u7f2TxIz3vHLbX3YloWYkLIOZDCe?= =?us-ascii?Q?fT9J/8gW0ZPlw6SbP6qQknO4AnHPYXy3wOfWt2ToO6V07sIZXWy//9Qqr6ds?= =?us-ascii?Q?tDKd7iZa3GxgAaBwKGNkpq4egba9uXtxiICAvQgkj94M5EFUM6R9zbcMWYpf?= =?us-ascii?Q?aYmQ9eE4wcakHiqGP6tEAXz9BvoADta6NJe7HPx5eMENJPFZcWwe7Q/KJLHO?= =?us-ascii?Q?6dPkzQVK8fE4wJ/7tHhrr/uFXh52ljX0CMbyVOAp8ZL/iIagBVPSoF/TS7kH?= =?us-ascii?Q?uvCtQylXz743yIVYTkNzThIq98PPdaaf33hkoQ0Nb5H+QmSVR9O3g18lshgN?= =?us-ascii?Q?5nuXkDnCqBQCCxrmU4c6QeklclEkKrcXSBS6oZEGqJrp5g6E7Ee9eVyGuoXs?= =?us-ascii?Q?3rEejVhCI8toZNbhCRDxf01PleSE/gZWK7hsCTyPTkCLkmykS8RgnvnXa1MA?= =?us-ascii?Q?M88W7LMk1nTObhioe+hgVibJa70h8AVOdm9FpLCXYoyy7epnOCpDkOLioGIA?= =?us-ascii?Q?meup3XPgx4FaScUDNSfIIioQgKl+UlnuR5eyBMtfPUjuqlDSmplrDgAnhuD5?= =?us-ascii?Q?vC1LDXgjT0c07EJKCjXP1GeuaVkN7SoYCEaBdncA7bl+4HEbvfWXMMUQNiKg?= =?us-ascii?Q?laNpQhR/ULfTBgPXX8nanrjI9yeb7sHnU1mhDjwNb1vQt2TAb1TP9BitHdyC?= =?us-ascii?Q?8s13DNsQNi75LOvzjc4MCmj1YgdjUNWWljSo3bdy97OxPM2SqzdT5Jd4XJ/v?= =?us-ascii?Q?NzXEvReVbqN5FxjgGMRfkfM2N6gq8Zfbxz75mnkr0O4EAwkE3OVdJSvwtXJM?= =?us-ascii?Q?tYX/+gsffj3ynlN0qbcN03PtLw4M3AfY395Fj/FpPrsHeoWN2mQXuuZNVdSa?= =?us-ascii?Q?ytousWsQbOxfY3CYRELy4V6UWg4U4taqrroczPYaF5YqtFNjmm4f?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a07dbb7a-3446-4cf3-1315-08decae89c90 X-MS-Exchange-CrossTenant-AuthSource: GV2PR04MB11799.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2026 14:15:54.5223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Dg8AH4nq9avAk0Sx0YV8hd4sd/LWhYPwWTCWW19plLVzGWvLVRC+yRpkYoa6NHmQ73ZUbhUPIvS2NwLFUx0U7VqSGv+9r6b21xCYMJPi591Vk/pKUrOizTpB91P8SIna X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7459 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260615_071559_506984_60D02C51 X-CRM114-Status: GOOD ( 17.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 15, 2026 at 04:38:17PM +0700, phucduc.bui@gmail.com wrote: > From: bui duc phuc > > Clean up the code using guard() for spin locks. > Merely code refactoring, and no behavior change. > > Signed-off-by: bui duc phuc > --- Reviewed-by: Frank Li > sound/soc/fsl/fsl_esai.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c > index cde0b0c6c1ef..4a530a6c33f0 100644 > --- a/sound/soc/fsl/fsl_esai.c > +++ b/sound/soc/fsl/fsl_esai.c > @@ -709,10 +709,9 @@ static void fsl_esai_hw_reset(struct work_struct *work) > { > struct fsl_esai *esai_priv = container_of(work, struct fsl_esai, work); > bool tx = true, rx = false, enabled[2]; > - unsigned long lock_flags; > u32 tfcr, rfcr; > > - spin_lock_irqsave(&esai_priv->lock, lock_flags); > + guard(spinlock_irqsave)(&esai_priv->lock); > /* Save the registers */ > regmap_read(esai_priv->regmap, REG_ESAI_TFCR, &tfcr); > regmap_read(esai_priv->regmap, REG_ESAI_RFCR, &rfcr); > @@ -750,8 +749,6 @@ static void fsl_esai_hw_reset(struct work_struct *work) > fsl_esai_trigger_start(esai_priv, tx); > if (enabled[rx]) > fsl_esai_trigger_start(esai_priv, rx); > - > - spin_unlock_irqrestore(&esai_priv->lock, lock_flags); > } > > static int fsl_esai_trigger(struct snd_pcm_substream *substream, int cmd, > @@ -759,7 +756,6 @@ static int fsl_esai_trigger(struct snd_pcm_substream *substream, int cmd, > { > struct fsl_esai *esai_priv = snd_soc_dai_get_drvdata(dai); > bool tx = substream->stream == SNDRV_PCM_STREAM_PLAYBACK; > - unsigned long lock_flags; > > esai_priv->channels[tx] = substream->runtime->channels; > > @@ -767,16 +763,14 @@ static int fsl_esai_trigger(struct snd_pcm_substream *substream, int cmd, > case SNDRV_PCM_TRIGGER_START: > case SNDRV_PCM_TRIGGER_RESUME: > case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: > - spin_lock_irqsave(&esai_priv->lock, lock_flags); > - fsl_esai_trigger_start(esai_priv, tx); > - spin_unlock_irqrestore(&esai_priv->lock, lock_flags); > + scoped_guard(spinlock_irqsave, &esai_priv->lock) > + fsl_esai_trigger_start(esai_priv, tx); > break; > case SNDRV_PCM_TRIGGER_SUSPEND: > case SNDRV_PCM_TRIGGER_STOP: > case SNDRV_PCM_TRIGGER_PAUSE_PUSH: > - spin_lock_irqsave(&esai_priv->lock, lock_flags); > - fsl_esai_trigger_stop(esai_priv, tx); > - spin_unlock_irqrestore(&esai_priv->lock, lock_flags); > + scoped_guard(spinlock_irqsave, &esai_priv->lock) > + fsl_esai_trigger_stop(esai_priv, tx); > break; > default: > return -EINVAL; > -- > 2.43.0 > >