From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3151BCD98CF for ; Mon, 15 Jun 2026 15:33:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fLlUil6x2OhPZqB6mPNY2Ms3BMzPf68Kf9cGPrEfVrY=; b=L3dux8JlFcIsv4VwK+I9kPGnXs uz9HNvcAYyrn2jzBdpYk37zP3Qdv0Dgtx0IZk197UtdViZtDUPMN2ZLtUrgs4gb8GhJ8b2LpH1FO/ jbfZYt3LPhRrsXhsm2pTiZ2kXrHzW9z/Msa5hHXjIDilybZXR9Atf1HjmQk+gKLXWOLWmOTtRfCHc zkKmnvobnIOdxvpz+HoyzPAgTFVkC/JL3ydf+laes3cvlRXHgqlfzBjGotdALVL15nH+lMpWw9HTw LGzMWyJo6sX/R+9lftBp52H+JGvdawIR9Lu//SGKpwMsFF02w/ICGN0zT76ekuAaSlbhAAAFtwLSv fGLh8Nvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZ9Jc-0000000EVX0-3mPf; Mon, 15 Jun 2026 15:33:32 +0000 Received: from pidgin.makrotopia.org ([2a07:2ec0:3002::65]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZ9Ja-0000000EVWb-18yR; Mon, 15 Jun 2026 15:33:31 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1wZ9JP-000000004Nf-1xqC; Mon, 15 Jun 2026 15:33:19 +0000 Date: Mon, 15 Jun 2026 16:33:16 +0100 From: Daniel Golle To: Christian Marangi Cc: Felix Fietkau , Lorenzo Bianconi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net] net: ethernet: mtk_eth_soc: fix supported_interface set after phylink_create Message-ID: References: <20260615151106.15438-1-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260615151106.15438-1-ansuelsmth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260615_083330_332024_23E68375 X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 15, 2026 at 05:11:00PM +0200, Christian Marangi wrote: > Everything configured in phylink_config it's assumed to be set before > calling phylink_create() to permit correct parsing of all the different > modes and capabilities. > > Commit 51cf06ddafc9 ("net: ethernet: mtk_eth_soc: add support for MT7988 > internal 2.5G PHY") while introducing support for 2.5G phy for MT7988, > probably due to an auto-rebase, placed the configuration of the INTERNAL > interface mode for the supported_interfaces for phylink_config right after > phylink_create() introducing a possible problem with supported interfaces > parsing. > > While this doesn't currently create any problem/bug, move setting this bit > before phylink_create() to prevent any possible regression in future code > change in phylink core. > > Fixes: 51cf06ddafc9 ("net: ethernet: mtk_eth_soc: add support for MT7988 internal 2.5G PHY") > Signed-off-by: Christian Marangi Reviewed-by: Daniel Golle As no user-visible bug surfaces because of that it is questionable though if the Fixes:-tag is justified.