From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2100FCD98E4 for ; Wed, 17 Jun 2026 09:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9hBGbkhV/3vuK/Tjp/LOl9erXla1+SWHZPqLvmd3tfc=; b=WnKOSGTPSic7M1zmSNcjd8nQcE OaQfkg67OsnKZSzm2NpPSJANjPDQiLYVDjzeOoRs8c0wYIqxYS3K5i0fc2i47cOi8j9gRPloxD6nU BVyKpwSWSuB7kQC3YVAhPW6g8aGYp3s16mDT0+OMfzC8Hkfo7S+ZQ1P5MXdaJ7ioOC7okPNAoosrv 1ms+COFXz4Sysrq0irDu3XlwFwRqX+tbxsSYTudowRFd+qdNadyQJFYVciqtqZrGueuAxhQCFSM5u 3uyInFWeelbOJxJzJiw6CTXy4/uNXlCio5NiJl/KwjeNKNHfNwpRCQQXGggIMeK9cjxH3Wvm3ojBM m0b44SSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZmqR-0000000GxpO-2Hlj; Wed, 17 Jun 2026 09:46:03 +0000 Received: from mgamail.intel.com ([192.198.163.14]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZmqP-0000000Gxia-0xJF; Wed, 17 Jun 2026 09:46:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781689561; x=1813225561; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PJRUrD9zZfvxEp95vYDkf9Io499+vXWD3N/tqWUsuhs=; b=edluMAKcnaLRx1CHZZxcNZ9x8DZMY0XRb4x3Mz6gwEu51a/LVUNOPxmW OkfuxUilVQm4bwcI3apaWKuqsGlKbdbRCdtNGVQBAjHpBEroz6ckcnKMU zV+3SiUPHDO4QdDcILvlZ+YhzZV+fFFbO1P6H4b0RkMHtBB5SOH6D/8Ba gVzMfpFM+fe7s1qTD+xUfDBLHI3IU9koYZxmRaVsZQrAWV5sGSX2SYedw 9VX+SnDjjUgaX71jVTpUBd74rtVzoHDr7J+m3VV3fL2+PJqqm4A/o6HsF YonFkE9SkhlcLsc/f6YdLnKbtInd3eIuT9kxfX1YjL0tR9aHpp3nV869Z w==; X-CSE-ConnectionGUID: O5QuLaWdQXKyIh6EK8JS2g== X-CSE-MsgGUID: nx89t2vRSUW/zv2es+tXvw== X-IronPort-AV: E=McAfee;i="6800,10657,11819"; a="82534245" X-IronPort-AV: E=Sophos;i="6.24,209,1774335600"; d="scan'208";a="82534245" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2026 02:43:56 -0700 X-CSE-ConnectionGUID: KqEF+XwPTGGdSxcdFhXqFA== X-CSE-MsgGUID: zVMyIUsrS06+OMMQYl0JoA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,209,1774335600"; d="scan'208";a="246888272" Received: from fpallare-mobl4.ger.corp.intel.com (HELO localhost) ([10.245.245.69]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2026 02:43:52 -0700 Date: Wed, 17 Jun 2026 12:43:49 +0300 From: Andy Shevchenko To: rva333@protonmail.com Cc: Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Lee Jones , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Ben Grisdale Subject: Re: [PATCH v3 2/4] iio: adc: mt6323-auxadc: add mt6323 PMIC AUXADC driver Message-ID: References: <20260616-mt6323-adc-v3-0-1c27c588185d@protonmail.com> <20260616-mt6323-adc-v3-2-1c27c588185d@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260616-mt6323-adc-v3-2-1c27c588185d@protonmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260617_024601_301230_CBB9F706 X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 16, 2026 at 05:15:40PM +0300, Roman Vivchar via B4 Relay wrote: > The mt6323 AUXADC is a 15-bit ADC used for system monitoring. This driver > provides support for reading various channels including battery and > charger voltages, battery and chip temperature, current sensing and > accessory detection. > > Add a driver for the AUXADC found in the MediaTek mt6323 PMIC. ... > +static int mt6323_auxadc_prepare_channel(struct mt6323_auxadc *auxadc) > +{ > + struct regmap *map = auxadc->regmap; > + u32 val; > + int ret; > + > + ret = regmap_read(map, MT6323_AUXADC_CON19, &val); > + if (ret) > + return ret; > + > + /* The ADC is idle. */ > + if (!(val & AUXADC_CON19_DECI_GDLY_MASK)) > + return 0; > + ret = regmap_read_poll_timeout(map, MT6323_AUXADC_ADC19, val, > + !(val & AUXADC_ADC19_BUSY_MASK), > + 10, 500); Still can be amended. ret = regmap_read_poll_timeout(map, MT6323_AUXADC_ADC19, val, !(val & AUXADC_ADC19_BUSY_MASK), 10, 500); (no need to resend just for this). > + if (ret) > + return ret; > + > + return regmap_clear_bits(map, MT6323_AUXADC_CON19, > + AUXADC_CON19_DECI_GDLY_MASK); > +} -- With Best Regards, Andy Shevchenko