> Thanks Simon for forwarding the AI review. I've reviewed all three > concerns: > > #1 (NAPI race) and #2 (RX refill) are valid. #2 is the decisive > issue: airoha_dev_open() has no RX ring refill, so draining the > queues in stop would cause RX stall on next open. This aligns with > Lorenzo's earlier feedback — RX queues don't need cleanup in > dev_stop(). I'll drop this patch. > > #3 (q->skb leak) is a pre-existing issue, not introduced by this > patch. It exists even in the module unload path > (airoha_qdma_cleanup()). @Lorenzo — do you think this warrants a > fix? A one-liner in airoha_qdma_cleanup_rx_queue() would cover both > paths. Or is this too unlikely to matter in practice? Soon I will post a patch to run airoha_qdma_cleanup_tx_queue() just in airoha_hw_cleanup() so I think we should just drop this patch. Regards, Lorenzo