From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E555ACD98ED for ; Thu, 18 Jun 2026 18:52:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tirR7lfsZVF/WhCbi1OXHqKdFMnP7mj5+FwRh2WsuHA=; b=fzkkk7yampbH0r5UNrTJnx3DBr Q7RPPPvMZT6zE0CJqGtgNZGNqjs/UQju7bhlNp8ExaQNzVwKODg0S4Gipq8rLN7vOwo/XL0qqk2o6 n6JJtlbZcKlcV5bDNVWIMjGszFgf1UaBLQCJ1p6ftvekek4mqusnhEdMgITGv7CTIMlpHA3nKUEKq Acz8ZsdpDaR4QszG/URihyi+xn/nAFRCt6ODHfY/spl1c0gBhWumWHOFFhxhPlUKlRwyhcdcOjJxP pobp8SSlep+XcKkv3c1b5qbyQWX5IzceS1WfOkXkPfstiZ06YvOqWdnBv0KchPbrx/0TLCIs/yy8N TfZDzyGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1waHqg-00000001i11-38hZ; Thu, 18 Jun 2026 18:52:22 +0000 Received: from mail-northeuropeazon11010004.outbound.protection.outlook.com ([52.101.84.4] helo=DB3PR0202CU003.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1waHqf-00000001i0d-0NrK for linux-arm-kernel@lists.infradead.org; Thu, 18 Jun 2026 18:52:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tHw/OMFZBEiYkWk774n9C6+Snm9QzBrl/o5WfJilUakho/1XYPr+dCqOGHvROXCjkFPkb9dbO3+r1CJjqLQ7AlN1pbQ1MwLqXbboiN31wJv9e9Ug2l6Xj7txVrhnG0xK66yXuxXVaschd5mtpVWHthec+TwWGUQEJMKyOxZtJRgvKFBNPKlV53qP3LEJkj1Hl51pGMQWROA2KzSkLqMPcG/ovVhsqsXsV82qPYUP1Tz387s+EQKQPXCD64vLRPTdha4SaR6UevUwbJ6EZSYtDmsWGLX5dwnF1YpFusyXKkCPFdWs+P4P044B0eCP1dPH/OqhYCLoEY4p/ZUFkBZyEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tirR7lfsZVF/WhCbi1OXHqKdFMnP7mj5+FwRh2WsuHA=; b=kek/PWLHRCbsQ5fMeLOOwWlMZWRq0tt4y5aNCjfICSVT4YbLFRGn0ulalqdZWFj6XglDGdAvukMYl7IZazQuMJ9H3woCbWxYxJhhe01kbiv0CWgryCm78sjwDHUGGsQ791Og/4BnBel5JzpxIYDIL7j3gWnUzByxpegE2HQRoBimLLn/3zpBws1rJaT0mpUEKO0wnr5nU1hrEBGO8YHq29jSbXmgqiiG7HWQ6SWd1AgOV41BR8kCuSiwK82hE6u3+MZ0S9/0Y2OZYir4AO3ZDr1TDEQ0Y5Tg4VtTlFSDHS+2qW3hdLyrXaTa9xmlW9YN8PzB0F8/Ey4wl2WRNRB7sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tirR7lfsZVF/WhCbi1OXHqKdFMnP7mj5+FwRh2WsuHA=; b=Bwp/V/NXZkBk/DsWXYirumgPX9Mwkovv9Ho5EsdmauTFqb7PnbD4dt5vWz6vWRQUT+8Z/SesHmDROTjuIzT/0a5QXnub2jt/d1MM99s7CQ9xIcnjsnQKTjLOb9ROHe8m2jFCP/YwoclUhRXUuRc7iCaHBLoiUFFGGy5yWNxlP+YgWtQ3WI1EJe7wzhoS4cdZwqAFtCfWehI+N/8oDkr/c4kzKrRpO9rzHAhRmFE0LMUkY9dg4mYa3u79LGwkcExCKz9gMNuzfpCNxAvYeQkzlMUYVbGoON7E3H0OhCFE0F4JqSh58bLJGi7Q6i5Kf1YbX22OdMU7iYiyCyCPTxHuHg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) by GVUPR04MB12217.eurprd04.prod.outlook.com (2603:10a6:150:33d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.13; Thu, 18 Jun 2026 18:52:15 +0000 Received: from GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c]) by GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c%6]) with mapi id 15.21.0113.015; Thu, 18 Jun 2026 18:52:15 +0000 Date: Thu, 18 Jun 2026 13:52:03 -0500 From: Frank Li To: Golla Nagendra Cc: vkoul@kernel.org, Frank.Li@kernel.org, michal.simek@amd.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jay.buddhabhatti@amd.com, harini.katakam@amd.com, m.tretter@pengutronix.de, radhey.shyam.pandey@amd.com, abin.joseph@amd.com, kees@kernel.org, sakari.ailus@linux.intel.com, git@amd.com, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 2/3] dmaengine: zynqmp_dma: Add per-channel reset support Message-ID: References: <20260618071056.2024286-1-nagendra.golla@amd.com> <20260618071056.2024286-3-nagendra.golla@amd.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260618071056.2024286-3-nagendra.golla@amd.com> X-ClientProxiedBy: PH8P222CA0002.NAMP222.PROD.OUTLOOK.COM (2603:10b6:510:2d7::31) To GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR04MB11799:EE_|GVUPR04MB12217:EE_ X-MS-Office365-Filtering-Correlation-Id: f0fbb027-01d4-4c02-6bdb-08decd6ab6c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|19092799006|1800799024|376014|7416014|23010399003|11063799006|56012099006|4143699003|18002099003|22082099003|6133799003; X-Microsoft-Antispam-Message-Info: eVL710sYp2XCAiAYYZSOkQDfb+hownPcNmkX5JtsV+qQQrx7ugsgGuD+m8ECv5MbmHu5uGIhNvSXV8mShnEzozPHMZR5UBPydp+uc+7ngXQdmIRJ16ZeinWjgaFJWkzwPODrv4IVzNVavhhtO0E3CaOeeywOjJUZOCJE2wh1QP0wFymydKo9LX3YkdHUyW8jT+yF+7WUrh52Y82DXzekza7QgPGNr0UCVLTp53t/NF6zhwheQ88u9kQ/D/7EfeoNfpm4F+2Jz77l2/UIPfkgCU7LZI5Xcps3/lVnsIS6dU9tvuEBiPPRjvXcNSa5ubHxmNoLZ3yrKkHO0bOMCLx/t6hTaCQlrGj6XwLpCwXjmzHna18Ovm4a5ta8tMnlfcfXJD5CPZr4uergxBiPmlaXBbu+pyY/iHdL+lnYPxnhBDJ47r8SW1LVOP8mCWVp7jn9T39dHN/NnCpRIqr30mBUh0vK5wxg0dFYE7o1pI2RSDcSo7Ni29g9vBLLjthaNxBLYh5VvQl1+lLlBR2BnbOLc4Rgd09t/pQYlONzUAOYOSuXCVZdhe6nr8mNLdKC6LDHTE6qT07PQU+/AllGCXclZTOncNDoQAtCt+ovqqMgRzEqhkgg0PwIGhSHRiqQ0bVhmh7L8QA/NHmRfzqWDti/4mWUk6gCT4hT0FNaAquQpWJfl+a3o0sI6fjsRDmN5pqK X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR04MB11799.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(19092799006)(1800799024)(376014)(7416014)(23010399003)(11063799006)(56012099006)(4143699003)(18002099003)(22082099003)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?F2UGhUA2VPfzYCwlDjpkstSSPulv23x70ppFJp56q+1VjbGKNPWULJlcFIc6?= =?us-ascii?Q?pKj+O+2o356rjwclpsIREfX5zMt8XkzczzPWoXGhZO5FMOzDVzlHF23GppqZ?= =?us-ascii?Q?rWkpAEjbW4XeFI4p5hUjdQCdMACbiat+UW6V3RzssWvYN71pL0L+Z2LpT33e?= =?us-ascii?Q?bqPMVDgKzmqDcvmlTcDANlkLsDAKCZH5A7N5IJ0qtaog6/8Ka1NeRiKWmwMT?= =?us-ascii?Q?pXtNqba7jmaSudmANFwJBRSMr3TPIN4vg7nXlvCzP47r4ya3404z4z744y9p?= =?us-ascii?Q?DRA6uUBX/zl6GWHZ2ea4L8oYIkI0XctOKqTKlaMGrFOKztv004ikGeYODRT6?= =?us-ascii?Q?X2rtgJLXVc3fvAPKSGjFY22okJ5ad9rvtqNmr0xE6rrwwyX03eRXSYs225Ch?= =?us-ascii?Q?7dYQNA8ij257mIe6ypwlx8VxtqcBy6seJDMtPGyGdOA1yrKIPopjuwDQQLYQ?= =?us-ascii?Q?DBrTVR+Gc72RvXZUb62TIMsQwccoWxuixdNs6IfyjTkgx1Dr3dKMWu32AT5O?= =?us-ascii?Q?6ECx6rF9GABSL6PoKqH7UvaNHOY0giccf7bqPOKqHyxdlFXx7AIJ07cUih20?= =?us-ascii?Q?BPvQT2S/Lv+TdOKBVoBGLvMdxfFvMtb7xtux0N8HkM82lgPSUge7sVZ2jVvJ?= =?us-ascii?Q?SBf6qStzYqIMJX/kNtIAJVj9Z6Uu5KPaNt98firWzVhz+CkU1WbD28ms1OOO?= =?us-ascii?Q?yJMoXdWl1sI0L5rgEhn/e55l9KBQO0ZsG/ExseyIMp9vrtoHgxD1n4ivOuEZ?= =?us-ascii?Q?pzM4Bs08CvldZ9Gcb647EHmjRxOkNhZfknSVLwwEl5ucWS9zXwUKDivUUDle?= =?us-ascii?Q?FaM+XSl+aZRWvYo2aXR16M8GX2Ayr0CzYVIO1MAFy57UDWZR2rXMgV3Q9mna?= =?us-ascii?Q?VRA0/0IBUPalkoG5OrEwuh7nki5zSjBGolmUoyuO2wmE2wAmBt/uK8ceBuRz?= =?us-ascii?Q?k2aV5YcOg1PlOdmNJkUv5CQXBYeQZCy2oI22tJL0ScS14GgpOSipL1YRha4Q?= =?us-ascii?Q?AzF3QZRWQ/joIlwbgRKzaxjz5KfmDRjm5jhE1m3YJkusZLrqjUdK7eaOMS2U?= =?us-ascii?Q?1KLqJF6v7QV2AH/dN8xmw4OauUwwH4qMqY2tNkOUvWHKfJ1QWleysP2iqZsu?= =?us-ascii?Q?rE+2FflAaGWtkrxYaLETllumBb0IpZTUYp57unUwwMqOj98jHDr3vBNZUBaB?= =?us-ascii?Q?3UdOOanL41I9yWbdwvRaw1aSrkvC1ifsmVzG+G2qknPuFVXaR3EEROVLNYi7?= =?us-ascii?Q?1OP/RjeT0OG8deuNRSKVjfHewx2pRYRbD5qajiFd/3pVYfzqc/7y4iWittNl?= =?us-ascii?Q?xmBioIL1q6lD5s6X7eztg3ohw+Nv7Jp6uG8smszYcNuVLDUj+kTitIGiiKD3?= =?us-ascii?Q?5vEyRsDGZuvOY6Rx3vzkbHJv7npTe0XddPxhcH8OhlRcbvufrNMCr6P8/oF1?= =?us-ascii?Q?cOHy6QlY068J7riXQ/U03HnX+kb3rai1dQJVn1cS2dGpAwon5A2zsYVFRfEE?= =?us-ascii?Q?mnyqeDOI743ULAOD8hrqsDfSSVQBThaPciObw3aN4ex3pW0bpotEQ1HOmibq?= =?us-ascii?Q?TRKGaE918Bu7XXKp1DfKTlfqVfTpzi6BeLLuOElGiUMlQ46pN8nED109M/KE?= =?us-ascii?Q?K5uvbZ8v6F5vALuBn291GsywTLWFMG5mqSSXOFlXTM/ZztAWhdORfxlvvkXb?= =?us-ascii?Q?+r9N40+QoW6/sv+7vEKcOs5wD87n0VwKeTOdQqVtinuXyPAJnFuWIfQ6UZu5?= =?us-ascii?Q?QPAOoHofhXQes+nuLE6LRiqqFLO2AFTOH2PUQX43VU8JljtAP1qo?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0fbb027-01d4-4c02-6bdb-08decd6ab6c9 X-MS-Exchange-CrossTenant-AuthSource: GV2PR04MB11799.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2026 18:52:15.3054 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X8/5wld98LScXeql74BQYQY+a+P1bkXagik7/aOcCxJzaodC8vCWwztv2jamRY3OoSMO32YgBc4qgGl0C5/h7gJ5FxviYb4yS4UJjy/UoRonQ+2EcVhxWhQyt9hyyzf2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVUPR04MB12217 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260618_115221_240164_468FF06D X-CRM114-Status: GOOD ( 22.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 18, 2026 at 12:40:55PM +0530, Golla Nagendra wrote: > [You don't often get email from nagendra.golla@amd.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > Versal Gen 2 and Versal Net SoCs expose a dedicated reset line per > ZDMA channel, replacing the earlier approach where a single reset > was shared across all channels. Add reset handling in the channel > probe path using device_reset_optional() to trigger a reset pulse > on the channel during initialization. > > Platforms without per-channel reset continue to work unaffected > since device_reset_optional() returns 0 when no reset is specified. > > add pm_runtime_put_noidle() in the probe error path before > pm_runtime_disable() to balance the usage counter incremented by > pm_runtime_resume_and_get(). This is particularly important since > device_reset_optional() can return -EPROBE_DEFER, causing the > kernel to retry probe() and leak one PM usage count per retry > without the put. Use sperate patch to fix this problem Frank > > Signed-off-by: Golla Nagendra > --- > drivers/dma/xilinx/zynqmp_dma.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c > index f6a812e49ddc..a9dfec3c0ca3 100644 > --- a/drivers/dma/xilinx/zynqmp_dma.c > +++ b/drivers/dma/xilinx/zynqmp_dma.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > > #include "../dmaengine.h" > > @@ -916,6 +917,11 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev, > if (IS_ERR(chan->regs)) > return PTR_ERR(chan->regs); > > + err = device_reset_optional(&pdev->dev); > + if (err) > + return dev_err_probe(&pdev->dev, err, > + "failed to reset channel\n"); > + > chan->bus_width = ZYNQMP_DMA_BUS_WIDTH_64; > chan->dst_burst_len = ZYNQMP_DMA_MAX_DST_BURST_LEN; > chan->src_burst_len = ZYNQMP_DMA_MAX_SRC_BURST_LEN; > @@ -1152,6 +1158,7 @@ static int zynqmp_dma_probe(struct platform_device *pdev) > err_disable_pm: > if (!pm_runtime_enabled(zdev->dev)) > zynqmp_dma_runtime_suspend(zdev->dev); > + pm_runtime_put_noidle(zdev->dev); > pm_runtime_disable(zdev->dev); > return ret; > } > -- > 2.34.1 >