From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0968CD98F0 for ; Thu, 18 Jun 2026 23:51:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8uZEinBiEzubyVwK+mDqbuOj5jjsF/asva00uL4IEmk=; b=iFTqDN3wN0Lu8+zwQ7MyqGasPV nuUyixRCxFbtHA3KbYkJ4JxcLGMzWAubXlafidrqbyFIJ8Zw17hcK1U3uiPdEU/Yib0EFMgpQEoSK nQTmi+DcChEAEY9upVzQMbmCp/xsI5dgxPgQf4uT7lcilzNFFOuq11iHZlUlSwYD9Nkzdu3yAAgsU Q3bpF6JiDg/8cknlW0os1v0DqY93g4GO9uPb9bvBuayYhdF5tsFXV1Zy1i9JwIk3XjkQL+FlSqtCR x0LOxyOWSsr09czO5d1azNCOOOTFwJM6q8L7cau3+WNN1Zy0JTNgZ/gtwMGrnuvvDjOA/fD4R1xgq bi/G2gZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1waMWA-00000001sRz-2y9A; Thu, 18 Jun 2026 23:51:30 +0000 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1waMW6-00000001sR4-3hK3 for linux-arm-kernel@lists.infradead.org; Thu, 18 Jun 2026 23:51:28 +0000 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-5ad4f39064bso1279750e87.3 for ; Thu, 18 Jun 2026 16:51:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781826685; x=1782431485; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=8uZEinBiEzubyVwK+mDqbuOj5jjsF/asva00uL4IEmk=; b=DXgN9/fug1iGiVzrquFsRR4S6sXBHb6pT6EIsouleBeHjvSjoekUBRKI9wGO5cP5vb EjgABVfy0IDc0YNO4y5FQrigAcdQvG7qiuxnGhIgDAtt/yZBHrKiiIcQ3jLSUoMzEt65 qPNE7Ks0ZCGcCTj1MDph39b4sblmh/TaTSl7RhYzKm8hfofmuyQygHUtiJI4M7bADo5p lrB0V7tt3+XHOePHUnepLQ1raw8r5BT6DIFN+fp0oFVWtNl/7wpffFZo38ylU6MQuA4A EHeVE6DywlQHjzg7gTZPRubKsEOU6Nho+lXFhN0koDNPnU4eQ1KI99xX+Sv8RUdrPqZU n6rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781826685; x=1782431485; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8uZEinBiEzubyVwK+mDqbuOj5jjsF/asva00uL4IEmk=; b=sCx3qA4sTVfJwn4dlJ+MwGQvXM2AiIBQZA6XDDuySRFijywwjboB1l29eAeXojcYss 2/6/JpHse8iJ9zkOGhSKtr/5qdrrdOq6JOPXjxJ4SeRrM4WRTnyAYBhxgxG/rshC5Kxy pQmSQwoYYQrrPghbs0ZhSRYHULqgfk3acxqdFik3XTSJyFRaOsh6fGyTe9ptM2jK6I0f joR4v7++en6boV64ng2TdJYb6b3NGU5IVowO7VatGm1R13IcJl8DdTSVsGD4h+BmGI5+ c632o47vA3ZFzSt37NbPfavmQwmDPP7dQblfdaBoikhnWNuLQ5lsqGgVOmn+ZNdwFTKU 8bWg== X-Forwarded-Encrypted: i=1; AFNElJ8n6zv1XjhIL3l8He0MPN3BucPtyQcM+yiwfnYiFOBVWNR4ZvB3sMzSbWQT7GQILLZMah0fWp4Kesv3Xm4nJ4tX@lists.infradead.org X-Gm-Message-State: AOJu0Yy7/8kBCQELcQk1Va4XWqs8iRVBK/3CSkt7t3wTqH1OWRkbhIJF wMi0NBRAO+72wmIlQVVxHIyuQJatHBb3V8G+9zNrz5WE5fXXkE0uVBHT X-Gm-Gg: AfdE7cnGKlOHFIG6hqkRhtjMBtzJw65VVfBtkQNWtKN4AoUfog5TO0sFTGa1fYeNJS2 P79VRNkgIft/rSuX9aWkDxl6HpNfZwepkXCv1ta5RYjGGV+97GX7PDWKurnO795pOt8DxjWJ3Ba haSwNSe165I+zj4jsZqSHaacvDlNPQBQ16gyABI/nJ/37kz9U1dE+r+KRPH4YC4dPneESRegVzq Qo1oLs1n/cZc4Cc7+9OZyo9Oz21bJKSVD1t1sZReUqKVVhljfnhhzo6HvwI1rXyWFq26pg/K04n Q7siu/39YstrNeL2cxf7ojVVE5MHsn1L/a7awJZIut6oIFDT+rjJ7sicvqV2VjJNqwVYTEtVAgJ sUHDzIDB7gHOj+juJS7HaeZZ6yY8xwOlmb47Md1qzzcRGH8Wk8ZJHdM8Vehmt3RALi3tuGsexfm s9+bdDjmVBOtJNAg== X-Received: by 2002:ac2:44d4:0:b0:5aa:8823:aeba with SMTP id 2adb3069b0e04-5ad57720e67mr181855e87.47.1781826684481; Thu, 18 Jun 2026 16:51:24 -0700 (PDT) Received: from localhost ([2001:678:a5c:1204:3d4f:47f9:ac7a:fb85]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad57245f5csm197309e87.28.2026.06.18.16.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2026 16:51:24 -0700 (PDT) Date: Fri, 19 Jun 2026 01:51:23 +0200 From: Klara Modin To: Rosen Penev Cc: linux-wireless@vger.kernel.org, Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , "open list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH wireless-next] wifi: mt76: fix of_get_mac_address error handling Message-ID: References: <20260427051746.954704-1-rosenp@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260618_165126_945749_C6B6FDC6 X-CRM114-Status: GOOD ( 33.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2026-06-18 16:01:45 -0700, Rosen Penev wrote: > On Thu, Jun 18, 2026 at 2:47 PM Klara Modin wrote: > > > > Hi, > > > > On 2026-04-26 22:17:46 -0700, Rosen Penev wrote: > > > Check return value instead of is_valid_ether_addr. The latter is handled > > > by the former. > > > > > > Signed-off-by: Rosen Penev > > > --- > > > drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c > > > index 93d91264687f..0f6ccf6ed53d 100644 > > > --- a/drivers/net/wireless/mediatek/mt76/eeprom.c > > > +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c > > > @@ -93,7 +93,7 @@ mt76_eeprom_override(struct mt76_phy *phy) > > > if (err == -EPROBE_DEFER) > > > return err; > > > > > > - if (!is_valid_ether_addr(phy->macaddr)) { > > > + if (err) { > > > eth_random_addr(phy->macaddr); > > > dev_info(dev->dev, > > > "Invalid MAC address, using random address %pM\n", > > > -- > > > 2.54.0 > > > > > > > Recently I have started to see randomized MAC-addresses on my x86 laptop > > with a MT7922 and the above message printed in the kernel log. I have > > CONFIG_OF turned on, but since this is an ACPI system the device is not > > described by any device tree and the earlier of_get_mac_address() likely > > fails with -ENODEV. Looking at the !CONFIG_OF stub for > > of_get_mac_address it always returns -ENODEV, meaning this will always > > randomize the mac in that case too. > IIRC, the normal device_get_mac_address supports nvmem now. Does that > fix your use case? I tried this: diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c index b99d7452800f..243a8f2c7bda 100644 --- a/drivers/net/wireless/mediatek/mt76/eeprom.c +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c @@ -174,10 +174,9 @@ int mt76_eeprom_override(struct mt76_phy *phy) { struct mt76_dev *dev = phy->dev; - struct device_node *np = dev->dev->of_node; int err; - err = of_get_mac_address(np, phy->macaddr); + err = device_get_mac_address(dev->dev, phy->macaddr); if (err == -EPROBE_DEFER) return err; but I still get a random MAC. > > > > Reverting this patch fixes the issue and the correct MAC address is > > used. I'm not sure if there is any case where of_get_mac_addres() could > > fail in a way that results in a valid MAC address but it seems unlikely > > to me. > > > > Regards, > > Klara Modin