From: Brian Masney <bmasney@redhat.com>
To: Akari Tsuyukusa <akkun11.open@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
"open list:ARM/Mediatek SoC support"
<linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
stable@vger.kernel.org, Chen-Yu Tsai <wenst@chromium.org>,
Miles Chen <miles.chen@mediatek.com>
Subject: Re: [PATCH v2 1/6] clk: mediatek: mt2712: fix memory leak on module removal
Date: Tue, 7 Jul 2026 10:47:17 -0400 [thread overview]
Message-ID: <ak0RdSkV71J1_1By@redhat.com> (raw)
In-Reply-To: <20260707074839.240676-2-akkun11.open@gmail.com>
On Tue, Jul 07, 2026 at 04:48:30PM +0900, Akari Tsuyukusa wrote:
> clk_mt2712_apmixed_probe() in clk-mt2712-apmixedsys.c does not call
> platform_set_drvdata(), but clk_mt2712_apmixed_remove() callback calls
> platform_get_drvdata().
> This results in platform_get_drvdata() returning NULL, which leads to
> calling kfree(NULL) in mtk_free_clk_data(NULL).
> This leaves clk_data unreleased, causing a memory leak.
>
> Fix this by calling platform_set_drvdata() during probe.
>
> Fixes: c6368ce86435 ("clk: mediatek: mt2712-apmixedsys: Add .remove() callback for module build")
> Cc: stable@vger.kernel.org
> Signed-off-by: Akari Tsuyukusa <akkun11.open@gmail.com>
Reviewed-by: Brian Masney <bmasney@redhat.com>
next prev parent reply other threads:[~2026-07-07 14:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 7:48 [PATCH v2 0/6] clk: mediatek: fix memory leak on module removal Akari Tsuyukusa
2026-07-07 7:48 ` [PATCH v2 1/6] clk: mediatek: mt2712: " Akari Tsuyukusa
2026-07-07 14:47 ` Brian Masney [this message]
2026-07-07 7:48 ` [PATCH v2 2/6] clk: mediatek: mt6795: " Akari Tsuyukusa
2026-07-07 14:47 ` Brian Masney
2026-07-07 7:48 ` [PATCH v2 3/6] clk: mediatek: mt7622: " Akari Tsuyukusa
2026-07-07 14:47 ` Brian Masney
2026-07-07 7:48 ` [PATCH v2 4/6] clk: mediatek: mt8135: " Akari Tsuyukusa
2026-07-07 14:47 ` Brian Masney
2026-07-07 7:48 ` [PATCH v2 5/6] clk: mediatek: mt8173: " Akari Tsuyukusa
2026-07-07 14:48 ` Brian Masney
2026-07-07 7:48 ` [PATCH v2 6/6] clk: mediatek: mt8192: " Akari Tsuyukusa
2026-07-07 14:48 ` Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak0RdSkV71J1_1By@redhat.com \
--to=bmasney@redhat.com \
--cc=akkun11.open@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox