From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8556FC43458 for ; Tue, 7 Jul 2026 20:32:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H35h3WmMjNx5Te0fV3LGaX0YlCHWBQl/br6tE0lP+k8=; b=FBHhDwgFRctWk7n5j8s0poz8qB UO0Lo5xrD1RbsKAoLBu0F/sfA3t/++WC1q3SlagBkXS7nlb1yrSsf+dLYV8ggIwLzOYmrtq4HtBme lD5N+ni0OGZiSnTdA3QP//ZkuWtcwTJSwg9yau0Y3CbDKCI5cLx/zGUQ4O+sCrjmh4DARN/bMv21q RmMTRyLOuWddBMk1qwWDKgSplYO3H+WW1akFT9YeyB9J8WCqBP4sMpaV1gavJO40OiboLC147nBHz gj03D7JcwJ0xQDxQijir5JwBFXuz0vPR9pQAMRfgJp0Z/T83DvaPxQa7UZcoHwkZRnyIR2V9fKtX4 a+JXUYIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whCSz-0000000Frfl-0wDz; Tue, 07 Jul 2026 20:32:29 +0000 Received: from mail-eastus2azlp170100001.outbound.protection.outlook.com ([2a01:111:f403:c110::1] helo=BN1PR04CU002.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whCSw-0000000FrfK-24Y0 for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2026 20:32:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eQH8BUGrYmRCF+QcyZixvjhPGrVIKUDDmt81FZoIBwop6Z8oCEFIEFn/avWox13A+x4K4EyK+hEbf05zOutOh5PxrhQMP19XU5yAerLLsKPMXGXkJV9EWGisCGN2COOl3M8v/UbSbuPShy/3fiFnKztAspkKK3bDKid5Aj2vvZ5oKrCrhxfP43EuTgonvHw23Uw6SAZkFRfCRuYRhWzxao+JPICNnbcpt9d5mjh2yhnskcHR28mUdI9MssIGniIHblqfy4fLC6nfQLoz9sY0GCYQ919H5kBL4/sWbUYxxB/XTjht/bJ8vAcSw27WWC6HlIYqr6v/JpRao2Y3dAEucA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H35h3WmMjNx5Te0fV3LGaX0YlCHWBQl/br6tE0lP+k8=; b=fF9XVIbXtMIwViVFe94vqh+bJjwyhsTMeLraoi9arR0SipCG/xWkYqYwk0GTnl5VjkyTBgV7EYXKgjkHVhhFQiJ2FJPq0LafpOyrsn+hU52lr49GrRh96XHpCjo1wxDdmeWwFYmh7GitkvyDQJQOZCK/UrQFBUH8qP3+gkz9bRIQsBX2UG67K3cSaObDxciNCRHPo+A9vsRAKFF+nyiqFBPgT1bUalZQuwORiKHbFCDBO58mKHvahqo/G+oXGYbwKaKguXp+NfHHQBMNkRySxsHTrdaZIOjaQXHT1tcWkjcEh4J9RV7nqBeH7yCeS4UnlIBdY2QRmK4/brMYErjDfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=lists.linux.dev smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H35h3WmMjNx5Te0fV3LGaX0YlCHWBQl/br6tE0lP+k8=; b=fdDMsEalD6Tfvw7LPA8McSzW3JTKOte1oWbwswv31NJeiYKxJDHvH2Zy6+cBM+Dr0jO7JQ+Jes/cMucQ+9IKDrPZV/kEmsDQYC9nK599pOO3HFDeTuNoS3HIhNDeturOHIsApGEcLc6uZLKSdXJmMO3pt1F7/xFGS4N2Jg8yAhv8B2FR+3HjjQ64MoJDObnihTaa56/I9XqJFIHpUceUMeVQmh6vkus8lcMAOZ6PAOL96P6/98X/dswLiTfwsuJw3a/rW0nsNnPImVpPezZUAzY9dD9nCSXHUCJbC7fvqv1VODTD5PioXoF8eMvciUsI64v6c4+mJYlMN7mZcNR2+w== Received: from CH0PR03CA0202.namprd03.prod.outlook.com (2603:10b6:610:e4::27) by DS5PPFA33D606F8.namprd12.prod.outlook.com (2603:10b6:f:fc00::65b) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.13; Tue, 7 Jul 2026 20:32:17 +0000 Received: from CH1PEPF0000A347.namprd04.prod.outlook.com (2603:10b6:610:e4:cafe::79) by CH0PR03CA0202.outlook.office365.com (2603:10b6:610:e4::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.9 via Frontend Transport; Tue, 7 Jul 2026 20:32:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CH1PEPF0000A347.mail.protection.outlook.com (10.167.244.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.6 via Frontend Transport; Tue, 7 Jul 2026 20:32:16 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Tue, 7 Jul 2026 13:31:56 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 7 Jul 2026 13:31:55 -0700 Received: from Asurada-Nvidia (10.127.8.10) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Tue, 7 Jul 2026 13:31:55 -0700 Date: Tue, 7 Jul 2026 13:31:53 -0700 From: Nicolin Chen To: Jason Gunthorpe CC: , "Joerg Roedel (AMD)" , Jean-Philippe Brucker , , Robin Murphy , Will Deacon , David Matlack , "Pasha Tatashin" , , "Pranjal Shrivastava" , Samiullah Khawaja , Mostafa Saleh Subject: Re: [PATCH v2 5/8] iommu/arm-smmu-v3: Precompute the invalidation commands Message-ID: References: <0-v2-43074a57a53a+fb95-smmu_tlbi_jgg@nvidia.com> <5-v2-43074a57a53a+fb95-smmu_tlbi_jgg@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5-v2-43074a57a53a+fb95-smmu_tlbi_jgg@nvidia.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A347:EE_|DS5PPFA33D606F8:EE_ X-MS-Office365-Filtering-Correlation-Id: f9578ac3-5f1a-46b6-a5c3-08dedc66d5e6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|82310400026|1800799024|23010399003|36860700016|4143699003|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: e7pVy34+sQr35pqc3uyNaD8AaJzdJsHV6VGxpqJcG5F/FlOkoRtGXBvYyzs7XWBys+pM68WaUyas39rr9CJaPTLlWwPf4Zw9T3no+46b0d8eM26BLZwHEAYI6ppa7+DFrzisWfarXTxKwcUlFddUaAX4Dfn2sCCjIjhwDB6TxKe4ZL/1p3GjfEakgG9FQZnOlJEcWuxTteYDzFvN/XAz7iNB8g1m3zHjMiJGrhd1Fwr8BLKUdZDRZj8bp9Qny6BqhGgea7iGimvCLSKfYRgNjKg9nDc8wdU6Xzb89E6zBUWiBgN6tfPq9bWvmWdI6p6n5B4+w+RBlS0cDd6JB9kTYl/lfqJN9YQ/dtW9SYZnHV8b2LVfpjGDg/fJUQr9sCUKwylOliJlryHRdI+05IEy7KHWrQkDAVTb8zSDbLjIegSseNZ5kGj99Hebw/zoxKm4PNiFoSRod7A76MT+To8Lzgrisb3yiPZBfQGT2MfnEKih/6xpChVLNAhjHuK9Ql5qGl+PIa7CyAFgruS8oa9wvExqSiRQqDe/r60naksqlP0YaDNgMlW5hl1b9K3ldlqbz3ioVCL/8kKGtc8spi9BK0ZmI1gRK4v2tYDs00wHAfgimT+hKSsAsTJQp+QaPNTARZ6lQa/6ms54zyHEjqUYXcDmaZkwRADEs7PLMEhF2StWZkkIzPWE4sZ5pCrB3DssrFIkoAcs9elKxt+9XWPHQQ== X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(7416014)(376014)(82310400026)(1800799024)(23010399003)(36860700016)(4143699003)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: I7EG3n12OcR3txj+9h6jmPBSMtr2Pg0I77HlImvyNNy3hXPkmfB3d+h4NSjE1YHFrLV2ThIa8NzQYCQ1AVKvzNQmwLzx24VYJ3sVOe9IbBdjzpdCbk+LoItz7KFrJNKANmXndk0su36jH6ZzKie10JHHpv4LNOxd6/MBPsfmPAq4d4dy5zkDso8uEu6FnYRnWtx/5nQLdKwFt229ALYLCnJWMInHiFUEY7EH/UBIklOILUUSA2XAp9utm2yT5oSoqSenfpOWRqr/RTJ88g4LLauNgz/XdXqH78XoC7nc2J0I1/EzPXoavi+odEhtD7gNRzXCf+BJIyGlmDDjoFuOotpg8X5G2+n21CgiA1GBaESZkl86RfO3IPxmmPj3T5WwdfSSDd9kJQP9nG35EFjcrRK8a8QGrY2KhCB5rd4EaNRKNChV5KK/HtKGLsKJdbvD X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2026 20:32:16.5197 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9578ac3-5f1a-46b6-a5c3-08dedc66d5e6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A347.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS5PPFA33D606F8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260707_133226_567555_DF17A9D5 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 06, 2026 at 01:26:42PM -0300, Jason Gunthorpe wrote: > @@ -2471,10 +2451,13 @@ static bool arm_smmu_cmdq_batch_add_range(struct arm_smmu_device *smmu, > if (num_tg == 1) { > if (!ttl) > ttl = 3; > - arm_smmu_cmdq_batch_add_ril(smmu, cmds, cmd, tlbi->leaf_only, > - cur_tg << tg_lg2, 0, 0, ttl, > - tg_enc); > - return true; > + tlbi->range.data0 = 0; > + tlbi->range.data1 = > + FIELD_PREP(CMDQ_TLBI_1_LEAF, tlbi->leaf_only) | > + FIELD_PREP(CMDQ_TLBI_1_TTL, ttl) | > + FIELD_PREP(CMDQ_TLBI_1_TG, tg_enc) | > + (cur_tg << tg_lg2); > + return; > } [...] > + tlbi->range.data0 = > + FIELD_PREP(CMDQ_TLBI_0_NUM, > + DIV_ROUND_UP_ULL(num_tg, 1ULL << scale) - 1) | > + FIELD_PREP(CMDQ_TLBI_0_SCALE, scale); > + tlbi->range.data1 = FIELD_PREP(CMDQ_TLBI_1_LEAF, tlbi->leaf_only) | > + FIELD_PREP(CMDQ_TLBI_1_TTL, ttl) | > + FIELD_PREP(CMDQ_TLBI_1_TG, tg_enc) | > + (cur_tg << tg_lg2); Could this be slightly cleaner: unsigned int num = 0, scale = 0; ... if (num_tg == 1) { if (!ttl) ttl = 3; goto build; } scale = fls64((num_tg - 1) / 32); num = DIV_ROUND_UP_ULL(num_tg, 1ULL << scale) - 1; build: tlbi->range.data0 = FIELD_PREP(CMDQ_TLBI_0_NUM, num) | FIELD_PREP(CMDQ_TLBI_0_SCALE, scale); tlbi->range.data1 = FIELD_PREP(CMDQ_TLBI_1_LEAF, tlbi->leaf_only) | FIELD_PREP(CMDQ_TLBI_1_TTL, ttl) | FIELD_PREP(CMDQ_TLBI_1_TG, tg_enc) | (cur_tg << tg_lg2); ? > @@ -2711,6 +2711,14 @@ void arm_smmu_domain_inv_range(struct arm_smmu_domain *smmu_domain, > rcu_read_lock(); > invs = rcu_dereference(smmu_domain->invs); > > + /* Only precaculate RIL if it will be used. */ precalculate > + if (invs->has_range_inv) { > + if (!tlbi.range.use_full_inv) > + arm_smmu_tlbi_calc_range(&tlbi); > + } else { > + tlbi.range.use_full_inv = true; I am a bit unsure about this line since invs has no RIL entry. Is it set for a defensive reason? Nicolin