From: Frank Li <Frank.li@oss.nxp.com>
To: Pan Chuang <panchuang@vivo.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<imx@lists.linux.dev>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 18/18] thermal/drivers/imx91: Remove redundant dev_err_probe()
Date: Wed, 8 Jul 2026 22:38:45 -0500 [thread overview]
Message-ID: <ak8Xxby0y6hFr1wq@SMW015318> (raw)
In-Reply-To: <20260709023048.599150-19-panchuang@vivo.com>
On Thu, Jul 09, 2026 at 10:30:21AM +0800, Pan Chuang wrote:
>
> The devm_request_threaded_irq() now automatically logs detailed error
> messages on failure. This eliminates the need for driver-specific
> dev_err_probe() calls that previously printed generic messages.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/thermal/imx91_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/imx91_thermal.c b/drivers/thermal/imx91_thermal.c
> index 25915bb702be..274eee303142 100644
> --- a/drivers/thermal/imx91_thermal.c
> +++ b/drivers/thermal/imx91_thermal.c
> @@ -331,7 +331,7 @@ static int imx91_tmu_probe(struct platform_device *pdev)
> IRQF_ONESHOT, "imx91_thermal", tmu);
>
> if (ret < 0)
> - return dev_err_probe(dev, ret, "failed to request alarm irq\n");
> + return ret;
>
> pm_runtime_put(dev);
>
> --
> 2.34.1
>
>
prev parent reply other threads:[~2026-07-09 3:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260709023048.599150-1-panchuang@vivo.com>
2026-07-09 2:30 ` [PATCH 05/18] thermal/drivers/imx: Remove redundant dev_err() Pan Chuang
2026-07-09 3:38 ` Frank Li
2026-07-09 2:30 ` [PATCH 08/18] thermal/drivers/rockchip: Remove redundant dev_err_probe() Pan Chuang
2026-07-09 2:30 ` [PATCH 09/18] thermal/drivers/brcmstb_thermal: " Pan Chuang
2026-07-09 2:30 ` [PATCH 12/18] thermal/drivers/mediatek/lvts_thermal: Remove redundant dev_err() Pan Chuang
2026-07-09 2:30 ` [PATCH 15/18] thermal/drivers/exynos: " Pan Chuang
2026-07-09 2:30 ` [PATCH 16/18] thermal/drivers/st: " Pan Chuang
2026-07-09 7:33 ` Andy Shevchenko
2026-07-09 2:30 ` [PATCH 18/18] thermal/drivers/imx91: Remove redundant dev_err_probe() Pan Chuang
2026-07-09 3:38 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak8Xxby0y6hFr1wq@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=daniel.lezcano@kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=panchuang@vivo.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox