Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Stefano Radaelli <stefano.radaelli21@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	pierluigi.p@variscite.com,
	Stefano Radaelli <stefano.r@variscite.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v5 06/14] arm64: dts: imx8mp-var-som-symphony: enable PCIe
Date: Mon, 29 Jun 2026 13:25:02 -0500	[thread overview]
Message-ID: <akK4fubaHtjViXtr@SMW015318> (raw)
In-Reply-To: <akKf_akO7IZ2ltHd@Lord-Beerus.station>

On Mon, Jun 29, 2026 at 06:40:29PM +0200, Stefano Radaelli wrote:
> Hi Frank,
>
> On Mon, Jun 29, 2026 at 12:30:09PM -0400, Frank Li wrote:
> >
> > You have to provide all clocks, otherwise, whole clocks and clock-names will
> > by overwrite with one clock "ref".
> >
> > suppose CHECK_DTBS should report warning about clocks items.
> >
> > Frank
> >
>
> thanks for checking.
>
> In this case the SoC dtsi does not provide any clocks or clock-names for
> the PCIe PHY node, so this is not overriding an existing clock list. It
> only adds the external reference clock used by the board.
>
> This follows the same pattern used by the i.MX8MP EVK, where the PCIe
> PHY node only provides the external "ref" clock together with
> fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>.
>
> This is also why CHECK_DTBS does not report any warnings for this node.

Oh! I missed think it is pcie node.

Frank

>
> $: sed -n '/^&pcie_phy {/,/^};/p' arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> &pcie_phy {
>         fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
>         clocks = <&pcie0_refclk>;
>         clock-names = "ref";
>         status = "okay";
> };
>
> Thanks,
> Stefano


  reply	other threads:[~2026-06-29 18:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08 14:41 [PATCH v5 00/14] arm64: dts: imx8mp-var-som-symphony: align DTS with hardware revision Stefano Radaelli
2026-06-08 14:41 ` [PATCH v5 01/14] arm64: dts: imx8mp-var-som-symphony: add input keys Stefano Radaelli
2026-06-08 14:41 ` [PATCH v5 02/14] arm64: dts: imx8mp-var-som-symphony: enable USB support Stefano Radaelli
2026-06-08 14:41 ` [PATCH v5 03/14] arm64: dts: imx8mp-var-som-symphony: add TPM support Stefano Radaelli
2026-06-08 14:41 ` [PATCH v5 04/14] arm64: dts: imx8mp-var-som-symphony: add external RTC Stefano Radaelli
2026-06-08 14:41 ` [PATCH v5 05/14] arm64: dts: imx8mp-var-som-symphony: enable header UARTs Stefano Radaelli
2026-06-08 14:41 ` [PATCH v5 06/14] arm64: dts: imx8mp-var-som-symphony: enable PCIe Stefano Radaelli
2026-06-29 16:30   ` Frank Li
2026-06-29 16:40     ` Stefano Radaelli
2026-06-29 18:25       ` Frank Li [this message]
2026-06-08 14:41 ` [PATCH v5 07/14] arm64: dts: imx8mp-var-som-symphony: add HDMI support Stefano Radaelli
2026-06-08 14:41 ` [PATCH v5 08/14] arm64: dts: imx8mp-var-som-symphony: add capacitive touchscreen Stefano Radaelli
2026-06-08 14:41 ` [PATCH v5 09/14] arm64: dts: imx8mp-var-som-symphony: enable ECSPI2 Stefano Radaelli
2026-06-08 14:41 ` [PATCH v5 10/14] arm64: dts: imx8mp-var-som-symphony: keep RGB_SEL low Stefano Radaelli
2026-06-08 14:41 ` [PATCH v5 11/14] arm64: dts: imx8mp-var-som-symphony: enable PWM1 Stefano Radaelli
2026-06-08 14:41 ` [PATCH v5 12/14] arm64: dts: imx8mp-var-som-symphony: enable CAN Stefano Radaelli
2026-06-08 14:41 ` [PATCH v5 13/14] arm64: dts: imx8mp-var-som-symphony: add second Ethernet port Stefano Radaelli
2026-06-08 14:41 ` [PATCH v5 14/14] arm64: dts: freescale: imx8mp-var-som: add I2C1 bus recovery GPIOs Stefano Radaelli
2026-06-29 16:34 ` (subset) [PATCH v5 00/14] arm64: dts: imx8mp-var-som-symphony: align DTS with hardware revision Frank.Li
2026-06-29 19:27 ` Frank.Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akK4fubaHtjViXtr@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierluigi.p@variscite.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=stefano.r@variscite.com \
    --cc=stefano.radaelli21@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox