From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81CEDC43458 for ; Mon, 29 Jun 2026 15:11:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oDDQbVpOVOskc2PVp7AfDLUF0qTl57ClIgX0lnpBJd4=; b=WXHLjOJvffecRPTe60dcBUd5SV KftgSrqcTfUyf9lUf3s9VgFGE/abAgGpKjsx/l/qXFNX9RVeAR5BpfpYKVVl9eVYRBT6mQpBGIt2N qjMIU4YpTyk/up3nd+C1g5mrXcol3i0P8W+draAIRtsk2OWz7jjYEEERDbUDdtkbkZz/qrviwp2ui C4fYcUrs6hw4Wn84fpWIY6OSSwlGKbfjAA6/2oRcsFvmXTK55KKGNf0/CS9/b/a0Ge0gs0XqnPPtI QuHfnZ2WuyAUvFswV7o235kHGpCz9RyXSEn+SB0uguwq8MMbyCBP8eq/FZ9F7OzT6SshlERzFSzGg y7ahec3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1weDdU-0000000F1rS-07tD; Mon, 29 Jun 2026 15:11:00 +0000 Received: from mail-westeuropeazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c201::3] helo=AS8PR04CU009.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1weDdS-0000000F1r5-0DuF for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2026 15:10:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SUhW6cnzL24cbCpYWiQMghqzNq/CpVcmjHJDnl6LvBiD5vHAIfqaBEwZObxArTs4FnjYM+mS3wn56Q61fb8RFmk7bBhFOByfbAbvgSy/NHi6AVTniE823FHOILUdH5TQsMIqXyKj4uIM41xLJwlnMgef1x8VwOuIc9UdnGevFnIC19bEwQ+bsoYEaOGwrtmX8BOjvzfT78a6hZdaNyxRbOXthbnvTCY++umvDlDR9wdnabU0/Sxu3y1NMLmwr/AyZdy4ag472VxuuQVtGVVWTLxSJMhXYrCZgU+TriqFd00qEDRU2AZPZv9M8Wo0FqA7sLsPqA7lO337+Mk52FNiKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oDDQbVpOVOskc2PVp7AfDLUF0qTl57ClIgX0lnpBJd4=; b=xywr42VSikKTBpbPJImp6gDT3sc5QyBS46EM9a9OWfzzP5rlFWeq78fuD0YiaEmD3BONqh6tZ3ecMdf8Vu5aBmnjiF5u8zIDioNLy1fWwuGTdOEvU+EyyjY9TZfAH2IVE7gyJrwEp7gcxVNchlBr3t1aWVXj8Z4NkEuibo06lgKcrWdGd7JtX0dIAZZDTp7V//M3zbFbUblC43h+Ql0ueW+7QjRGhlZp6X6gur7rrk7DoejV0/88H5aBfdDDU6+JL6Q4iCYbyTFNSn8xz0qcj4dJ5Ey4WHYLWw0sK4GtTNaoVhpte49efWkx/RYVFTUbt5r8xAh3R6OjO/LlOGsDGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oDDQbVpOVOskc2PVp7AfDLUF0qTl57ClIgX0lnpBJd4=; b=Pk0ArWek1tb5Wi4g4e2XbX2VRFZ1iCenJMJT8IvWO4TCz0gwjxGFaq9A+m5LcdwQkwt0rLV6+PhA+4mvZYlWnu6ViqicPZV/I+U2/ZXF0rXa2FIlkkn4UHtlemKygYvTg4s3NW091zKGBMgK1McYA7Uku37lDqNNzlwcpvqEESPltiMdz3inxshO7CjR2iGBKpeuUSh8GHrGlbHIJEUntut5sJuPsWjVB+vxlPMHUsghzLPl1xzLi2juP8lpJhNBa1qi656OmiPU2/X95h258cURWbkYZyX5jRWz9h6pwcTsvj/rqatAKc07xEiB7vnmZSFmY8dSUvW1bKDMSnrPhg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) by DBBPR04MB7850.eurprd04.prod.outlook.com (2603:10a6:10:1e8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.19; Mon, 29 Jun 2026 15:10:52 +0000 Received: from GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c]) by GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c%6]) with mapi id 15.21.0159.007; Mon, 29 Jun 2026 15:10:52 +0000 Date: Mon, 29 Jun 2026 10:10:41 -0500 From: Frank Li To: Laurent Pinchart Cc: Laurent Pinchart , Mauro Carvalho Chehab , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Christian Hemp , Stefan Riedmueller , Jacopo Mondi , Dong Aisheng , Guoniu Zhou , linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras Subject: Re: [PATCH 5/5] media: nxp: imx8-isi: Add additional 32-bit RGB format support Message-ID: References: <20260629-isi-v1-0-deebfdb1b07b@oss.nxp.com> <20260629-isi-v1-5-deebfdb1b07b@oss.nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260629-isi-v1-5-deebfdb1b07b@oss.nxp.com> X-ClientProxiedBy: SA1P222CA0005.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:22c::32) To GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR04MB11799:EE_|DBBPR04MB7850:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e4bb698-0723-4272-cdaa-08ded5f09c12 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|19092799006|7416014|23010399003|6133799003|3023799007|22082099003|18002099003|56012099006|11063799006|4143699003; X-Microsoft-Antispam-Message-Info: XmC2Bxe3duDZzz1QsjbXuf4zXAewi6csd8lJ8nM6twGs5M7COF/s6l+PMukEyGua0VXHJRHsUepV8BewVs7ogTuySBV3+CjiulYmy+Pb7bG7v4zesbbiiVwHoQOpqoZij5Zy9U9Y3x8Sz2vZf2bPD5Ajv/DSR4hYr2rZtiCNR6isieKEKppiWAcIol9mm5AxgfwI9V4VOhLUkuyEz82avyt2E4rT9+GPpavW41Ho+WRMuePQxieDgOFNcxhS65rpu7Aywv7MU8Dp9b0hNkbW62diTSzFMUp3FL52dqGIba6SHRXMEqE93Px9Vk3sK/FJWua3j+dURJEoP/4868xfGH4MLVBCvGFk/9KYlvPdSwhLkMcu8vqVh+SYYgwi+4qJRWAcIg++LS70yKoQ5ZOfK1IflzAnzUmeGBTZUDsiWabWwqPLj+cswhzP4lVmlrrJNEpxHUaThpIBm7nTm5fLlzrGpUPTUGpG9rrFdAhlTDLz7u/aG/LKe+UQSpsTG4M6yPjNiZBVk2rUoP2MeWCJ4DV2LlwcVnVwQSsfylPHcCx2vv9mnKOS0LqpoPg67SNidH+pt2dNzhdpNenJ2FAWKZdZBJ5sJzUPJNLGGbYO8odFAYEfLxWBnZCPGWQg1+xsLGxoZFqCAk/EH+dJ6nhNyab9oqrJo8yJFfneHZaq/ys= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR04MB11799.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(19092799006)(7416014)(23010399003)(6133799003)(3023799007)(22082099003)(18002099003)(56012099006)(11063799006)(4143699003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QNHHzhGzNGgr5ABWDn+jLWu6ipw9+BXH3z1NDSFkbcof2dt+OFIuTFAZy4pa?= =?us-ascii?Q?QTbvx08xVVaA/IKezBKbHwDrcFDnZWw6GZCCFPImCCM0Cmb6WP653tDnNbJr?= =?us-ascii?Q?zDma+xbdaSBF21YnKcNhZR3FJtw7wnOPviFQAoY8tCe6SR2XY7Fov3cxBnC1?= =?us-ascii?Q?yyubQJHMsl8iZ9wXFzf9MU5nK6zEZm3ForQYGUjxb5cs5pcON24hDO20DtZz?= =?us-ascii?Q?crFducXmL19lWz5Tn17/12dOVyoAJklWuoMPHrps4yhWyV4F38IKoS4Ju5Gw?= =?us-ascii?Q?yTeyWtewbuulqWmY1pch8ApCmOtujPjrl4fMDjCWD19zOQUh/QoPK9PG73y0?= =?us-ascii?Q?fFn02iWCOWpk76DIAu+vtPMWyxJsweoywi6cZKRx+mLH/IYGHdLkGTn7YEMV?= =?us-ascii?Q?xXTQzBnezNQFVHlFVJg3DR2poJh21fWTNpk3IeZeUAgaaHY+gTmivRZ9Q/+F?= =?us-ascii?Q?xGv/pRvCkClr5DHuXYtWKtkicwJs8d7Se95FIPGULfpWJRGerDWwE4UxFNIF?= =?us-ascii?Q?q6hgqmj67CRZhS8IFN8kT64yTXBvQGKCoxz8r465z5gHbD35to3wp5x6mLWh?= =?us-ascii?Q?85ofi+t7yblQ2QqT6eIoL0KeXBuc0CgThkqp+sYsv/fWawn2JViEVvjVsXh7?= =?us-ascii?Q?fyh6e3Qe1ly5IFEltW7+a36aFXPOWcp2WFYm1ODGrbYMC9GYaGPBj+mRBLV5?= =?us-ascii?Q?EbqRaIBwpn7jxxz4fZp63NfQvuRREadldTWXbo1/P1KyxUVdDiFazY/CIZRb?= =?us-ascii?Q?au+xaQhuk9OA7fc0c0t6UAb4f4lQoaHS/k+X3hVMaY/3PF5Iu5vTiQiPhmTx?= =?us-ascii?Q?yULu+8djcWo0MSJhQ8QQ58KR9F+lc8hL+HYbwL0YLF3ZLU8cOffrYVsKnD/b?= =?us-ascii?Q?O8ZXcLnOSvge15TiZhxp3pM80MFa5ROaLQd8cfC6m4krM13EacOgkklsJbAI?= =?us-ascii?Q?hBXXKtJeqlVniMrsi3M/DMhc7AO589vJZSe1fUkGVk6XDoSCFYF2mPoQHjvr?= =?us-ascii?Q?oeHR7lurW63dchC2ole6KVz58TEUwdR7/1Hd1oxoWQ632zLubZzTuTfvtXy8?= =?us-ascii?Q?yiLfgKt6kdNYin18nJc9AQRsrRJ8kVeaHmoysrKHz3wau1Eqc6ir4Sox/5WF?= =?us-ascii?Q?QyOpk8/lHEhRd3pMJ1kQNEY+UymNe50PGCEkZbBigzjbzV/OGydSvMC/tVoD?= =?us-ascii?Q?vxF6k12Ejjd6Nly4N6/TTtKXwuMp7XkDsUCWKkVBlUYCEnIQ6e98KOFQbSAN?= =?us-ascii?Q?wtrzL2+3CjW/1qQSUgh85q/sff9Ilvtfd10gvOyecpCsXUye5hSn7sVwxdf9?= =?us-ascii?Q?5sy1z8t3TG+pmeoxCkbTotAtLEDHW2dvXjbsgMnW0YV06/rMujii02DapxOu?= =?us-ascii?Q?H5iy1B0DwOkVGVHJaCxJtQeSoz6saCZLOeFOUTjYCHJ+hqAWVgi+hHad4Uzt?= =?us-ascii?Q?bbGNsUFK3OJFh77cj8wEtyJ27VBsqtLOG3qikEJeQjoviw03MvmRpWmy+LVJ?= =?us-ascii?Q?0KD+pxcsMlS8G/oxYycEt/oisnIlLG9U29mEmiVOIMpTYR/XAB/qaOq1YF39?= =?us-ascii?Q?tFsZoX3kMuHPuH+7dtKEuLAvD7/uZEiNe3yPZAjWPypJjF/Lswc5OyJFSMYl?= =?us-ascii?Q?q9gNfypWvEbsoZmoUH65IC3HhVNO+7m5EnqpYvtXEyXVAnrdDascpYVx56zo?= =?us-ascii?Q?xHv7Lad2a4EBzSBFwoe/dJM47/ghfCefDYj+8kIpOVBMGK03AocfKCJuvmol?= =?us-ascii?Q?QmTRCZ6916/3+x9rJRMIiVMjlN1qv+3BE9HdzW6orDguen0mBmzi?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e4bb698-0723-4272-cdaa-08ded5f09c12 X-MS-Exchange-CrossTenant-AuthSource: GV2PR04MB11799.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2026 15:10:52.4112 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PhtMMGUrr7nBGrqTWLjbO/Lot0Pk/09/5FXVPPVi78pTwxtwZ0M7bREYi5Bvtoh74xeQ7tvs3NaT8tPvRHr1qqZXPYMQfsqfZGAHZk4d/z0nZpLwp9TmxkFY7EZhiJL7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7850 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260629_081058_096625_B1233F82 X-CRM114-Status: GOOD ( 15.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2026 at 03:44:59PM +0800, Guoniu Zhou wrote: > Add support for additional 32-bit RGB pixel formats (BGRA32, RGBA32, > BGRX32, RGBX32, ARGB2101010) and extend existing ABGR32 format with > full memory-to-memory capabilities to meet Android requirements. > > All formats support capture, M2M input, and M2M output operations, > enabling complete format conversion pipelines. > > Signed-off-by: Guoniu Zhou > Signed-off-by: Robert Chiras > --- Reviewed-by: Frank Li > .../media/platform/nxp/imx8-isi/imx8-isi-video.c | 59 +++++++++++++++++++++- > 1 file changed, 58 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c > index 05b51b98344b..ef638af350fe 100644 > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c > @@ -160,12 +160,69 @@ static const struct mxc_isi_format_info mxc_isi_formats[] = { > }, { > .mbus_code = MEDIA_BUS_FMT_RGB888_1X24, > .fourcc = V4L2_PIX_FMT_ABGR32, > - .type = MXC_ISI_VIDEO_CAP | MXC_ISI_VIDEO_M2M_CAP, > + .type = MXC_ISI_VIDEO_CAP | MXC_ISI_VIDEO_M2M_OUT > + | MXC_ISI_VIDEO_M2M_CAP, > + .isi_in_format = CHNL_MEM_RD_CTRL_IMG_TYPE_XRGB8, > .isi_out_format = CHNL_IMG_CTRL_FORMAT_ARGB8888, > .mem_planes = 1, > .color_planes = 1, > .depth = { 32 }, > .encoding = MXC_ISI_ENC_RGB, > + }, { > + .mbus_code = MEDIA_BUS_FMT_RGB888_1X24, > + .fourcc = V4L2_PIX_FMT_BGRA32, > + .type = MXC_ISI_VIDEO_CAP | MXC_ISI_VIDEO_M2M_OUT > + | MXC_ISI_VIDEO_M2M_CAP, > + .isi_in_format = CHNL_MEM_RD_CTRL_IMG_TYPE_RGBX8, > + .isi_out_format = CHNL_IMG_CTRL_FORMAT_RGBA8888, > + .mem_planes = 1, > + .color_planes = 1, > + .depth = { 32 }, > + .encoding = MXC_ISI_ENC_RGB, > + }, { > + .mbus_code = MEDIA_BUS_FMT_RGB888_1X24, > + .fourcc = V4L2_PIX_FMT_RGBA32, > + .type = MXC_ISI_VIDEO_CAP | MXC_ISI_VIDEO_M2M_OUT > + | MXC_ISI_VIDEO_M2M_CAP, > + .isi_in_format = CHNL_MEM_RD_CTRL_IMG_TYPE_XBGR8, > + .isi_out_format = CHNL_IMG_CTRL_FORMAT_ABGR8888, > + .mem_planes = 1, > + .color_planes = 1, > + .depth = { 32 }, > + .encoding = MXC_ISI_ENC_RGB, > + }, { > + .mbus_code = MEDIA_BUS_FMT_RGB888_1X24, > + .fourcc = V4L2_PIX_FMT_BGRX32, > + .type = MXC_ISI_VIDEO_CAP | MXC_ISI_VIDEO_M2M_OUT > + | MXC_ISI_VIDEO_M2M_CAP, > + .isi_in_format = CHNL_MEM_RD_CTRL_IMG_TYPE_RGBX8, > + .isi_out_format = CHNL_IMG_CTRL_FORMAT_RGBX888, > + .mem_planes = 1, > + .color_planes = 1, > + .depth = { 32 }, > + .encoding = MXC_ISI_ENC_RGB, > + }, { > + .mbus_code = MEDIA_BUS_FMT_RGB888_1X24, > + .fourcc = V4L2_PIX_FMT_RGBX32, > + .type = MXC_ISI_VIDEO_CAP | MXC_ISI_VIDEO_M2M_OUT > + | MXC_ISI_VIDEO_M2M_CAP, > + .isi_in_format = CHNL_MEM_RD_CTRL_IMG_TYPE_XBGR8, > + .isi_out_format = CHNL_IMG_CTRL_FORMAT_XBGR888, > + .mem_planes = 1, > + .color_planes = 1, > + .depth = { 32 }, > + .encoding = MXC_ISI_ENC_RGB, > + }, { > + .mbus_code = MEDIA_BUS_FMT_RGB888_1X24, > + .fourcc = V4L2_PIX_FMT_ARGB2101010, > + .type = MXC_ISI_VIDEO_CAP | MXC_ISI_VIDEO_M2M_OUT > + | MXC_ISI_VIDEO_M2M_CAP, > + .isi_in_format = CHNL_MEM_RD_CTRL_IMG_TYPE_A2RGB10, > + .isi_out_format = CHNL_IMG_CTRL_FORMAT_A2RGB10, > + .mem_planes = 1, > + .color_planes = 1, > + .depth = { 32 }, > + .encoding = MXC_ISI_ENC_RGB, > }, > /* > * RAW formats > > -- > 2.34.1 > >