From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD31BC43458 for ; Tue, 30 Jun 2026 10:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l9SL8R5pEbjxBdf+8DQTqZyCZwqkLJ32+aB1uZ3l+Ro=; b=GGnF2DDjkc2WnRTsRdNEBcdjK2 8nnCfTNr30yxr5iZNa945u829O0oC06lef23PG215xwj43hYMkM+kxTKAW7Gyb6tmIPzLN5+nRnxu IfmTjusvTZovKL2LL8dpERb+c045rYLZxj2KmTY5lMkFRGasAZ2g/LVIZpkfXnhZvEkcbB+3QVNDg DLRpkm8fRjYVSu/nlsFGIW/Bzn6qM3HQkQhCOfpcN+nOqJV1oqNXR9VZEjElEVrByaGtWH6Won6s7 iyF17X9yG2HeBpMSWrtDkA2yxbda/9GDwbWec2trt3hLpxv+rrklI4yYgWWgC2v/CVWlKvkLZigYP Ha6K1s4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1weW9P-0000000GjU7-1Pjx; Tue, 30 Jun 2026 10:57:11 +0000 Received: from fhigh-b8-smtp.messagingengine.com ([202.12.124.159]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1weW9M-0000000GjST-26Ee; Tue, 30 Jun 2026 10:57:09 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.stl.internal (Postfix) with ESMTP id 53B227A00C0; Tue, 30 Jun 2026 06:57:06 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Tue, 30 Jun 2026 06:57:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1782817026; x= 1782903426; bh=l9SL8R5pEbjxBdf+8DQTqZyCZwqkLJ32+aB1uZ3l+Ro=; b=S wegdq5uzNFzdLJJp93UPx17nJOnWg8529wqVNzBkbp3XDp61otXP8NfbvVKxqkZd OjxqjrLg5GtKuyEe7M+Oztk5R/BtpNY0TY06DTyeeXMKX/aDMeMUj61mz6v1yAY/ 5Kt5NjBm4EWzq+pNkw1FqI8RmFMqvNEGao1ztL4K8B1jXG/mIZaMfaDcy6IV67jL DZTiqRmgB5BWGn04lI7xyKB2yawk2uoiOeVSYxbNEaPMu5v6rPLD2PzLL+LR4npt zFFDy+mmBP1REmvudOI42PJKiLu3vdkbgor8oD0DtS/pP/1rilDoCO4utKZohE54 xiGAKOJuoKjqQE4b/Xkzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1782817026; x=1782903426; bh=l9SL8R5pEbjxBdf+8DQTqZyCZwqkLJ32+aB 1uZ3l+Ro=; b=SI1juEUkKFMGapRt32a44VSy0d2Bs1AQC6DdrIkERgCFjCWFeBf qj3lvxK3XtdOdWvSQhAMBl3VjQFsomo/P07E0d7M/lK8dIlp6qQxKkdrdcvZJ729 vw9ZI+lanM3NrETebTXL5MkIqQKCZsf3XPcgPfZd8n58KcSkXBDvWOB8GFGQ66eC /hNylgVMWCh7WkJggRhlnpGYp3wsGexI9XbelSoXhT4pWWqtLG3f0Nn/mNk7fquF gTqHwpWX7eRM7xCkN352MQYYgqB+O7WXXfTiFKoWbFitRztHzsRoBpz2nyz+UwJO yFoEKMMSnqW1FMsZ0AvzIof4rw/SQLCJIqg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGsj2JEFwh+c3qskAhajKYGDnGT+piVrlQpL7p3qhdJubLNRCSiA7k5mGw8mX3hJd q0+DdbVacWPVC2/+xBx5vOTHH3RV0XN/qU6Mhc6J3KStcUs4J4XzFVpqrwPkYWYAnkXRmp oNkZkoLiWaTxznptZVPFmvvrGrsf4zU3tzZ/07VmgDMG9YmEHcjW4t1+wr6fO/tHnjzEcE 3vJLerl7c8VVIZiOo1YbTi6dADQZTfXt0CiWJGlirkNHOG0W5AEHkS92xkP8PhT6xI9GtL 37yk+WDzstddTcf4Jpy/VzrXOoBxkXfR9x/166eOmzaUuWQ54+F8cfM8ArwKqCsKo+2njA E1w+WuS0LxAtmnTjUKbl+BadBBUG4FdSRXc0fDNlGP/yIMjZ2q4YHm/OL/gqLecam22aQ6 xnGw4e3VK7SVU5mgV42Q/DNVejlldJ8qq1SIJNF26anuCwRdyJOtbgIe+N5/jcrr2Yvmmm j/34j4pKB3w7zbI4pb/zg4d2MM69OGBpLydd2aQw8548WAhBqaxRM8DcDZ1v1RKeuVO+g1 5EtwEv+NbaWmty9W8wucXSrIPGZdaTNoLSsuhwd4qBqm7W/MKLSUKxtidZFj4fAQweJfRZ 7jyFDZyY7C2jwDJwZBgnRwSUHA39PuWBbSRAspr7QouCbVCV+iV0zEuzg20A X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 30 Jun 2026 06:57:05 -0400 (EDT) Date: Tue, 30 Jun 2026 11:57:04 +0100 From: Kiryl Shutsemau To: Usama Arif Cc: Catalin Marinas , Will Deacon , James Morse , Mark Rutland , Marc Zyngier , Doug Anderson , Petr Mladek , Thomas Gleixner , Andrew Morton , Baoquan He , Puranjay Mohan , Breno Leitao , Julien Thierry , Lecopzer Chen , Sumit Garg , kernel-team@meta.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/4] firmware: arm_sdei: add sdei_is_present() Message-ID: References: <20260630104713.3847805-1-usama.arif@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260630104713.3847805-1-usama.arif@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260630_035708_583191_66DA2A94 X-CRM114-Status: GOOD ( 25.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 30, 2026 at 03:47:11AM -0700, Usama Arif wrote: > On Mon, 29 Jun 2026 16:07:15 +0100 Kiryl Shutsemau wrote: > > > From: "Kiryl Shutsemau (Meta)" > > > > invoke_sdei_fn() returns -EIO when no SDEI conduit was probed, and the > > core warns ("Failed to create event ...") on any registration that hits > > that. An optional consumer that registers an event from an unconditional > > initcall would therefore make every boot on a non-SDEI system emit that > > warning for what is simply absent firmware. > > > > Expose whether SDEI firmware is present so such a consumer can skip > > registration -- and the warning -- when there is nothing to talk to. > > > > Signed-off-by: Kiryl Shutsemau (Meta) > > Reviewed-by: Douglas Anderson > > --- > > Can this be merged in patch 3 where this function is actually used? I can do it either way. Standalone commit looks good to me. But if maintainer wants, I can fold it. > > drivers/firmware/arm_sdei.c | 10 ++++++++++ > > include/linux/arm_sdei.h | 3 +++ > > 2 files changed, 13 insertions(+) > > > > diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c > > index f39ed7ba3a38..c161cf263547 100644 > > --- a/drivers/firmware/arm_sdei.c > > +++ b/drivers/firmware/arm_sdei.c > > @@ -339,6 +339,16 @@ static void _ipi_unmask_cpu(void *ignored) > > sdei_unmask_local_cpu(); > > } > > > > +/* > > + * Was SDEI firmware probed and is it usable? Lets optional consumers skip > > + * registering an event -- and the warning a failed registration emits -- on > > + * systems with no SDEI. > > + */ > > +bool sdei_is_present(void) > > +{ > > + return sdei_firmware_call; > > sdei_firmware_call is a function pointer. The above is correct, but > can we make it sdei_firmware_call != NULL? I think that looks a lot better. Again, I don't care much, but checkpatch doesn't like comparison to NULL. -- Kiryl Shutsemau / Kirill A. Shutemov