From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FEE4C43458 for ; Wed, 1 Jul 2026 10:55:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xSBML2lf7smJCG24FWNKYYpKDN0LSQzwJKW+lnhg58k=; b=3cmYs89dGnaJ/c3xPAg3nWOsD2 hUeClfoAlaOR+6gSDGWBLUZIZZlKOptm0qU44Ku8/kVwO9wxjpXvuYrHXdr3J/gETcfg7BMCdddzs RewFKrZKG0d7S+IDJyq7jyPXrYMvzYlEi3ht6Vk8fx3XzBEara1WEeTVlHhbA0i0mUmSyyFCozjO/ YLN3/FFqmrKJIkpOFu2WfqKAMk4AtsyR9+T32HFu+ikRsbjqvfGJKYY6cvBR4UyPuwhJwQ/wsJyzw 7ud0a4ADOlEMR+OBoKxY7zOlOyXUYHg3JQNwtAhK6Bce1IJasHBsguqv4Xfem/sa3fJ3YzgsO3FW+ 2pRYv9jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wesbM-00000001NVz-0sw0; Wed, 01 Jul 2026 10:55:32 +0000 Received: from mgamail.intel.com ([198.175.65.9]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wesbI-00000001NUi-44h5; Wed, 01 Jul 2026 10:55:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782903329; x=1814439329; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ZjS6liPi1NdySjNIcGtNItMWzhUoGpTQ0kusW/xwebI=; b=RTtxY3kHH/HqrLn0kJRURsRtbxPLB7EPKRrDICJAx2ZU/mXyOE+fVEbM NKv12Ky4OMJjCTRqegGRYqmMQTxEJtaOJx2igkvxbEB6wJ+uRrMcfQ6YW kb9uOTSQJmZe5dXr3YWp29Fj7l0xlgLtzDJb8jGb0dAdyW8mqJRAyEg4h 2NLtIyUhW4FfiGJjfowRsL2ZCVV81AiU4RFbilQtzdU2NFFxQzGZq7chS A/dVTX88J0W3VQAJLieqLEVCFx7xmn9ooccgAU9ChRT8Yws/K2VdM6tOm HnUsvbY9M+FzKCcJXWb+vysO4e91u+D9X36Ifh/+5kDa4N0BTEKCEF/6I Q==; X-CSE-ConnectionGUID: srJ2MJLMQeq3/uCsdWD29w== X-CSE-MsgGUID: PfBVcLC7TXOH9TDHYzMfZg== X-IronPort-AV: E=McAfee;i="6800,10657,11833"; a="106422866" X-IronPort-AV: E=Sophos;i="6.25,141,1779174000"; d="scan'208";a="106422866" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2026 03:55:20 -0700 X-CSE-ConnectionGUID: ci0GyTkQQvCRryiMH+9o2g== X-CSE-MsgGUID: GVB/dza0RKCoTJodXYYUyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,141,1779174000"; d="scan'208";a="252114244" Received: from conormcd-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.244.65]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2026 03:55:14 -0700 Date: Wed, 1 Jul 2026 13:55:11 +0300 From: Andy Shevchenko To: Andy Shevchenko Cc: Michael Walle , Linus Walleij , Bartosz Golaszewski , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "afaerber@suse.com" , "wbg@kernel.org" , "mathieu.dubois-briand@bootlin.com" , "lars@metafoo.de" , "Michael.Hennerich@analog.com" , "jic23@kernel.org" , "nuno.sa@analog.com" , "andy@kernel.org" , "dlechner@baylibre.com" , =?utf-8?B?VFlfQ2hhbmdb5by15a2Q6YC4XQ==?= , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-realtek-soc@lists.infradead.org" , "linux-iio@vger.kernel.org" , =?utf-8?B?Q1lfSHVhbmdb6buD6Ymm5pmPXQ==?= , Stanley =?utf-8?B?Q2hhbmdb5piM6IKy5b63XQ==?= , James Tai =?utf-8?B?W+aItOW/l+WzsF0=?= , Yu-Chun Lin =?utf-8?B?W+ael+elkOWQm10=?= Subject: Re: [PATCH v3 2/7] gpio: regmap: add gpio_regmap_get_gpiochip() accessor Message-ID: References: <20260512033317.1602537-1-eleanor.lin@realtek.com> <20260512033317.1602537-3-eleanor.lin@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260701_035529_094916_705907E9 X-CRM114-Status: GOOD ( 25.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 01, 2026 at 01:01:10PM +0300, Andy Shevchenko wrote: > On Wed, Jul 1, 2026 at 11:44 AM Michael Walle wrote: > > On Fri Jun 19, 2026 at 11:08 PM CEST, Linus Walleij wrote: > > > On Mon, Jun 8, 2026 at 4:41 PM Michael Walle wrote: > > > > > >> >>> Without an accessor like gpio_regmap_get_gpiochip(), we cannot retrieve the > > >> >>> gpio_chip instantiated inside gpio-regmap.c to fulfill these requirements in our > > >> >>> map() function. > > >> > > >> Why is gpiochip_irq_reqres() called in the first place? Isn't that > > >> only called if the irq handling is set up via gc->irq.chip and not > > >> via gpiochip_irqchip_add_domain() like in gpio-regmap? > > > > > > Not really, the gpiochip_irq_reqres() is called to mark that a > > > GPIO line is used for IRQ, so the gpiolib cannot turn this > > > GPIO into an output line, gpiod_direction_out() will fail > > > on lines used for IRQ. So it's a failsafe. > > > > > > You can live without it of course, but then you don't get > > > this failsafe. > > > > Thanks for the explanation! So did I make a mistake years ago by > > adding the gpiochip_irqchip_add_domain(), see commit 6a45b0e2589f > > ("gpiolib: Introduce gpiochip_irqchip_add_domain()") > > > > As Yu-Chun found, gpiochip_irq_reqres() expect the irq chip data > > to be a gpio_chip, which isn't the case (in general) for an > > externally allocated domain, is it? > > So the whole issue comes from the fact that the IRQ chip is not marked > as immutable. For immutable IRQ chips (which all GPIO provides should > have) there is no such issue to begin with, id est there is no > gpiochip_irq_reqres() callback assigned (and respective _relres). Ah, for immutable chips we put either custom ones or GPIOCHIP_IRQ_RESOURCE_HELPERS which actually refers to those callbacks. So, if the domain is external, it should also provide irq_request_resources and release callbacks. In the custom case we can wrap gpiochip_reqres_irq() and gpiochip_relres_irq() respectively. But we need to have a struct gpio_chip pointer for them. And note, the IRQ chip data can be anything in that case, so it's not a requirement. -- With Best Regards, Andy Shevchenko