From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E751C43602 for ; Wed, 1 Jul 2026 12:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EPByOqFCTZTNbTHt7RHbWE2Bkb/VIE3pYgMmKcbOx5w=; b=ANpK5UlnHcg9gRnjqOFjCpEyft ERDyz9iK8Kj/5Ww8q8lQxc5s04iNgNL4oHILRKZz3XlEPoRMOYjY7GHLTVGzOVUZ1azhVc+yAcclQ LeKaf3xKuuDA67qDPCS/SWwpwo8WjlT9KuhuPAk+ziXpidYIurvRp7Oo0I1XIHismbaQjKml7oK2c V0nnDDlvRIggVcjpy50+tXB0E7eAWl3umR8F/yC0RoKpK3xBED8LmGa7Ev72UCsYCgdHnWl03ameS ccStHkYl5fzpxz982LNH4W43FOlq/Qaw65vc2MOS7XF+Cj/Q+Ks8FPjFZRCfiI1X9j45ZNevr50FR Ena4g77A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wetiB-00000001kQw-3CZK; Wed, 01 Jul 2026 12:06:39 +0000 Received: from mgamail.intel.com ([192.198.163.14]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wetf8-00000001cAy-1ZCR; Wed, 01 Jul 2026 12:03:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782907410; x=1814443410; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=zTxC5c8HFBif5AUkikItuKge2HnKcoCnMlvdO+scHVg=; b=O6bQD2/QtMLjffZyrk5yS10+K4FBg2sWmtUphTrpcRJhRM0vX2lmHdGh efMN1tc6n1i6cae/eiSy6Zb3zIRaeGH4eDOO0K7J18ZMT4H/apPHGdXSO o9nAQtZfuCYVV3KbTU/DYMS1ONwC1gCeHREpLA1+dj4ewKMA6xscmpkCb fshdrV5q3PASwW82ku/e5YsXD2pcezJm1fpzc9u//5c+yYjI6yk9HXqsb nPDnSB6UzilClon70UdUVhgGLZCs8u3nyrG4ANXvImU54wTblewkxSGVA oXUCnZumhUpVFrvebm8aFtY0/3IIYUbd7UkdAG5U/GxvfkLqVlKGv8Dla w==; X-CSE-ConnectionGUID: 8anqUwzzTxePdM9BtAzfBw== X-CSE-MsgGUID: 7ejVD8UyTK23ZCRRK7Zs+w== X-IronPort-AV: E=McAfee;i="6800,10657,11833"; a="83691895" X-IronPort-AV: E=Sophos;i="6.25,141,1779174000"; d="scan'208";a="83691895" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2026 05:03:30 -0700 X-CSE-ConnectionGUID: Z5gHly9sRw2vu6h0i+KEEA== X-CSE-MsgGUID: bnX2nW+fQHaFou/Pzptp6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,141,1779174000"; d="scan'208";a="254474062" Received: from conormcd-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.244.65]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2026 05:03:24 -0700 Date: Wed, 1 Jul 2026 15:03:22 +0300 From: Andy Shevchenko To: Michael Walle Cc: Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "afaerber@suse.com" , "wbg@kernel.org" , "mathieu.dubois-briand@bootlin.com" , "lars@metafoo.de" , "Michael.Hennerich@analog.com" , "jic23@kernel.org" , "nuno.sa@analog.com" , "andy@kernel.org" , "dlechner@baylibre.com" , =?utf-8?B?VFlfQ2hhbmdb5by15a2Q6YC4XQ==?= , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-realtek-soc@lists.infradead.org" , "linux-iio@vger.kernel.org" , =?utf-8?B?Q1lfSHVhbmdb6buD6Ymm5pmPXQ==?= , Stanley =?utf-8?B?Q2hhbmdb5piM6IKy5b63XQ==?= , James Tai =?utf-8?B?W+aItOW/l+WzsF0=?= , Yu-Chun Lin =?utf-8?B?W+ael+elkOWQm10=?= Subject: Re: [PATCH v3 2/7] gpio: regmap: add gpio_regmap_get_gpiochip() accessor Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260701_050330_460964_35AEB024 X-CRM114-Status: GOOD ( 39.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 01, 2026 at 01:42:55PM +0200, Michael Walle wrote: > On Wed Jul 1, 2026 at 1:38 PM CEST, Andy Shevchenko wrote: > > On Wed, Jul 01, 2026 at 01:55:11PM +0300, Andy Shevchenko wrote: > >> On Wed, Jul 01, 2026 at 01:01:10PM +0300, Andy Shevchenko wrote: > >> > On Wed, Jul 1, 2026 at 11:44 AM Michael Walle wrote: > >> > > On Fri Jun 19, 2026 at 11:08 PM CEST, Linus Walleij wrote: > >> > > > On Mon, Jun 8, 2026 at 4:41 PM Michael Walle wrote: > >> > > > > >> > > >> >>> Without an accessor like gpio_regmap_get_gpiochip(), we cannot retrieve the > >> > > >> >>> gpio_chip instantiated inside gpio-regmap.c to fulfill these requirements in our > >> > > >> >>> map() function. > >> > > >> > >> > > >> Why is gpiochip_irq_reqres() called in the first place? Isn't that > >> > > >> only called if the irq handling is set up via gc->irq.chip and not > >> > > >> via gpiochip_irqchip_add_domain() like in gpio-regmap? > >> > > > > >> > > > Not really, the gpiochip_irq_reqres() is called to mark that a > >> > > > GPIO line is used for IRQ, so the gpiolib cannot turn this > >> > > > GPIO into an output line, gpiod_direction_out() will fail > >> > > > on lines used for IRQ. So it's a failsafe. > >> > > > > >> > > > You can live without it of course, but then you don't get > >> > > > this failsafe. > >> > > > >> > > Thanks for the explanation! So did I make a mistake years ago by > >> > > adding the gpiochip_irqchip_add_domain(), see commit 6a45b0e2589f > >> > > ("gpiolib: Introduce gpiochip_irqchip_add_domain()") > >> > > > >> > > As Yu-Chun found, gpiochip_irq_reqres() expect the irq chip data > >> > > to be a gpio_chip, which isn't the case (in general) for an > >> > > externally allocated domain, is it? > >> > > >> > So the whole issue comes from the fact that the IRQ chip is not marked > >> > as immutable. For immutable IRQ chips (which all GPIO provides should > >> > have) there is no such issue to begin with, id est there is no > >> > gpiochip_irq_reqres() callback assigned (and respective _relres). > >> > >> Ah, for immutable chips we put either custom ones or > >> GPIOCHIP_IRQ_RESOURCE_HELPERS which actually refers to those callbacks. > >> > >> So, if the domain is external, it should also provide irq_request_resources > >> and release callbacks. In the custom case we can wrap gpiochip_reqres_irq() > >> and gpiochip_relres_irq() respectively. > >> > >> But we need to have a struct gpio_chip pointer for them. And note, the > >> IRQ chip data can be anything in that case, so it's not a requirement. > > > > And looking back for implementation in v3 the whole mistake was to use > > GPIOCHIP_IRQ_RESOURCE_HELPERS. It just wanted custom callbacks with > > the IRQ chip data assigned to whatever from which we may then deduce > > struct gpio_chip. It does *not* require to be struct gpio_chip. > > The local driver data structure should keep pointer to struct gpio_regmap. > > That one can be used in the respective .irq_request_resources() and > > .irq_release_resources(). The default ones for gpio-regmap may also > > be provided via a macro, say GPIO_REGMAP_IRQ_RESOURCE_HELPERS. > > > > Hence I don't see the need of having gpio_regmap_get_gpiochip() helper > > and driver can be implemented using gpio-regmap and external IRQ domain. > > > > What did I miss? > > IMHO nothing, that's exactly my understanding, too. Except for the > GPIO_REGMAP_IRQ_RESOURCE_HELPERS. See my previous mail. Because that > would have to be set by regmap-irq. There are two cases: - easy, when the chip is provided by the user (in this case we just missing a couple of callbacks in gpio-regmap) - hard, when chip is created by regmap-irq (in this case regmap-irq missing to setup the callbacks) So, effectively all GPIO drivers that use regmap-irq facility are now missing the functionality of tracking "GPIO locked as IRQ". -- With Best Regards, Andy Shevchenko