From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBA04C43458 for ; Thu, 2 Jul 2026 12:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9nEMQaKM2RATzk6vAZdT3nfnIXYypUIizU65bGtjkAY=; b=HunCG09z65kkQMVH7r8Ux7ZUIE f6tK97zk8ALWQErk2qXtDak9zorK0Fx2ynYyM+C12uS1pjN5hxpMmM9HY0g6sgvB+ZlW3Sm0EhKRy R9GUH6oMiAp3T0vvJXhcjaBGNgDQAun2A41hHAM4573kRmdcE0HmwmikSCJUsOHyLZh9F/oGWzhIX GTEkESFzHmSC2z2VlqPxd6+2PRlS7hhUf9z7P+tMAIIRDyj95Dc6rB7oTophUIeIJXqezfCUFd/GE 6PHZQv/WPS+3TUWb3x60VAuPDo2gUiHGKHG3AUw8Q82lkxrT2eO31URhYMQ0HrgOCfRMyDzueMvXu 62pIKxhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfGSb-00000004Qzi-3NF0; Thu, 02 Jul 2026 12:24:05 +0000 Received: from mail-westeuropeazon11010058.outbound.protection.outlook.com ([52.101.69.58] helo=AM0PR83CU005.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfGSY-00000004QyB-0ggJ for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2026 12:24:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CDeY5zz2eP8fSj4AvzSqZtqI2U/XH5xT5G4ZrrtrgypV/lt14o/tRlrmj24r3Yva1nAFOxkeVIyN8WTkJhT1trjmTznk+TTZcumWy0LP40gyl/oCF5bKhQNIZH91d+CuYMPEFVMQiPGCbKOS2nCL8M6tRmf8OjKCVF1fQMU0ebjkURvfEmdo3/jBHdAOJypdzMRvjq5/1a5ytAQWO9ZxEi9kDwjOyqbUMNqK5CU8mGQYTIZPLS86zjnqf9K0zz/tptkWySmnrGKwihstky6sMrR/CTIsF+qQlG3SXZQY04v/B4KE9Y1R+xFliIM3ryexV3obKYQLMmD1ppjTgWJxEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9nEMQaKM2RATzk6vAZdT3nfnIXYypUIizU65bGtjkAY=; b=RIqg/T3ckYTWG0jH/vEAVbs0z9VZmg5DWrPTsPfX/PkZ5aRBss+iYrBO6fdqVYa1RySpNRLAW4zORH9tt+UiCOgUlPGC0GO6RQ/ZEK1uE6ph6FCagKluwIidlSy4jRmSuTxJGnDFqddCAJwpxgE9+okBtn7B80Ywm7VnOhhb5zkeyqb83qWsZwzN9x1R9ahjmpg86FLFeJF8iJHQX/rtX2tdqotM7t5ffavvK0Vvx+YC3T8LdBod/WZOhCNjFy6bLVfjUywfrj56X/SvfDiLt4WxYn7Zk2VaYyr8sDf4sTygPSER9fogFT7zbRCZvlJdWvvdJ9ak+SdIv1PQMn1uJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9nEMQaKM2RATzk6vAZdT3nfnIXYypUIizU65bGtjkAY=; b=X068aKPP9sfVrYQDYlWv4ADIIIuBT5pU9prbsaMVrA0Qe7gWiVKC6BvbFnC7OMddP2kpgynBa3KTViaShgkARx1fvd4TfrrjpYbfVUNel9HfyrxWRD9Bur/as1qFQjb32Ofki45JYbb8ICmAeLpXR58HGcT76+9l0tI0pFBx8IalX5H2E5gn3CF1GBx05AgB2eR+qhzxOP7nGP0Ol6IOyzm1/1xWiMRkF3KNiixGTO5l61pUseBk5ghPb84zrl9B8wLQ4vCBvTS4nJxaZj1VFROEvUfteBSg7J3BGDKnEmhApd0zlhx2Qudh7d/Y952P80tTmQ9xSAfmjJ/oRjYvCw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) by AS8PR04MB8484.eurprd04.prod.outlook.com (2603:10a6:20b:34c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Thu, 2 Jul 2026 12:23:57 +0000 Received: from GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c]) by GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c%6]) with mapi id 15.21.0159.007; Thu, 2 Jul 2026 12:23:57 +0000 Date: Thu, 2 Jul 2026 07:23:44 -0500 From: Frank Li To: Ioana Ciornei Cc: Frank.Li@nxp.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, vladimir.oltean@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH v2 1/5] arm64: dts: lx2160a: transition to device-specific SerDes compatible strings Message-ID: References: <20260701131137.940145-1-ioana.ciornei@nxp.com> <20260701131137.940145-2-ioana.ciornei@nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: PH2PEPF00003854.namprd17.prod.outlook.com (2603:10b6:518:1::74) To GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR04MB11799:EE_|AS8PR04MB8484:EE_ X-MS-Office365-Filtering-Correlation-Id: 4334398e-aa9d-4b31-aea7-08ded834c963 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|1800799024|19092799006|376014|3023799007|18002099003|56012099006|22082099003|4143699003|11063799006; X-Microsoft-Antispam-Message-Info: VtJ76xXMqrRxFwA+v9e25NOknB9Oy7/8B11O2ZmKfQTu8rvlp6Y2r4sf1JiHXwFP7c4HM2YPZ1a2Di2UpptBrhO7toGrILCgtwhFi0ht5DRtrdFPvhjlfTJCqS/GGinXC+ydMfRKAP4mygv5+sAN0nlBU7N6IIFlXYaiMM7VZg65vVugkQPBa387jWfC63sRT++KpLUGciawTFx2yz5gG0eKGR/XQN6VsaxGqj41KvwrxUJ/OL4K0exrnXJYm9RpBYXBZOcWVWvRcbuhSzvTr1x30jsGMPh6ewNtgxqaYCS9xuECEGiIvQGp2YF8FBgZQStZVMWycDLvHXWQTKuQVmU8uZCpj3qrTtJh/LdNa5Q6p9Apvh9nzsaaqD8wcssW/8UimllbbhSjNoGsTM3WfghE+QArDYFUy+7TW2phe4riGuk8fkvRf91Y5m9M1PN7McKNEycLofxV+Os1VcHqQwm6Baps9Hi1w63UyAllpKDD1bjcQTDDUuFGCgK9xl8OZW2dTwmSlDdKn9cqpsCm7C5WFydwa+nd4+50uu8aAX7FNWehWYsjHgxAjLfZUg5KUL8gmO8JXZRcffCmDQ+AwA1P/aiZFtXTP4D7pp1SxbqTynw1zhqmZ+zYrF6XNdtXMuZCtrAJxlp6I08RPgCOWEHB25faSCvaS5EhIyyea2o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR04MB11799.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(1800799024)(19092799006)(376014)(3023799007)(18002099003)(56012099006)(22082099003)(4143699003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sBg0Kh61Ru7Sg+dhAi5orjUOT4Ywxg1lKim66XGLcd94s9FZxB1G0Ms9CWHD?= =?us-ascii?Q?husG5g3gLsWLt/iOt02f4QDnPy8EogzBsyTPwhr+kAHFAnHmvJMykDY3dWfx?= =?us-ascii?Q?7ay97upb/+2qm3oIIV4d1K8pe+MYDuyoF+9MB7++rf0I+VOzSu5BbnZgflGa?= =?us-ascii?Q?9kVNZr+wlbLsX5tMLdd1odDv9bQy+uYvQ+EpKnj0yuR8xghscM0D1VAmXnDr?= =?us-ascii?Q?RjFM4hlmDLJ/ya1HTyGkJn17I40qUpkmrXbWMcLxJzNTYGpqx9CFHTC3rllD?= =?us-ascii?Q?30LnWu+eySmFIwO/5vmoLL7K5qc3CtMfIRO2NznXPfRXUwKKDYc4WfWSekJn?= =?us-ascii?Q?iz9+VTNXhfWkEeqPcSDeuXdrXhfzS8atWAkEY5DSxolVl595p45j8ucY9FoI?= =?us-ascii?Q?6DiQmDrx2R8i1J5RA4Goj4ooV5S8zE9+XnUqHgU4EjQaVsTjgRwcdq+NLn01?= =?us-ascii?Q?1rNtMooTIeW3eu0LDyY97Vc4GNHVPIiPNnrUl04oyj/MMB5n7NE7II1RJE2q?= =?us-ascii?Q?bgNi30VOg8OFg5eboRQ78Wq2Wr1nP4JB1YJYfxgCcyZ4NFUENfdcdw0BEwK2?= =?us-ascii?Q?DwkKx12JAmCC/P8v8GNwnaoH/TyGRoNix1yRAiMt356miufJagSMOxTCL1bb?= =?us-ascii?Q?JcQ0qIfWNxUU79mPltzUMJqx3VuMX9yuClR8HvKAWA7Gxkd35IvaJnVMe+jE?= =?us-ascii?Q?9xS2fEZr0BnqOLbNj5fP/5sZTmF0UmPuNbN6pYY7ta83vkHR4APWmFhzSmD8?= =?us-ascii?Q?CmtWpMxxe9YXZ9XGqODode2C/poLlWHJovsMx6ZxBwV1YB1DYGWz6/71Yjyg?= =?us-ascii?Q?CBWpbEf3Ua3oMYwMt0vJOBXZA10/NzeC/9/ZaHjfu8HVjK+zNe+TQ9tsL07J?= =?us-ascii?Q?saEESNkmdw5nnia0YpeJ48PEGPe1C4v8VLjNrzyhRK0pFCh0/e5KhKvY0KJw?= =?us-ascii?Q?0CPPljlt7udh+BlQQb5uy16txET3kHWTPSeccV3Etkg3cwvHiK8jkxgbbXBB?= =?us-ascii?Q?yRqOwvFUhzQ2l4ZqPslAC16Mfe6u8m8tX34gsUmFiyZjJhEcGIxsL/zoTGRe?= =?us-ascii?Q?dTyHuiSqNCcT77vnWuMqzJNUO6/fncX+C/UJpcKjrGNU9IlAGNTmjQAWVbBk?= =?us-ascii?Q?/pk9RCp14rVCixhBEi/Y0ls+5DQn2w3opb8LRlokSP1/Ub3GqgYLtcGaGAAR?= =?us-ascii?Q?sqccioYie6cqdhfDLdkd0poMaxjbRwxqlnFissouWpklD5eZaWcjpLYtmpNt?= =?us-ascii?Q?FWEWjytk4RSObL6asHc15RHvfF87sGxiT7r5Cacu1BJ5m9FdCENYQl0bsFK3?= =?us-ascii?Q?GEru7MLzwIqzYTaGQ3GIB2DYVp+XOCsemwoct7mOKb0HLOSr6RJTE6+RSVgf?= =?us-ascii?Q?VBeMZX3NmHni538yVcZTERewzYzzyoPDSoSRVlQGH2yLFV1cOB5IMhteEmRG?= =?us-ascii?Q?VEZK8CWQEtQfFSMDGKkwYHfNXcjG2NnlmpgK5GLktIlB1G+2ovFw8YyPi8GE?= =?us-ascii?Q?opKy3MW3KezLTN+9SjkIqfJEYOhmIPwS6JO3dU/jjT+YlUUY++XZLw5IfIN2?= =?us-ascii?Q?T6pCl1FQQ69uY8c+mOZ7rA6b/lSd2Ei+aYOl+Kso60YZjxb9IWviKRI7qWEk?= =?us-ascii?Q?BsutsukTEHbGD96yNZo3H/jXxK/qpJoRH/C0i6PijPVVFAzSdrWnzShDppy0?= =?us-ascii?Q?ymkcJ6fQRSqucZJqNSZpoE2TCDX7mGaeaYeWeEsXaqNUAGEGlNnsqxsR7Sx1?= =?us-ascii?Q?e/dmGcvkHAFc6L0QLYY781vjhsC9RzbHqRLkuf5cNJOfcQF6nT0y?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4334398e-aa9d-4b31-aea7-08ded834c963 X-MS-Exchange-CrossTenant-AuthSource: GV2PR04MB11799.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2026 12:23:56.8808 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zVOy6C20faK0QqVW0KHgoG4pE5ZLMnrsnDKlzcKd3kKcZ19qlt1iUwJ5Lsv5m5FBAop9SvFOwB6aRzxpWHQOzAQQu1H2rfu9PAFZuKHbYLBpiLNRBXYZChTUbyDKjzTm X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8484 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260702_052402_224870_2981828F X-CRM114-Status: GOOD ( 46.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 02, 2026 at 10:35:00AM +0300, Ioana Ciornei wrote: > On Wed, Jul 01, 2026 at 09:27:03AM -0500, Frank Li wrote: > > On Wed, Jul 01, 2026 at 04:11:33PM +0300, Ioana Ciornei wrote: > > > From: Vladimir Oltean > > > > > > Align to the modern fsl,lynx-28g.yaml binding, where the SoC and SerDes > > > instance is present in the compatible string, to allow reliable per-lane > > > capability detection and per-lane customization of electrical properties. > > > > > > The modern bindings are backward-incompatible with old kernels, due > > > to the consumer phandles being either in one form or in another, as > > > explained here: > > > https://lore.kernel.org/lkml/20250930140735.mvo3jii7wgmzh2bs@skbuf/ > > > > > > One of the major differences between the LX2160A and LX2162A is the > > > SerDes. So far, LX2162A has used fsl-lx2160a-rev2.dtsi, but we need to > > > split that up even further, and derive a fsl-lx2162a.dtsi which > > > overrides the SerDes properties. > > > > > > Signed-off-by: Vladimir Oltean > > > Signed-off-by: Ioana Ciornei > > > --- > > > Changes in v2: > > > - Enable serdes_1 on all board DTs that has consumers for it. > > > - Use the proper name for serdes_3 in fsl-lx2162a.dtsi. > > > - Remove paragraph from commit message which mentioned some consumer > > > changes that are no longer needed nor part of the commit. > > > --- > > > .../freescale/fsl-lx2160a-clearfog-itx.dtsi | 4 + > > > .../dts/freescale/fsl-lx2160a-half-twins.dts | 4 + > > > .../boot/dts/freescale/fsl-lx2160a-rdb.dts | 4 + > > > .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 150 +++++++++++++++++- > > > .../dts/freescale/fsl-lx2162a-clearfog.dts | 6 +- > > > .../boot/dts/freescale/fsl-lx2162a-qds.dts | 2 +- > > > .../arm64/boot/dts/freescale/fsl-lx2162a.dtsi | 24 +++ > > > 7 files changed, 190 insertions(+), 4 deletions(-) > > > create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a.dtsi > > > > > ... > > > > > > +&serdes_1 { > > > + status = "okay"; > > > +}; > > > + > > > > Can you try keep alphabet order? may old file is not ordersed, but try > > best, at least should before &uart0 > > Sure, will move it. > > > > > > &uart1 { > > > status = "okay"; > > > }; > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > > index 1d73abffa6b7..a687eb3e3190 100644 > > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > > > Please split chips dtsi and boards dts to two patch. > > Ok, I will split the serdes_1 explicit enable into a prep patch. > > > > > > @@ -621,17 +621,163 @@ soc: soc { > > > ranges; > > > dma-ranges = <0x0 0x0 0x0 0x0 0x10000 0x00000000>; > > > > > > + /* Note on the interpretation of SerDes lane numbering from > > > + * LX2160ARM lane mappings for RCW[SRDS_PRTCL_S1]: > > > + * The letters (A-H) correspond to logical lane numbers in the > > > + * SerDes register map (lane A's registers start with LNAGCR0), > > > + * while the numbers (0-7) correspond to physical lanes as > > > + * routed to pins. SerDes block #1 is flipped in the LX2160A > > > + * floorplan (logical lane A goes to physical lane 7's pins), > > > + * while SerDes blocks #2 and #3 are not. The lanes below are > > > + * listed right to left when looking at that table. > > > + * Both the numbers and the letters are according to the logical > > > + * numbering scheme, and do not account for the flipping. > > > + */ > > ... > > > + compatible = "fsl,lx2160a-serdes3"; > > > + reg = <0x0 0x1ec0000 0x0 0x1e30>; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + status = "disabled"; > > > > status should be last property > > Ok, will move it. > > > > > > + #phy-cells = <1>; > > > + > > > + serdes_3_lane_a: phy@0 { > > > + reg = <0>; > > > + #phy-cells = <0>; > > > + }; > > > + > > ... > > > + > > > +#include "fsl-lx2160a-rev2.dtsi" > > > + > > > +&serdes_1 { > > > + compatible = "fsl,lx2162a-serdes1", "fsl,lynx-28g"; > > > + > > > + /delete-node/ phy@0; > > > + /delete-node/ phy@1; > > > + /delete-node/ phy@2; > > > + /delete-node/ phy@3; > > > > Now, do not perfer delete-node. if ver2 is not include phy@0, ... > > > > create ver2 files, let ver2 include it. Now most people like A + B, not > > A - B. > > > > I am not sure I follow what you say about the ver2 files - are you > referring to -rev2 or LX2162A? > > The LX2162A is a version of the LX2160A SoC, also known as "LX2-Lite". > And the main difference is that the LX2162A does not have the 3rd SerDes > block and only 4 SerDes lanes on the first block. If it is the same die and it is disable by fuse box. I suggest leave it here now because default it is disabled and try to access-control-cell in future. https://lore.kernel.org/imx/20241212-imx-ocotp-v1-1-198bb0af86a0@nxp.com/ That these nodes can be dymatically disabled it. If it is difference die, it should lx2160a.dtsi include lx2-lite. you can rename old lx2160a.dtsi to lx2-lites.dtsi. You need adjust file name and I just said overwhole method. Frank > > The delete-node is reflecting exactly how the SoCs came about, the > LX2162A is a smaller version of the LX2160A (which came first) and not > the other way around. > > I feel like it's unnecessary churn but let me know if you feel strongly > about this. > > Thanks, > Ioana