Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Chancel Liu <chancel.liu@oss.nxp.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] arm64: dts: imx91-9x9-qsb: Add PDM microphone sound card support
Date: Fri, 10 Jul 2026 10:50:19 -0500	[thread overview]
Message-ID: <alEUu_Vj7ZAkWikC@SMW015318> (raw)
In-Reply-To: <20260710024204.3462444-4-chancel.liu@oss.nxp.com>

On Fri, Jul 10, 2026 at 11:42:04AM +0900, Chancel Liu wrote:
> From: Chancel Liu <chancel.liu@nxp.com>
>
> Add PDM microphone sound card support, configure the pinmux.
>
> This sound card supports recording sound from PDM microphone and
> convert the PDM format data to PCM data.
>
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> ---
>  .../boot/dts/freescale/imx91-9x9-qsb.dts      | 44 +++++++++++++++++++
>  1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx91-9x9-qsb.dts b/arch/arm64/boot/dts/freescale/imx91-9x9-qsb.dts
> index e5983bb083ea..2f663b1f7c56 100644
> --- a/arch/arm64/boot/dts/freescale/imx91-9x9-qsb.dts
> +++ b/arch/arm64/boot/dts/freescale/imx91-9x9-qsb.dts
> @@ -79,6 +79,18 @@ sai1_fun: sai1-grp {
>  		};
>  	};
>
> +	dmic: dmic {


Is it order? look like it is after pinctrl-gpiomux, can you try best to
keep nodename orderred.

Frank


> +		compatible = "dmic-codec";
> +		#sound-dai-cells = <0>;
> +		num-channels = <4>;
> +
> +		port {
> +			dmic_ep: endpoint {
> +				remote-endpoint = <&micfil_ep>;
> +			};
> +		};
> +	};
> +
>  	reg_vref_1v8: regulator-adc-vref {
>  		compatible = "regulator-fixed";
>  		regulator-name = "vref_1v8";
> @@ -111,6 +123,12 @@ linux,cma {
>  		};
>  	};
>
> +	sound-micfil {
> +		compatible = "audio-graph-card2";
> +		label = "micfil-audio";
> +		links = <&micfil_port>;
> +	};
> +
>  	sound-wm8524 {
>  		compatible = "audio-graph-card2";
>  		label = "wm8524-audio";
> @@ -202,6 +220,14 @@ MX91_PAD_CCM_CLKO1__GPIO3_IO26                          0x31e
>  		>;
>  	};
>
> +	pinctrl_pdm: pdmgrp {
> +		fsl,pins = <
> +			MX91_PAD_PDM_CLK__PDM_CLK				0x31e
> +			MX91_PAD_PDM_BIT_STREAM0__PDM_BIT_STREAM0		0x31e
> +			MX91_PAD_PDM_BIT_STREAM1__PDM_BIT_STREAM1		0x31e
> +		>;
> +	};
> +
>  	pinctrl_reg_usdhc2_vmmc: regusdhc2vmmcgrp {
>  		fsl,pins = <
>  			MX91_PAD_SD2_RESET_B__GPIO3_IO7                         0x31e
> @@ -464,6 +490,24 @@ &lpuart1 {
>  	status = "okay";
>  };
>
> +&micfil {
> +	#sound-dai-cells = <0>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_pdm>, <&pdm_fun>;
> +	assigned-clocks = <&clk IMX93_CLK_PDM>;
> +	assigned-clock-parents = <&clk IMX93_CLK_AUDIO_PLL>;
> +	assigned-clock-rates = <49152000>;
> +	status = "okay";
> +
> +	micfil_port: port {
> +		capture-only;
> +
> +		micfil_ep: endpoint {
> +			remote-endpoint = <&dmic_ep>;
> +		};
> +	};
> +};
> +
>  &sai1 {
>  	#sound-dai-cells = <0>;
>  	pinctrl-names = "default";
> --
> 2.50.1
>
>


      reply	other threads:[~2026-07-10 15:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10  2:42 [PATCH v2 0/3] Add audio support on i.MX91 9x9 QSB Chancel Liu
2026-07-10  2:42 ` [PATCH v2 1/3] arm64: dts: imx91-9x9-qsb: Add audio-related board muxes Chancel Liu
2026-07-10  2:42 ` [PATCH v2 2/3] arm64: dts: imx91-9x9-qsb: Add WM8524 sound card support Chancel Liu
2026-07-10  2:42 ` [PATCH v2 3/3] arm64: dts: imx91-9x9-qsb: Add PDM microphone " Chancel Liu
2026-07-10 15:50   ` Frank Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alEUu_Vj7ZAkWikC@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=chancel.liu@oss.nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox