Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yeoreum Yun <yeoreum.yun@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Yeoreum Yun <yeoreum.yun@arm.com>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, mike.leach@arm.com,
	james.clark@linaro.org, alexander.shishkin@linux.intel.com,
	leo.yan@arm.com, jie.gan@oss.qualcomm.com
Subject: Re: [PATCH v8 00/13] fix several inconsistencies with sysfs configuration in etmX
Date: Thu, 16 Jul 2026 21:11:22 +0100	[thread overview]
Message-ID: <alk66r66GsiDX7wM@e129823.arm.com> (raw)
In-Reply-To: <alkv8JHDgylPBeSE@e129823.arm.com>

> On Thu, Jul 16, 2026 at 01:48:15PM +0100, Suzuki K Poulose wrote:
> > On 29/06/2026 09:59, Yeoreum Yun wrote:
> > > The current ETMx configuration via sysfs can lead to the following
> > > inconsistencies:
> > > 
> > >    - If a configuration is modified via sysfs while a perf session is
> > >      active, the running configuration may differ between before
> > >      a sched-out and after a subsequent sched-in.
> > > 
> > >    - If a perf session and sysfs session tries to enable concurrently,
> > >      configuration from configfs could be corrupted (etm4).
> > > 
> > >    - There is chance to corrupt drvdata->config if perf session tries
> > >      to enabled among handling cscfg_csdev_disable_active_config()
> > >      in etm4_disable_sysfs() (etm4).
> > > 
> > > To resolve these inconsistencies, the configuration should be separated into:
> > > 
> > >    - active_config, which is applied configuration for the current session
> > >    - config, which stores the settings configured via sysfs.
> > > 
> > > and apply configuration from configfs after taking a mode.
> > > 
> > > Also, This patch set includes some small fixes:
> > >    - missing trace id release in etm4x.
> > >    - underflow issue for nrseqstate.
> > >    - wrong check in etm4x_sspcicrn_present().
> > >    - missing call of cscfg_csdev_disable_active_config()
> > > 
> > > This patch based on coresight tree's next
> > 
> > 
> > Please could you move all the "Fixes" to the top of the series, that way
> > it is cleaner to backport for the stable kernels
> 
> Okay. but the fix which based on the cleanup wouldn't be top of it.
> I'll deploy below patches first:
> 
>   coresight: etm3x: change drvdata->spinlock type to raw_spin_lock_t
>   coresight: etm4x: fix leaked trace id
>   coresight: etm4x: fix underflow for usage of (nrseqstate - 1)
>   coresight: etm4x: fix wrong check of etm4x_sspcicrn_present()

Sorry. Ignore this please, I've moved all fix in the top properly.

Thanks!

[...]

-- 
Sincerely,
Yeoreum Yun


      reply	other threads:[~2026-07-16 20:11 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  8:59 [PATCH v8 00/13] fix several inconsistencies with sysfs configuration in etmX Yeoreum Yun
2026-06-29  8:59 ` [PATCH v8 01/13] coresight: etm4x: fix wrong check of etm4x_sspcicrn_present() Yeoreum Yun
2026-06-29  8:59 ` [PATCH v8 02/13] coresight: etm4x: fix underflow for usage of (nrseqstate - 1) Yeoreum Yun
2026-06-29  8:59 ` [PATCH v8 03/13] coresight: etm4x: introduce struct etm4_caps Yeoreum Yun
2026-06-29  8:59 ` [PATCH v8 04/13] coresight: etm4x: exclude ss_status from drvdata->config Yeoreum Yun
2026-06-29  8:59 ` [PATCH v8 05/13] coresight: etm4x: remove s_ex_level from config Yeoreum Yun
2026-06-29  8:59 ` [PATCH v8 06/13] coresight: etm4x: remove redundant fields in etmv4_save_state Yeoreum Yun
2026-06-29  9:00 ` [PATCH v8 07/13] coresight: etm4x: fix leaked trace id Yeoreum Yun
2026-06-29  9:00 ` [PATCH v8 08/13] coresight: etm4x: fix inconsistencies with sysfs configuration Yeoreum Yun
2026-07-06 17:21   ` Leo Yan
2026-07-06 18:16     ` Yeoreum Yun
2026-07-07  8:25       ` Leo Yan
2026-07-07  8:59         ` Yeoreum Yun
2026-07-07  9:54           ` Yeoreum Yun
2026-07-16 12:42             ` Suzuki K Poulose
2026-07-06 17:39   ` Leo Yan
2026-07-06 18:20     ` Yeoreum Yun
2026-07-07  8:07       ` Leo Yan
2026-07-16 12:41     ` Suzuki K Poulose
2026-07-16 20:09       ` Yeoreum Yun
2026-07-16 12:46   ` Suzuki K Poulose
2026-07-16 19:57     ` Yeoreum Yun
2026-06-29  9:00 ` [PATCH v8 09/13] coresight: etm4x: missing cscfg_csdev_disable_active_config() in perf enable Yeoreum Yun
2026-06-29  9:00 ` [PATCH v8 10/13] coresight: etm3x: change drvdata->spinlock type to raw_spin_lock_t Yeoreum Yun
2026-06-29  9:00 ` [PATCH v8 11/13] coresight: etm3x: introduce struct etm_caps Yeoreum Yun
2026-06-29  9:00 ` [PATCH v8 12/13] coresight: etm3x: fix inconsistencies with sysfs configuration Yeoreum Yun
2026-06-29  9:00 ` [PATCH v8 13/13] coresight: etm3x: remove redundant cpu online check on etm_enable_sysfs() Yeoreum Yun
2026-07-16 12:48 ` [PATCH v8 00/13] fix several inconsistencies with sysfs configuration in etmX Suzuki K Poulose
2026-07-16 19:24   ` Yeoreum Yun
2026-07-16 20:11     ` Yeoreum Yun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alk66r66GsiDX7wM@e129823.arm.com \
    --to=yeoreum.yun@arm.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=james.clark@linaro.org \
    --cc=jie.gan@oss.qualcomm.com \
    --cc=leo.yan@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.leach@arm.com \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox