From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@pwsan.com (Paul Walmsley) Date: Mon, 25 Jun 2012 00:18:50 -0600 (MDT) Subject: [PATCH 02/11] mmc: omap: add clk_prepare and clk_unprepare In-Reply-To: <4FE7F636.7040803@ti.com> References: <1340372890-10091-1-git-send-email-rnayak@ti.com> <1340372890-10091-3-git-send-email-rnayak@ti.com> <4FE7F636.7040803@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 25 Jun 2012, Rajendra Nayak wrote: > On Saturday 23 June 2012 12:04 AM, Paul Walmsley wrote: > > On Fri, 22 Jun 2012, S, Venkatraman wrote: > > > > > On Fri, Jun 22, 2012 at 7:18 PM, Rajendra Nayak wrote: > > > > In preparation of OMAP moving to Common Clk Framework(CCF) add > > > > clk_prepare() > > > > and clk_unprepare() for the mmc and hsmmc clocks as part of the drivers > > > > probe() and remove() routines. > > > > > > > > Signed-off-by: Rajendra Nayak > > > > Cc: Chris Ball > > > > Cc: Balaji T K > > > > Cc: > > > > > > Rajendra, > > > Can this be applied independently, or does this patch have a > > > dependency on other patches in the series ? > > > > A better way to handle this one would be to convert the driver to runtime > > PM. That needs to be done anyway. > > Well, mmc driver is already using runtime PM. But it still using clock > apis' to deal with some optional debounce clock needed only on 2430. drivers/mmc/host/omap.c, which is what this patch changes, has not yet been converted to use runtime PM in mainline. This is a driver for the MSDI IP block which is not available on 2430. - Paul