From: paul@pwsan.com (Paul Walmsley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: Only write the sysconfig on idle when necessary
Date: Wed, 17 Oct 2012 20:58:57 +0000 (UTC) [thread overview]
Message-ID: <alpine.DEB.2.00.1210172046100.9767@utopia.booyaka.com> (raw)
In-Reply-To: <507F16F5.9020803@ti.com>
On Wed, 17 Oct 2012, Jon Hunter wrote:
> Are you looking to go one step further and only update the sysconfig on
> enabling when the context has been lost? That would require more
> changes.
Yes that's exactly it. That would avoid adding a special case for what
should be the common case. From a quick glance it looks like the cache
needs to be loaded in _reset(), omap_hwmod_softreset(), and _enable().
Other than that, seems like the cached value should work.
It should also be possible to avoid the reload in _enable() in most cases
since the PM code should know whether the IP block's powerdomain was
programmed to go off and indeed whether it did so. It shouldn't involve
any extra register reads. But I wouldn't expect you to add that
optimization; would just be nice to have a comment to that effect.
If the meta-theme of your message is that commit
233cbe5b94096f95ba7bca2162d63275b0b90b5b should have had closer scrutiny,
I agree with you, but we're beyond that point now...
- Paul
next prev parent reply other threads:[~2012-10-17 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 20:12 [PATCH] ARM: OMAP2+: Only write the sysconfig on idle when necessary Jon Hunter
2012-10-17 20:25 ` Paul Walmsley
2012-10-17 20:37 ` Jon Hunter
2012-10-17 20:58 ` Paul Walmsley [this message]
2012-10-17 21:22 ` Jon Hunter
2012-10-18 5:49 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1210172046100.9767@utopia.booyaka.com \
--to=paul@pwsan.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox